branch-3.0: [opt](compaction) Don't check missed rows in cumu compaction if input rowsets are not in tablet #45279#45303
Merged
dataroaring merged 1 commit intobranch-3.0from Dec 19, 2024
Conversation
… rowsets are not in tablet (#45279) Problem Summary: Suppose a heavy schema change process on BE converting tablet A to tablet B. 1. during schema change double write, new loads write [X-Y] on tablet B. 2. rowsets with version [a],[a+1],...,[b-1],[b] on tablet B are picked for cumu compaction(X<=a<b<=Y).(cumu compaction on new tablet during schema change double write is allowed after #16470) 3. schema change remove all rowsets on tablet B before version Z(b<=Z<=Y) before it begins to convert historical rowsets. 4. schema change finishes. 5. cumu compation begins on new tablet with version [a],...,[b]. If there are duplicate keys between these rowsets, the compaction check will fail because these rowsets have skipped to calculate delete bitmap in commit phase and publish phase because tablet B is in NOT_READY state when writing. This PR makes cumu compaction skip to do missed rows check when it finds out that the input rowsets are not exist in tablet. Note that the compaction will fail because `Tablet::modify_rowsets` will check if rowsets in `to_delete` still exist in tablet's `_rs_version_map`.
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
Contributor
Author
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40679 ms |
TPC-DS: Total hot run time: 196624 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #45279