Skip to content

[bugfix](becore) local exchange should check receiver's local state to avoid core#45470

Merged
yiguolei merged 3 commits intoapache:masterfrom
yiguolei:fix_1
Dec 17, 2024
Merged

[bugfix](becore) local exchange should check receiver's local state to avoid core#45470
yiguolei merged 3 commits intoapache:masterfrom
yiguolei:fix_1

Conversation

@yiguolei
Copy link
Contributor

What problem does this PR solve?

_local_recvr depdend on pipeline::ExchangeLocalState* _parent to do some memory counter settings
but it only owns a raw pointer, so that the ExchangeLocalState object may be deconstructed.
So that I lock the local state to avoid it is deconstruted

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Dec 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.85% (10125/26064)
Line Coverage: 29.77% (85110/285885)
Region Coverage: 28.81% (43636/151466)
Branch Coverage: 25.34% (22161/87438)
Coverage Report: http://coverage.selectdb-in.cc/coverage/61a4b156e1f2abc5c8069d030fdcc507161c68c4_61a4b156e1f2abc5c8069d030fdcc507161c68c4/report/index.html

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.85% (10125/26064)
Line Coverage: 29.77% (85116/285922)
Region Coverage: 28.81% (43650/151490)
Branch Coverage: 25.34% (22163/87458)
Coverage Report: http://coverage.selectdb-in.cc/coverage/628265620c900ba015c904ca4b38d0057fddb01f_628265620c900ba015c904ca4b38d0057fddb01f/report/index.html

@yiguolei
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.84% (10124/26064)
Line Coverage: 29.77% (85122/285922)
Region Coverage: 28.82% (43654/151490)
Branch Coverage: 25.34% (22165/87458)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b08ec78e2dffe4a665a2f28d1022ed0cd92ae7f6_b08ec78e2dffe4a665a2f28d1022ed0cd92ae7f6/report/index.html

@yiguolei
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.85% (10126/26064)
Line Coverage: 29.76% (85084/285906)
Region Coverage: 28.81% (43643/151496)
Branch Coverage: 25.35% (22168/87456)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c2793bccf2f35db11fbcfc26ed15c4d9557303ac_c2793bccf2f35db11fbcfc26ed15c4d9557303ac/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 17, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 2e4d861 into apache:master Dec 17, 2024
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
…o avoid core (#45470)



_local_recvr depdend on pipeline::ExchangeLocalState* _parent to do some
memory counter settings
but it only owns a raw pointer, so that the ExchangeLocalState object
may be deconstructed.
So that I lock the local state to avoid it is deconstruted
yiguolei added a commit that referenced this pull request Dec 17, 2024
…o avoid core (#45470)



_local_recvr depdend on pipeline::ExchangeLocalState* _parent to do some
memory counter settings
but it only owns a raw pointer, so that the ExchangeLocalState object
may be deconstructed.
So that I lock the local state to avoid it is deconstruted
yiguolei added a commit that referenced this pull request Dec 17, 2024
…ocal state to avoid core #45470 (#45541)

Cherry-picked from #45470

Co-authored-by: yiguolei <guolei@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged p0_c reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants