Skip to content

branch-2.1: [fix](hudi) remove session variable field in HudiScanNode #45762 #45764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Dec 22, 2024
Merged

branch-2.1: [fix](hudi) remove session variable field in HudiScanNode #45762 #45764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions fe/fe-core/src/main/java/org/apache/doris/datasource/hudi/source/HudiScanNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,6 @@ public class HudiScanNode extends HiveScanNode {

private final AtomicLong noLogsSplitNum = new AtomicLong(0);

private final boolean useHiveSyncPartition;

private HoodieTableMetaClient hudiClient;
private String basePath;
private String inputFormat;
Expand All @@ -102,7 +100,6 @@ public class HudiScanNode extends HiveScanNode {

private boolean partitionInit = false;
private HoodieTimeline timeline;
private Option<String> snapshotTimestamp;
private String queryInstant;

private final AtomicReference<UserException> batchException = new AtomicReference<>(null);
Expand All @@ -113,7 +110,6 @@ public class HudiScanNode extends HiveScanNode {
private boolean incrementalRead = false;
private TableScanParams scanParams;
private IncrementalRelation incrementalRelation;
private SessionVariable sessionVariable;

/**
* External file scan node for Query Hudi table
Expand All @@ -136,11 +132,9 @@ public HudiScanNode(PlanNodeId id, TupleDescriptor desc, boolean needCheckColumn
hmsTable.getFullQualifiers());
}
}
useHiveSyncPartition = hmsTable.useHiveSyncPartition();
this.scanParams = scanParams.orElse(null);
this.incrementalRelation = incrementalRelation.orElse(null);
this.incrementalRead = (this.scanParams != null && this.scanParams.incrementalRead());
this.sessionVariable = sessionVariable;
}

@Override
Expand Down Expand Up @@ -215,7 +209,6 @@ protected void doInitialize() throws UserException {
throw new UserException("Hudi does not support `FOR VERSION AS OF`, please use `FOR TIME AS OF`");
}
queryInstant = tableSnapshot.getTime().replaceAll("[-: ]", "");
snapshotTimestamp = Option.of(queryInstant);
} else {
Option<HoodieInstant> snapshotInstant = timeline.lastInstant();
if (!snapshotInstant.isPresent()) {
Expand All @@ -224,7 +217,6 @@ protected void doInitialize() throws UserException {
return;
}
queryInstant = snapshotInstant.get().getTimestamp();
snapshotTimestamp = Option.empty();
}
}

Expand Down