Skip to content

[style](fe) add package directory structure matching check#45794

Merged
morrySnow merged 1 commit intoapache:masterfrom
morrySnow:add_package_match_check
Dec 23, 2024
Merged

[style](fe) add package directory structure matching check#45794
morrySnow merged 1 commit intoapache:masterfrom
morrySnow:add_package_match_check

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Dec 23, 2024

What problem does this PR solve?

Problem Summary:

check fe-core package directory structure to ensure it is same with package name in files and fix check failed files

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 23, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor Author

morrySnow commented Dec 23, 2024

run buildall

@morrySnow morrySnow force-pushed the add_package_match_check branch from 1aed2eb to 72823be Compare December 23, 2024 09:13
@morrySnow
Copy link
Contributor Author

morrySnow commented Dec 23, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Dec 23, 2024

TPC-H: Total hot run time: 39888 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 72823bef0daa39577acf9854d24747ac707343d5, data reload: false

------ Round 1 ----------------------------------
q1	17219	7604	7610	7604
q2	1019	180	179	179
q3	9574	1144	1168	1144
q4	6004	726	682	682
q5	2712	2633	2634	2633
q6	237	145	147	145
q7	956	617	603	603
q8	1810	1896	1862	1862
q9	6456	6321	6388	6321
q10	2552	2317	2354	2317
q11	388	238	251	238
q12	422	220	227	220
q13	16981	2913	2978	2913
q14	241	205	221	205
q15	560	500	498	498
q16	618	603	586	586
q17	976	487	553	487
q18	7163	6682	6665	6665
q19	1331	1034	963	963
q20	438	181	179	179
q21	4012	3139	3199	3139
q22	373	305	309	305
Total cold run time: 82042 ms
Total hot run time: 39888 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7250	7220	7197	7197
q2	326	244	241	241
q3	2908	2794	2789	2789
q4	1990	1753	1717	1717
q5	5344	5379	5430	5379
q6	223	136	137	136
q7	2134	1721	1768	1721
q8	3255	3382	3424	3382
q9	8626	8569	8556	8556
q10	3467	3443	3459	3443
q11	593	497	524	497
q12	770	583	577	577
q13	3756	3000	2914	2914
q14	296	261	263	261
q15	542	500	486	486
q16	673	653	628	628
q17	1780	1560	1547	1547
q18	7848	7458	7451	7451
q19	1670	1654	1424	1424
q20	2040	1820	1889	1820
q21	5520	5158	5298	5158
q22	629	552	569	552
Total cold run time: 61640 ms
Total hot run time: 57876 ms

@doris-robot
Copy link

doris-robot commented Dec 23, 2024

TPC-DS: Total hot run time: 188886 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 72823bef0daa39577acf9854d24747ac707343d5, data reload: false

query1	963	374	353	353
query2	6521	2370	2318	2318
query3	6708	211	214	211
query4	33764	23124	23337	23124
query5	4367	445	453	445
query6	291	189	181	181
query7	4626	307	312	307
query8	305	232	232	232
query9	9708	2767	2759	2759
query10	482	252	247	247
query11	18051	15058	15052	15052
query12	175	103	107	103
query13	1677	440	411	411
query14	11120	7325	6740	6740
query15	316	185	197	185
query16	8256	449	465	449
query17	1767	581	578	578
query18	2156	302	305	302
query19	375	187	149	149
query20	125	107	112	107
query21	207	104	109	104
query22	4343	4351	4165	4165
query23	34675	33441	33674	33441
query24	10254	2486	2456	2456
query25	637	384	410	384
query26	1211	148	150	148
query27	2333	325	334	325
query28	7624	2454	2433	2433
query29	818	413	404	404
query30	289	145	153	145
query31	1015	834	822	822
query32	96	58	62	58
query33	798	293	274	274
query34	996	509	522	509
query35	869	760	728	728
query36	1077	953	953	953
query37	147	89	76	76
query38	4137	4140	4013	4013
query39	1465	1420	1427	1420
query40	204	98	100	98
query41	48	42	43	42
query42	116	113	101	101
query43	525	493	500	493
query44	1293	819	806	806
query45	184	167	164	164
query46	1145	711	692	692
query47	1932	1849	1833	1833
query48	415	322	329	322
query49	1137	382	392	382
query50	796	397	381	381
query51	7167	7088	6925	6925
query52	101	94	90	90
query53	252	181	185	181
query54	1231	399	403	399
query55	83	78	79	78
query56	250	229	236	229
query57	1260	1115	1087	1087
query58	224	214	221	214
query59	3099	2909	2859	2859
query60	270	236	245	236
query61	105	104	131	104
query62	881	675	671	671
query63	225	186	198	186
query64	4013	670	653	653
query65	3260	3191	3179	3179
query66	845	311	312	311
query67	15678	15429	15333	15333
query68	5334	553	566	553
query69	476	249	255	249
query70	1201	1135	1154	1135
query71	496	277	242	242
query72	7053	4177	4073	4073
query73	789	365	366	365
query74	9884	8787	8766	8766
query75	3813	2626	2661	2626
query76	3760	999	1113	999
query77	648	342	286	286
query78	10199	9647	9534	9534
query79	2590	601	621	601
query80	987	414	438	414
query81	559	237	228	228
query82	1048	112	118	112
query83	281	148	145	145
query84	241	77	77	77
query85	1604	311	338	311
query86	488	296	308	296
query87	4458	4465	4340	4340
query88	3792	2256	2207	2207
query89	411	297	302	297
query90	1997	183	191	183
query91	133	109	108	108
query92	64	52	52	52
query93	1801	559	553	553
query94	897	286	283	283
query95	350	249	255	249
query96	612	279	282	279
query97	2842	2653	2672	2653
query98	213	198	195	195
query99	1587	1317	1315	1315
Total cold run time: 302091 ms
Total hot run time: 188886 ms

@doris-robot
Copy link

doris-robot commented Dec 23, 2024

ClickBench: Total hot run time: 31.48 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 72823bef0daa39577acf9854d24747ac707343d5, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.23	0.07	0.08
query4	1.60	0.10	0.10
query5	0.42	0.40	0.43
query6	1.19	0.67	0.66
query7	0.02	0.01	0.01
query8	0.04	0.04	0.02
query9	0.58	0.51	0.52
query10	0.54	0.57	0.55
query11	0.14	0.11	0.11
query12	0.14	0.11	0.12
query13	0.61	0.61	0.59
query14	2.87	2.73	2.74
query15	0.89	0.82	0.82
query16	0.38	0.36	0.38
query17	1.05	0.99	0.98
query18	0.22	0.21	0.21
query19	1.99	1.86	2.04
query20	0.02	0.01	0.01
query21	15.37	0.60	0.60
query22	2.92	2.39	1.31
query23	17.13	0.87	0.71
query24	3.28	1.40	0.66
query25	0.17	0.25	0.07
query26	0.41	0.14	0.13
query27	0.05	0.04	0.03
query28	10.56	1.10	1.08
query29	12.57	3.24	3.21
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.24	0.45	0.45
query33	3.05	3.02	3.12
query34	17.09	4.43	4.40
query35	4.51	4.45	4.44
query36	0.65	0.50	0.47
query37	0.10	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.12	0.13
query41	0.08	0.03	0.02
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 107.66 s
Total hot run time: 31.48 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 23, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 23, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit e5991cc into apache:master Dec 23, 2024
@morrySnow morrySnow deleted the add_package_match_check branch December 23, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@924060929 924060929 924060929 approved these changes

@starocean999 starocean999 starocean999 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morrySnow @hello-stephen @doris-robot @924060929 @starocean999