Skip to content

branch-3.0: [fix](variant) disable column name with dot character for variant type #45927#45990

Merged
eldenmoon merged 1 commit intobranch-3.0from
auto-pick-45927-branch-3.0
Dec 27, 2024
Merged

branch-3.0: [fix](variant) disable column name with dot character for variant type #45927#45990
eldenmoon merged 1 commit intobranch-3.0from
auto-pick-45927-branch-3.0

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #45927

#45927)

Variant type column named with '.' character make be crashed, here
disable it temporarily.
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Dec 26, 2024
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41291 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f4e60617b4551aeba246e6a661e463cd59f7a1d3, data reload: false

------ Round 1 ----------------------------------
q1	17568	7449	7333	7333
q2	2060	193	177	177
q3	10556	1090	1185	1090
q4	10574	766	791	766
q5	7762	2925	2783	2783
q6	239	145	143	143
q7	960	627	611	611
q8	9369	1977	2066	1977
q9	6603	6447	6444	6444
q10	7072	2326	2303	2303
q11	480	269	263	263
q12	405	213	210	210
q13	17818	3019	3012	3012
q14	242	212	211	211
q15	567	514	514	514
q16	688	630	602	602
q17	988	599	675	599
q18	7282	6741	6875	6741
q19	1392	1040	1051	1040
q20	469	212	193	193
q21	4007	3270	3301	3270
q22	1133	1031	1009	1009
Total cold run time: 108234 ms
Total hot run time: 41291 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7293	7239	7215	7215
q2	325	231	228	228
q3	3034	2931	2953	2931
q4	2073	1864	1796	1796
q5	5692	5758	5739	5739
q6	226	140	142	140
q7	2232	1836	1876	1836
q8	3349	3682	3439	3439
q9	8960	9020	8942	8942
q10	3617	3545	3536	3536
q11	612	510	505	505
q12	816	622	651	622
q13	10071	3164	3179	3164
q14	328	296	275	275
q15	579	536	543	536
q16	725	703	676	676
q17	1886	1615	1619	1615
q18	8366	7814	7368	7368
q19	1703	1583	1636	1583
q20	2134	1862	1866	1862
q21	5626	5407	5431	5407
q22	1151	1059	1043	1043
Total cold run time: 70798 ms
Total hot run time: 60458 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197351 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f4e60617b4551aeba246e6a661e463cd59f7a1d3, data reload: false

query1	1250	927	955	927
query2	6266	2105	2164	2105
query3	10971	4438	4326	4326
query4	66539	29231	23423	23423
query5	5158	451	439	439
query6	426	176	173	173
query7	5671	314	310	310
query8	314	234	236	234
query9	9165	2692	2683	2683
query10	494	282	254	254
query11	18141	15309	15887	15309
query12	146	100	102	100
query13	1609	442	420	420
query14	10540	7571	7055	7055
query15	203	187	178	178
query16	7102	474	511	474
query17	1348	592	626	592
query18	1334	329	318	318
query19	225	176	160	160
query20	125	110	105	105
query21	73	46	45	45
query22	4795	4433	4337	4337
query23	34673	34285	34287	34285
query24	6051	2955	2887	2887
query25	569	430	421	421
query26	670	177	175	175
query27	2031	328	319	319
query28	4193	2522	2507	2507
query29	693	433	405	405
query30	245	161	165	161
query31	986	837	842	837
query32	66	53	55	53
query33	452	268	297	268
query34	898	503	523	503
query35	865	741	761	741
query36	1111	991	976	976
query37	117	75	78	75
query38	4196	4073	4003	4003
query39	1539	1474	1458	1458
query40	141	77	81	77
query41	53	46	46	46
query42	111	100	94	94
query43	540	511	517	511
query44	1171	852	813	813
query45	183	163	169	163
query46	1162	724	745	724
query47	1999	1943	1969	1943
query48	466	381	392	381
query49	753	386	393	386
query50	867	416	430	416
query51	7368	7213	7062	7062
query52	98	83	87	83
query53	249	176	175	175
query54	541	450	445	445
query55	75	74	76	74
query56	250	248	251	248
query57	1216	1064	1120	1064
query58	209	206	209	206
query59	3199	3061	2970	2970
query60	276	271	250	250
query61	105	108	104	104
query62	758	647	665	647
query63	211	195	198	195
query64	1426	661	640	640
query65	3237	3181	3195	3181
query66	686	296	302	296
query67	16019	15623	15788	15623
query68	4586	558	562	558
query69	410	266	263	263
query70	1208	1110	1135	1110
query71	346	247	254	247
query72	6563	4084	4023	4023
query73	736	344	347	344
query74	9969	9025	8951	8951
query75	3361	2669	2662	2662
query76	1874	1002	1095	1002
query77	501	271	273	271
query78	10494	9672	9553	9553
query79	2267	602	613	602
query80	1415	418	420	418
query81	537	256	242	242
query82	1252	121	114	114
query83	197	146	139	139
query84	271	80	80	80
query85	988	315	295	295
query86	405	262	294	262
query87	4404	4327	4364	4327
query88	3995	2407	2336	2336
query89	403	287	284	284
query90	1992	184	181	181
query91	176	148	144	144
query92	66	48	48	48
query93	2892	556	540	540
query94	800	302	278	278
query95	366	249	255	249
query96	619	282	291	282
query97	3387	3192	3221	3192
query98	216	206	202	202
query99	1568	1304	1294	1294
Total cold run time: 322883 ms
Total hot run time: 197351 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.18 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f4e60617b4551aeba246e6a661e463cd59f7a1d3, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.02
query3	0.22	0.07	0.07
query4	1.63	0.10	0.10
query5	0.53	0.51	0.53
query6	1.13	0.72	0.73
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.51
query10	0.53	0.55	0.55
query11	0.14	0.10	0.11
query12	0.14	0.12	0.10
query13	0.61	0.59	0.59
query14	2.92	2.90	2.90
query15	0.89	0.83	0.82
query16	0.39	0.39	0.40
query17	1.04	1.05	1.02
query18	0.23	0.22	0.22
query19	1.89	1.79	2.01
query20	0.02	0.01	0.01
query21	15.35	0.62	0.61
query22	2.44	1.77	1.50
query23	16.97	1.13	0.78
query24	3.36	0.44	1.15
query25	0.26	0.15	0.20
query26	0.32	0.14	0.14
query27	0.05	0.05	0.04
query28	10.84	1.10	1.07
query29	12.55	3.31	3.29
query30	0.25	0.05	0.06
query31	2.87	0.37	0.37
query32	3.29	0.46	0.47
query33	3.02	3.06	3.05
query34	17.16	4.47	4.51
query35	4.58	4.54	4.49
query36	0.67	0.51	0.48
query37	0.10	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.04
Total cold run time: 107.51 s
Total hot run time: 32.18 s

@eldenmoon eldenmoon merged commit 06b7485 into branch-3.0 Dec 27, 2024
12 checks passed
@github-actions github-actions bot deleted the auto-pick-45927-branch-3.0 branch December 27, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants