[fix](scan) Fix scan with limit#46035
Merged
yiguolei merged 1 commit intoapache:masterfrom Dec 27, 2024
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 32539 ms |
TPC-DS: Total hot run time: 189898 ms |
ClickBench: Total hot run time: 31.26 s |
Contributor
Author
|
run beut |
Contributor
Author
|
run external |
|
TeamCity be ut coverage result: |
yiguolei
approved these changes
Dec 27, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
jacktengg
approved these changes
Dec 27, 2024
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Dec 27, 2024
Related PR: apache#39927 apache#39927 introduced a new session var `adaptive_pipeline_task_serial_read_on_limit`, its implementation has flaw, reduce scanner parallelism should only happen when there is not conjunction. Since we can not estimate the filtration efficiency.
zhiqiang-hhhh
added a commit
to zhiqiang-hhhh/doris
that referenced
this pull request
Dec 27, 2024
Related PR: apache#39927 apache#39927 introduced a new session var `adaptive_pipeline_task_serial_read_on_limit`, its implementation has flaw, reduce scanner parallelism should only happen when there is not conjunction. Since we can not estimate the filtration efficiency.
yiguolei
pushed a commit
that referenced
this pull request
Dec 27, 2024
yiguolei
pushed a commit
that referenced
this pull request
Dec 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Related PR: #39927
#39927 introduced a new session var
adaptive_pipeline_task_serial_read_on_limit, its implementation has flaw, reduce scanner parallelism should only happen when there is not conjunction. Since we can not estimate the filtration efficiency.Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)