Skip to content

branch-3.0: [improve](move-memtable) disable stack trace in load stream reply #46318#46331

Merged
dataroaring merged 1 commit intobranch-3.0from
auto-pick-46318-branch-3.0
Jan 17, 2025
Merged

branch-3.0: [improve](move-memtable) disable stack trace in load stream reply #46318#46331
dataroaring merged 1 commit intobranch-3.0from
auto-pick-46318-branch-3.0

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 3, 2025

Cherry-picked from #46318

…6318)

LoadStreamStub is logging too much on errors.
This PR simplifies the logs by disabling the stack trace, without
changing functionality.
@Thearas
Copy link
Contributor

Thearas commented Jan 3, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 3, 2025
@dataroaring dataroaring reopened this Jan 3, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 3, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41113 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 64a498a47ab18ccdac63718f58410658b30e785c, data reload: false

------ Round 1 ----------------------------------
q1	17573	7553	7279	7279
q2	2103	176	173	173
q3	10699	1114	1152	1114
q4	10548	767	782	767
q5	7770	2852	2862	2852
q6	237	153	144	144
q7	980	621	602	602
q8	9369	1958	1997	1958
q9	6603	6433	6418	6418
q10	7056	2273	2319	2273
q11	466	273	257	257
q12	406	214	212	212
q13	17792	2990	3016	2990
q14	232	213	204	204
q15	574	523	536	523
q16	686	620	614	614
q17	1003	621	586	586
q18	7252	6682	6592	6592
q19	1408	1099	1053	1053
q20	481	212	202	202
q21	4118	3309	3368	3309
q22	1082	991	1005	991
Total cold run time: 108438 ms
Total hot run time: 41113 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7252	7213	7249	7213
q2	327	240	233	233
q3	2965	2933	2956	2933
q4	2077	1866	1762	1762
q5	5750	5780	5726	5726
q6	217	144	148	144
q7	2256	1827	1856	1827
q8	3381	3608	3520	3520
q9	8893	8966	8918	8918
q10	3590	3561	3569	3561
q11	607	511	506	506
q12	813	621	605	605
q13	11082	3218	3202	3202
q14	316	285	279	279
q15	577	538	539	538
q16	697	675	667	667
q17	1863	1631	1618	1618
q18	8254	7734	7735	7734
q19	1668	1612	1564	1564
q20	2122	1892	1913	1892
q21	5464	5407	5520	5407
q22	1162	1032	1055	1032
Total cold run time: 71333 ms
Total hot run time: 60881 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198447 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 64a498a47ab18ccdac63718f58410658b30e785c, data reload: false

query1	1293	934	937	934
query2	6220	2062	2164	2062
query3	11050	4405	4255	4255
query4	66888	28865	23491	23491
query5	4879	480	485	480
query6	423	183	210	183
query7	5525	316	322	316
query8	324	241	239	239
query9	9026	2710	2711	2710
query10	452	285	264	264
query11	17245	15337	15816	15337
query12	154	104	100	100
query13	1467	435	449	435
query14	10106	7037	7731	7037
query15	208	183	182	182
query16	7117	495	488	488
query17	1294	591	617	591
query18	1877	334	330	330
query19	213	167	171	167
query20	129	113	112	112
query21	59	46	45	45
query22	4612	4513	4451	4451
query23	34928	34883	34498	34498
query24	6205	2988	2947	2947
query25	528	446	425	425
query26	668	172	171	171
query27	2037	313	310	310
query28	4349	2506	2505	2505
query29	738	505	435	435
query30	246	163	165	163
query31	989	794	840	794
query32	67	55	57	55
query33	438	291	289	289
query34	922	522	542	522
query35	853	764	745	745
query36	1099	979	985	979
query37	122	73	74	73
query38	3952	4026	3984	3984
query39	1503	1509	1472	1472
query40	143	94	83	83
query41	49	48	46	46
query42	109	102	101	101
query43	560	521	512	512
query44	1206	857	839	839
query45	188	181	169	169
query46	1155	742	734	734
query47	2003	1924	1923	1923
query48	494	382	396	382
query49	751	403	410	403
query50	849	448	442	442
query51	7415	7285	7364	7285
query52	99	89	91	89
query53	265	191	183	183
query54	555	454	443	443
query55	71	78	76	76
query56	275	249	246	246
query57	1233	1121	1104	1104
query58	218	210	223	210
query59	3239	2932	2965	2932
query60	281	267	256	256
query61	112	106	104	104
query62	756	672	660	660
query63	221	202	202	202
query64	1438	687	682	682
query65	3280	3197	3211	3197
query66	643	308	311	308
query67	15812	15706	15594	15594
query68	3995	589	585	585
query69	419	274	269	269
query70	1200	1137	1101	1101
query71	336	267	258	258
query72	6475	4083	4074	4074
query73	764	350	351	350
query74	10170	8966	8949	8949
query75	3393	2609	2706	2609
query76	1872	1051	1056	1051
query77	521	297	307	297
query78	10549	9587	9691	9587
query79	2144	610	608	608
query80	1345	458	451	451
query81	538	250	243	243
query82	1262	117	114	114
query83	235	146	148	146
query84	283	79	80	79
query85	991	309	296	296
query86	428	303	300	300
query87	4478	4376	4267	4267
query88	3740	2393	2339	2339
query89	419	293	298	293
query90	1805	199	188	188
query91	184	151	152	151
query92	69	53	52	52
query93	2971	550	541	541
query94	757	319	293	293
query95	366	258	255	255
query96	640	281	284	281
query97	3318	3180	3241	3180
query98	222	207	191	191
query99	1597	1314	1268	1268
Total cold run time: 321111 ms
Total hot run time: 198447 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.42 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 64a498a47ab18ccdac63718f58410658b30e785c, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.03	0.03
query3	0.24	0.07	0.06
query4	1.62	0.11	0.11
query5	0.51	0.50	0.49
query6	1.13	0.71	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.04
query9	0.56	0.50	0.50
query10	0.54	0.56	0.57
query11	0.14	0.11	0.11
query12	0.17	0.12	0.12
query13	0.61	0.59	0.60
query14	2.91	2.98	2.99
query15	0.92	0.83	0.83
query16	0.38	0.38	0.36
query17	1.01	1.02	1.05
query18	0.26	0.23	0.21
query19	1.97	1.77	2.06
query20	0.01	0.02	0.01
query21	15.37	0.61	0.55
query22	2.65	2.48	1.61
query23	16.94	0.98	0.81
query24	2.58	1.49	0.69
query25	0.29	0.20	0.11
query26	0.32	0.12	0.14
query27	0.04	0.05	0.04
query28	10.89	1.11	1.07
query29	12.54	3.27	3.21
query30	0.24	0.06	0.06
query31	2.85	0.38	0.37
query32	3.29	0.46	0.46
query33	3.04	3.04	3.02
query34	16.76	4.48	4.49
query35	4.53	4.51	4.50
query36	0.68	0.49	0.49
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.65 s
Total hot run time: 32.42 s

@dataroaring dataroaring merged commit 7e9e56f into branch-3.0 Jan 17, 2025
11 of 12 checks passed
@github-actions github-actions bot deleted the auto-pick-46318-branch-3.0 branch January 17, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants