Skip to content

branch-3.0: [Fix](Variant) variant should not implicit be short key column when create mv #46444#46538

Merged
eldenmoon merged 1 commit intobranch-3.0from
auto-pick-46444-branch-3.0
Jan 8, 2025
Merged

branch-3.0: [Fix](Variant) variant should not implicit be short key column when create mv #46444#46538
eldenmoon merged 1 commit intobranch-3.0from
auto-pick-46444-branch-3.0

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jan 7, 2025

Cherry-picked from #46444

…reate mv (#46444)

When creating mv, the variant column should not be part of short key
since it's not supported sorting
@Thearas
Copy link
Contributor

Thearas commented Jan 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jan 7, 2025
@dataroaring dataroaring reopened this Jan 7, 2025
@Thearas
Copy link
Contributor

Thearas commented Jan 7, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40952 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3c9824b4b091f5b21a5107145c9fe9aabab14e7c, data reload: false

------ Round 1 ----------------------------------
q1	17572	7517	7297	7297
q2	2053	186	188	186
q3	10551	1117	1200	1117
q4	10552	764	691	691
q5	7787	2904	2791	2791
q6	237	150	148	148
q7	966	629	616	616
q8	9367	1952	2039	1952
q9	6600	6384	6372	6372
q10	7042	2283	2329	2283
q11	463	268	266	266
q12	411	217	214	214
q13	17799	2978	3017	2978
q14	238	209	207	207
q15	574	524	513	513
q16	699	605	619	605
q17	994	571	568	568
q18	7265	6706	6649	6649
q19	1403	1066	1083	1066
q20	484	202	208	202
q21	4297	3344	3256	3256
q22	1092	975	1000	975
Total cold run time: 108446 ms
Total hot run time: 40952 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7327	7214	7235	7214
q2	322	229	232	229
q3	2935	2982	3039	2982
q4	2086	1815	1787	1787
q5	5712	5792	5744	5744
q6	223	139	147	139
q7	2291	1821	1798	1798
q8	3377	3603	3521	3521
q9	8802	8881	8882	8881
q10	3573	3531	3547	3531
q11	588	520	503	503
q12	852	604	587	587
q13	9910	3195	3157	3157
q14	305	275	271	271
q15	569	524	522	522
q16	738	699	680	680
q17	1850	1635	1636	1635
q18	8318	7816	7483	7483
q19	1708	1694	1585	1585
q20	2133	1914	1851	1851
q21	5518	5309	5323	5309
q22	1126	1005	1017	1005
Total cold run time: 70263 ms
Total hot run time: 60414 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197842 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3c9824b4b091f5b21a5107145c9fe9aabab14e7c, data reload: false

query1	1314	929	924	924
query2	6227	2188	2164	2164
query3	10880	4331	4218	4218
query4	66422	28618	23356	23356
query5	5008	466	447	447
query6	407	176	168	168
query7	5546	316	310	310
query8	313	228	230	228
query9	8402	2705	2686	2686
query10	454	270	256	256
query11	17176	15147	15750	15147
query12	155	107	102	102
query13	1444	464	442	442
query14	11040	8402	7821	7821
query15	210	181	178	178
query16	6919	472	488	472
query17	1089	588	620	588
query18	1775	329	326	326
query19	209	163	165	163
query20	122	111	108	108
query21	203	107	104	104
query22	4748	4331	4394	4331
query23	35536	34131	34326	34131
query24	6101	2933	2962	2933
query25	550	430	428	428
query26	660	177	170	170
query27	1809	368	362	362
query28	4094	2503	2480	2480
query29	696	464	469	464
query30	242	161	161	161
query31	990	824	848	824
query32	65	56	53	53
query33	398	300	300	300
query34	940	505	521	505
query35	867	739	748	739
query36	1078	981	985	981
query37	126	77	73	73
query38	4266	4053	4070	4053
query39	1528	1491	1480	1480
query40	214	100	104	100
query41	50	47	49	47
query42	116	105	100	100
query43	528	504	506	504
query44	1199	832	840	832
query45	186	168	168	168
query46	1148	740	757	740
query47	1984	1899	1919	1899
query48	484	396	393	393
query49	707	377	401	377
query50	888	427	438	427
query51	7204	7081	7102	7081
query52	104	87	89	87
query53	265	180	185	180
query54	564	451	441	441
query55	77	84	74	74
query56	261	249	254	249
query57	1213	1090	1119	1090
query58	213	207	210	207
query59	3446	3020	2924	2924
query60	277	252	251	251
query61	107	110	107	107
query62	785	661	665	661
query63	221	203	196	196
query64	1399	669	639	639
query65	3264	3197	3152	3152
query66	711	302	299	299
query67	15864	15899	15415	15415
query68	4262	576	576	576
query69	426	265	273	265
query70	1189	1141	1134	1134
query71	358	263	262	262
query72	6138	4060	3980	3980
query73	760	349	353	349
query74	10192	8939	8954	8939
query75	3367	2649	2663	2649
query76	1790	1129	1062	1062
query77	474	279	270	270
query78	10471	9710	9543	9543
query79	1541	601	592	592
query80	868	428	424	424
query81	521	245	233	233
query82	1296	114	114	114
query83	163	144	142	142
query84	283	82	76	76
query85	858	290	295	290
query86	352	304	304	304
query87	4439	4243	4340	4243
query88	3715	2411	2361	2361
query89	430	295	292	292
query90	1995	193	191	191
query91	187	147	151	147
query92	66	49	51	49
query93	1876	544	547	544
query94	758	293	303	293
query95	351	258	258	258
query96	609	277	280	277
query97	3294	3213	3173	3173
query98	217	203	205	203
query99	1684	1291	1343	1291
Total cold run time: 318418 ms
Total hot run time: 197842 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.12 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3c9824b4b091f5b21a5107145c9fe9aabab14e7c, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.23	0.06	0.06
query4	1.62	0.10	0.11
query5	0.52	0.52	0.51
query6	1.13	0.73	0.74
query7	0.02	0.02	0.01
query8	0.04	0.03	0.05
query9	0.54	0.48	0.48
query10	0.54	0.53	0.56
query11	0.14	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.59	0.59
query14	2.95	3.03	3.06
query15	0.90	0.84	0.81
query16	0.38	0.41	0.39
query17	1.08	1.05	0.97
query18	0.22	0.21	0.22
query19	1.95	1.88	1.99
query20	0.01	0.01	0.01
query21	15.38	0.62	0.60
query22	2.42	2.81	1.84
query23	17.01	0.84	0.96
query24	3.45	1.06	2.08
query25	0.16	0.12	0.07
query26	0.70	0.14	0.14
query27	0.05	0.04	0.05
query28	9.72	1.11	1.08
query29	12.60	3.27	3.20
query30	0.24	0.05	0.06
query31	2.88	0.39	0.38
query32	3.25	0.46	0.48
query33	3.00	3.00	3.03
query34	16.76	4.47	4.49
query35	4.49	4.52	4.48
query36	0.69	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.41 s
Total hot run time: 33.12 s

@eldenmoon eldenmoon merged commit b4f1d7d into branch-3.0 Jan 8, 2025
@github-actions github-actions bot deleted the auto-pick-46444-branch-3.0 branch January 8, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants