Skip to content

[chore](regression) Normalize external case labels#46622

Merged
hello-stephen merged 1 commit intoapache:masterfrom
zgxme:external-case-tag-0108
Jan 9, 2025
Merged

[chore](regression) Normalize external case labels#46622
hello-stephen merged 1 commit intoapache:masterfrom
zgxme:external-case-tag-0108

Conversation

@zgxme
Copy link
Copy Markdown
Contributor

@zgxme zgxme commented Jan 8, 2025

What problem does this PR solve?

Ensure that all external cases are labeled with the external tag.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented Jan 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zgxme
Copy link
Copy Markdown
Contributor Author

zgxme commented Jan 8, 2025

run buildall

@zgxme zgxme force-pushed the external-case-tag-0108 branch from 6cf56a6 to a39dc36 Compare January 8, 2025 09:31
@zgxme
Copy link
Copy Markdown
Contributor Author

zgxme commented Jan 8, 2025

run buildall

hello-stephen
hello-stephen approved these changes Jan 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@hello-stephen hello-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 9, 2025

PR approved by anyone and no changes requested.

MoanasDaddyXu
MoanasDaddyXu approved these changes Jan 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MoanasDaddyXu MoanasDaddyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen hello-stephen merged commit 43bf9e1 into apache:master Jan 9, 2025
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@zgxme
[chore](regression) Normalize external case labels (#46622)
52778dc 
### What problem does this PR solve?
Ensure that all external cases are labeled with the external tag.
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
@zgxme
[chore](regression) Normalize external case labels (#46622)
8f42802 
### What problem does this PR solve?
Ensure that all external cases are labeled with the external tag.
This was referenced Jan 9, 2025
Merged
Merged
yiguolei pushed a commit that referenced this pull request Jan 10, 2025
@github-actions @zgxme
branch-2.1: [chore](regression) Normalize external case labels #46622 (…
eeabf7c 
…#46705)

Cherry-picked from #46622

Co-authored-by: zgxme <zhenggaoxiong@selectdb.com>
morningman pushed a commit that referenced this pull request Jan 13, 2025
@github-actions @zgxme
branch-3.0: [chore](regression) Normalize external case labels #46622 (…
52ea3af 
…#46704)

Cherry-picked from #46622

Co-authored-by: zgxme <zhenggaoxiong@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hello-stephen hello-stephen hello-stephen approved these changes

+1 more reviewer

@MoanasDaddyXu MoanasDaddyXu MoanasDaddyXu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zgxme @hello-stephen @MoanasDaddyXu @morningman @yiguolei