-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](partial update) Forbid partial update when table is in SCHEMA_CHANGE/ROLLUP in FE
#46985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32861 ms |
TPC-DS: Total hot run time: 194776 ms |
ClickBench: Total hot run time: 32.35 s |
|
run buildall |
TPC-H: Total hot run time: 33419 ms |
TPC-DS: Total hot run time: 195184 ms |
ClickBench: Total hot run time: 31.33 s |
e97a2c6 to
7c1c73d
Compare
|
run buildall |
TPC-H: Total hot run time: 33252 ms |
TPC-DS: Total hot run time: 189296 ms |
ClickBench: Total hot run time: 31.29 s |
|
run p0 |
|
run cloud_p0 |
|
run p0 |
… in `SCHEMA_CHANGE`/`ROLLUP` in FE (apache#46866) Related PR: apache#22133 Problem Summary: apache#22133 forbid doing partial update during schema change on BE, but this may failed to work when some of replicas finished alter process on BE and some of them don't. This PR forbids partial update during schema change on FE to avoid this situation.
7c1c73d to
6b99c85
Compare
|
run buildall |
TPC-H: Total hot run time: 32775 ms |
TPC-DS: Total hot run time: 195187 ms |
ClickBench: Total hot run time: 31.01 s |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
hust-hhb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…CHANGE/ROLLUP` in FE (apache#46985) Related PR: apache#22133 Problem Summary: apache#22133 forbid doing partial update during schema change on BE, but this may failed to work when some of replicas finished alter process on BE and some of them don't. This PR forbids partial update during schema change on FE to avoid this situation.
### What problem does this PR solve? #46985 forbid partial update on FE, so change the corresponding error msg in case.
### What problem does this PR solve? #46985 forbid partial update on FE, so change the corresponding error msg in case.
…CHANGE/ROLLUP` in FE (apache#46985) Related PR: apache#22133 Problem Summary: apache#22133 forbid doing partial update during schema change on BE, but this may failed to work when some of replicas finished alter process on BE and some of them don't. This PR forbids partial update during schema change on FE to avoid this situation.
### What problem does this PR solve? apache#46985 forbid partial update on FE, so change the corresponding error msg in case.
### What problem does this PR solve? apache#46985 forbid partial update on FE, so change the corresponding error msg in case.
Related PR: #22133
Problem Summary:
#22133 forbid doing partial update during schema change on BE, but this may failed to work when some of replicas finished alter process on BE and some of them don't. This PR forbids partial update during schema change on FE to avoid this situation.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)