Skip to content

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jan 14, 2025

Related PR: #22133

Problem Summary:

#22133 forbid doing partial update during schema change on BE, but this may failed to work when some of replicas finished alter process on BE and some of them don't. This PR forbids partial update during schema change on FE to avoid this situation.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 14, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32861 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 345783c79d3f2f3fc34f1778454cb2019733df87, data reload: false

------ Round 1 ----------------------------------
q1	17634	6788	6068	6068
q2	2065	299	166	166
q3	10430	1241	734	734
q4	10246	882	444	444
q5	8135	2181	1962	1962
q6	207	180	145	145
q7	883	754	604	604
q8	9244	1364	1134	1134
q9	5208	4944	4864	4864
q10	6759	2289	1862	1862
q11	492	275	266	266
q12	361	394	235	235
q13	18033	3843	3252	3252
q14	236	240	223	223
q15	588	542	501	501
q16	643	609	594	594
q17	571	871	336	336
q18	6909	6461	6432	6432
q19	2911	941	533	533
q20	316	312	187	187
q21	2895	2148	2015	2015
q22	372	332	304	304
Total cold run time: 105138 ms
Total hot run time: 32861 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6309	6209	6203	6203
q2	237	331	257	257
q3	2258	2663	2330	2330
q4	1433	1810	1374	1374
q5	4388	4794	4925	4794
q6	188	182	141	141
q7	2079	1987	1839	1839
q8	2638	2794	2709	2709
q9	7246	7268	7260	7260
q10	3069	3211	2812	2812
q11	601	529	501	501
q12	681	795	611	611
q13	3565	3976	3303	3303
q14	281	296	272	272
q15	558	533	558	533
q16	659	688	683	683
q17	1192	1780	1284	1284
q18	7782	7628	7502	7502
q19	803	1147	1109	1109
q20	2084	2041	1913	1913
q21	5515	5167	5020	5020
q22	599	605	597	597
Total cold run time: 54165 ms
Total hot run time: 53047 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 194776 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 345783c79d3f2f3fc34f1778454cb2019733df87, data reload: false

query1	1316	968	930	930
query2	6394	2055	1986	1986
query3	11016	4501	4470	4470
query4	61514	29107	23339	23339
query5	5507	631	482	482
query6	429	218	184	184
query7	5583	505	306	306
query8	330	242	238	238
query9	8232	2774	2764	2764
query10	431	320	247	247
query11	17263	15231	15561	15231
query12	154	109	106	106
query13	1413	542	414	414
query14	10585	6680	7514	6680
query15	208	202	194	194
query16	7326	629	484	484
query17	1182	730	575	575
query18	1899	410	293	293
query19	203	192	160	160
query20	121	109	107	107
query21	213	123	107	107
query22	4451	4841	4356	4356
query23	33975	33332	34484	33332
query24	5646	2380	2325	2325
query25	497	513	435	435
query26	656	261	166	166
query27	1768	490	343	343
query28	4036	2508	2490	2490
query29	617	555	449	449
query30	215	185	160	160
query31	907	896	826	826
query32	67	61	57	57
query33	414	364	303	303
query34	731	848	518	518
query35	807	826	764	764
query36	997	1047	937	937
query37	123	95	81	81
query38	4275	4337	4303	4303
query39	1470	1449	1445	1445
query40	207	117	105	105
query41	51	54	51	51
query42	121	107	100	100
query43	512	536	499	499
query44	1316	853	856	853
query45	199	176	171	171
query46	892	1074	681	681
query47	1933	1942	1850	1850
query48	395	415	332	332
query49	712	493	411	411
query50	670	684	412	412
query51	7000	7095	7053	7053
query52	104	103	99	99
query53	235	253	189	189
query54	487	518	438	438
query55	92	88	84	84
query56	264	262	257	257
query57	1191	1221	1127	1127
query58	243	264	249	249
query59	3130	3103	2907	2907
query60	274	265	268	265
query61	113	119	123	119
query62	786	754	700	700
query63	229	193	192	192
query64	1229	1045	657	657
query65	3236	3162	3125	3125
query66	777	411	327	327
query67	15967	15778	15489	15489
query68	5061	848	537	537
query69	496	305	265	265
query70	1201	1124	1127	1124
query71	414	302	296	296
query72	6350	3858	3789	3789
query73	824	778	371	371
query74	9203	9219	8822	8822
query75	3208	3170	2680	2680
query76	3785	1181	774	774
query77	471	370	290	290
query78	10062	10011	9331	9331
query79	3118	808	599	599
query80	769	533	467	467
query81	513	266	239	239
query82	479	154	123	123
query83	171	188	154	154
query84	295	97	77	77
query85	774	419	305	305
query86	422	304	280	280
query87	4457	4568	4350	4350
query88	4702	2190	2197	2190
query89	400	329	293	293
query90	1593	189	196	189
query91	137	135	115	115
query92	68	58	54	54
query93	2922	893	547	547
query94	828	415	293	293
query95	331	272	323	272
query96	488	623	280	280
query97	2867	2930	2776	2776
query98	225	194	201	194
query99	1418	1471	1371	1371
Total cold run time: 313388 ms
Total hot run time: 194776 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 345783c79d3f2f3fc34f1778454cb2019733df87, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.03
query3	0.24	0.07	0.07
query4	1.60	0.10	0.11
query5	0.42	0.42	0.42
query6	1.17	0.65	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.58	0.52	0.51
query10	0.55	0.56	0.54
query11	0.15	0.10	0.11
query12	0.14	0.11	0.11
query13	0.60	0.59	0.60
query14	2.71	2.82	2.80
query15	0.90	0.84	0.82
query16	0.40	0.38	0.39
query17	0.98	1.07	1.07
query18	0.23	0.21	0.21
query19	1.92	1.89	1.95
query20	0.02	0.01	0.02
query21	15.36	0.95	0.59
query22	0.74	0.75	0.75
query23	15.29	1.49	0.62
query24	2.61	1.72	1.97
query25	0.19	0.12	0.21
query26	0.22	0.16	0.14
query27	0.06	0.06	0.04
query28	13.87	1.46	1.04
query29	12.61	3.96	3.29
query30	0.25	0.09	0.06
query31	2.80	0.60	0.39
query32	3.23	0.55	0.46
query33	3.01	2.97	3.03
query34	16.85	5.12	4.53
query35	4.50	4.46	4.51
query36	0.65	0.51	0.47
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.14
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.51 s
Total hot run time: 32.35 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 15, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33419 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e97a2c68848303979a45ec7f18a5ff08ea6dbe76, data reload: false

------ Round 1 ----------------------------------
q1	17613	6275	6198	6198
q2	2062	331	167	167
q3	10405	1282	749	749
q4	10288	899	455	455
q5	8668	2285	2026	2026
q6	229	184	155	155
q7	950	767	608	608
q8	9218	1508	1304	1304
q9	5351	5097	4982	4982
q10	6797	2351	1864	1864
q11	483	297	250	250
q12	357	389	228	228
q13	17779	3778	3143	3143
q14	240	227	220	220
q15	593	536	511	511
q16	637	618	588	588
q17	603	902	327	327
q18	6944	6554	6470	6470
q19	2818	1044	565	565
q20	313	327	187	187
q21	2983	2294	2113	2113
q22	380	354	309	309
Total cold run time: 105711 ms
Total hot run time: 33419 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6583	6428	6439	6428
q2	254	340	236	236
q3	2278	2669	2307	2307
q4	1469	1877	1375	1375
q5	4357	4941	4981	4941
q6	204	189	148	148
q7	2154	1989	1868	1868
q8	2706	2887	2793	2793
q9	7365	7288	7349	7288
q10	3040	3254	2851	2851
q11	605	510	506	506
q12	681	787	595	595
q13	3566	4034	3304	3304
q14	288	318	293	293
q15	586	531	531	531
q16	695	700	686	686
q17	1306	1828	1285	1285
q18	7771	7502	7445	7445
q19	901	1295	1217	1217
q20	2041	2051	1914	1914
q21	5770	5281	5087	5087
q22	628	614	570	570
Total cold run time: 55248 ms
Total hot run time: 53668 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195184 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e97a2c68848303979a45ec7f18a5ff08ea6dbe76, data reload: false

query1	1319	949	919	919
query2	6320	2169	2102	2102
query3	11099	4521	4798	4521
query4	32864	23604	23346	23346
query5	3534	606	453	453
query6	271	194	175	175
query7	3993	504	307	307
query8	325	243	252	243
query9	9526	2657	2672	2657
query10	462	314	254	254
query11	18002	15179	15030	15030
query12	160	118	107	107
query13	1552	518	373	373
query14	9797	6606	7507	6606
query15	245	215	194	194
query16	8016	669	463	463
query17	1608	751	594	594
query18	2107	410	325	325
query19	203	184	161	161
query20	126	116	121	116
query21	203	123	100	100
query22	4674	4726	4417	4417
query23	34565	33453	33656	33453
query24	6855	2441	2265	2265
query25	491	461	384	384
query26	1151	286	162	162
query27	2065	480	340	340
query28	5384	2476	2481	2476
query29	742	608	457	457
query30	217	200	159	159
query31	991	874	844	844
query32	82	61	63	61
query33	506	390	315	315
query34	799	885	522	522
query35	820	849	753	753
query36	1013	1044	953	953
query37	120	99	73	73
query38	4304	4291	4283	4283
query39	1493	1475	1440	1440
query40	210	117	102	102
query41	53	50	74	50
query42	125	113	104	104
query43	538	565	508	508
query44	1386	853	857	853
query45	188	181	168	168
query46	898	1074	663	663
query47	1912	1913	1840	1840
query48	388	410	329	329
query49	783	505	389	389
query50	679	671	400	400
query51	7084	7073	6919	6919
query52	143	109	95	95
query53	234	255	186	186
query54	511	508	444	444
query55	85	81	78	78
query56	264	273	255	255
query57	1234	1243	1126	1126
query58	248	238	253	238
query59	3152	3251	3221	3221
query60	289	277	273	273
query61	121	126	120	120
query62	867	793	689	689
query63	231	185	199	185
query64	4183	1050	734	734
query65	3262	3184	3188	3184
query66	1010	426	314	314
query67	16051	15798	15499	15499
query68	5402	831	527	527
query69	508	294	261	261
query70	1215	1193	1141	1141
query71	399	312	258	258
query72	5968	3830	3843	3830
query73	665	769	372	372
query74	10257	9205	9070	9070
query75	3190	3097	2678	2678
query76	3105	1165	802	802
query77	495	426	288	288
query78	10289	10471	9461	9461
query79	3047	809	591	591
query80	745	523	444	444
query81	503	282	233	233
query82	541	144	126	126
query83	167	168	158	158
query84	239	86	69	69
query85	812	348	304	304
query86	411	321	303	303
query87	4348	4406	4401	4401
query88	5083	2193	2198	2193
query89	395	323	292	292
query90	1790	187	185	185
query91	139	138	108	108
query92	70	59	53	53
query93	2148	839	533	533
query94	720	389	286	286
query95	331	261	253	253
query96	503	624	283	283
query97	2817	2898	2717	2717
query98	228	201	194	194
query99	1376	1487	1401	1401
Total cold run time: 292039 ms
Total hot run time: 195184 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.33 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e97a2c68848303979a45ec7f18a5ff08ea6dbe76, data reload: false

query1	0.03	0.04	0.03
query2	0.08	0.03	0.04
query3	0.24	0.07	0.07
query4	1.62	0.10	0.11
query5	0.42	0.42	0.42
query6	1.15	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.60	0.51	0.50
query10	0.56	0.57	0.54
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.61	0.59
query14	2.76	2.73	2.74
query15	0.90	0.83	0.82
query16	0.39	0.38	0.37
query17	0.99	1.02	1.07
query18	0.24	0.20	0.20
query19	1.89	1.90	1.96
query20	0.01	0.01	0.01
query21	15.35	0.92	0.56
query22	0.76	0.75	0.70
query23	15.30	1.45	0.54
query24	3.38	0.95	1.42
query25	0.16	0.22	0.16
query26	0.35	0.14	0.14
query27	0.05	0.06	0.04
query28	13.75	1.49	1.04
query29	12.61	3.87	3.22
query30	0.25	0.09	0.06
query31	2.83	0.62	0.39
query32	3.23	0.54	0.45
query33	2.98	3.00	3.04
query34	16.66	5.17	4.53
query35	4.67	4.54	4.55
query36	0.63	0.48	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.28 s
Total hot run time: 31.33 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 15, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33252 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7c1c73d3304f26637391a33bcc6612db8cedfa9e, data reload: false

------ Round 1 ----------------------------------
q1	17602	6255	6126	6126
q2	2047	311	172	172
q3	10407	1288	709	709
q4	10221	985	531	531
q5	7537	2381	2208	2208
q6	208	184	150	150
q7	896	751	598	598
q8	9250	1368	1174	1174
q9	5321	4915	4990	4915
q10	6824	2365	1958	1958
q11	500	275	259	259
q12	336	355	224	224
q13	17828	3663	3098	3098
q14	234	236	209	209
q15	575	549	517	517
q16	639	628	591	591
q17	553	867	324	324
q18	7059	6415	6470	6415
q19	1212	986	549	549
q20	305	329	207	207
q21	2833	2193	2000	2000
q22	380	337	318	318
Total cold run time: 102767 ms
Total hot run time: 33252 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6264	6272	6286	6272
q2	243	341	252	252
q3	2271	2645	2327	2327
q4	1477	1791	1338	1338
q5	4346	4770	4903	4770
q6	213	190	143	143
q7	2130	1991	1865	1865
q8	2647	2800	2719	2719
q9	7272	7172	7254	7172
q10	3054	3339	2820	2820
q11	589	538	524	524
q12	690	774	643	643
q13	3439	3877	3271	3271
q14	292	302	293	293
q15	564	541	520	520
q16	650	733	654	654
q17	1206	1760	1252	1252
q18	7868	7561	7337	7337
q19	789	1130	1076	1076
q20	1954	2051	1895	1895
q21	5743	5447	5037	5037
q22	625	653	580	580
Total cold run time: 54326 ms
Total hot run time: 52760 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 189296 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7c1c73d3304f26637391a33bcc6612db8cedfa9e, data reload: false

query1	992	411	389	389
query2	6507	2127	2089	2089
query3	6790	213	212	212
query4	34119	23454	23066	23066
query5	4301	612	470	470
query6	284	224	196	196
query7	4603	487	318	318
query8	305	240	229	229
query9	9650	2759	2770	2759
query10	471	308	246	246
query11	18249	15234	15551	15234
query12	165	108	109	108
query13	1667	524	411	411
query14	11132	7038	7506	7038
query15	261	202	231	202
query16	8539	590	457	457
query17	1668	720	559	559
query18	2130	394	294	294
query19	225	168	153	153
query20	118	112	108	108
query21	210	120	103	103
query22	4418	4489	4537	4489
query23	33988	33426	33141	33141
query24	6292	2273	2271	2271
query25	497	445	382	382
query26	774	270	152	152
query27	2024	473	333	333
query28	5395	2469	2441	2441
query29	680	531	434	434
query30	229	185	154	154
query31	966	892	820	820
query32	89	62	84	62
query33	509	349	303	303
query34	751	866	522	522
query35	800	826	745	745
query36	1040	1006	918	918
query37	113	105	87	87
query38	4144	4294	4141	4141
query39	1472	1420	1395	1395
query40	203	118	104	104
query41	52	50	52	50
query42	118	98	99	98
query43	507	531	497	497
query44	1305	809	791	791
query45	180	177	170	170
query46	840	1046	642	642
query47	1822	1836	1753	1753
query48	369	397	311	311
query49	745	490	396	396
query50	629	665	376	376
query51	7010	6989	6862	6862
query52	100	100	93	93
query53	224	249	183	183
query54	475	486	405	405
query55	81	80	78	78
query56	256	279	243	243
query57	1186	1159	1087	1087
query58	248	232	250	232
query59	2967	3040	2886	2886
query60	278	270	259	259
query61	117	118	113	113
query62	832	785	721	721
query63	224	199	200	199
query64	3481	1020	646	646
query65	3257	3151	3149	3149
query66	865	416	312	312
query67	16122	15774	15580	15580
query68	6521	812	537	537
query69	482	293	259	259
query70	1162	1159	1148	1148
query71	376	285	277	277
query72	5951	3875	3874	3874
query73	648	743	360	360
query74	10155	8867	9067	8867
query75	3192	3141	2653	2653
query76	3178	1155	735	735
query77	467	364	283	283
query78	9982	10091	9498	9498
query79	2738	782	603	603
query80	683	521	436	436
query81	514	279	242	242
query82	417	146	128	128
query83	173	166	148	148
query84	240	88	75	75
query85	783	363	298	298
query86	405	332	294	294
query87	4423	4443	4328	4328
query88	4889	2229	2181	2181
query89	397	333	306	306
query90	1891	188	194	188
query91	144	138	114	114
query92	68	59	55	55
query93	1958	876	550	550
query94	676	414	267	267
query95	342	264	254	254
query96	494	603	284	284
query97	2775	2918	2768	2768
query98	233	203	204	203
query99	1423	1531	1416	1416
Total cold run time: 288840 ms
Total hot run time: 189296 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.29 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7c1c73d3304f26637391a33bcc6612db8cedfa9e, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.23	0.07	0.06
query4	1.62	0.11	0.11
query5	0.42	0.43	0.41
query6	1.13	0.65	0.66
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.50	0.49
query10	0.56	0.58	0.55
query11	0.14	0.09	0.10
query12	0.13	0.11	0.11
query13	0.61	0.61	0.59
query14	2.83	2.72	2.82
query15	0.91	0.83	0.84
query16	0.37	0.38	0.39
query17	0.96	1.05	1.04
query18	0.23	0.21	0.21
query19	1.96	2.05	1.84
query20	0.01	0.01	0.02
query21	15.36	1.02	0.59
query22	0.75	0.82	0.72
query23	15.21	1.42	0.54
query24	2.86	0.91	1.73
query25	0.15	0.22	0.16
query26	0.20	0.14	0.13
query27	0.05	0.04	0.04
query28	14.39	1.47	1.04
query29	12.55	3.95	3.25
query30	0.24	0.08	0.06
query31	2.85	0.59	0.39
query32	3.22	0.55	0.47
query33	3.00	2.98	3.07
query34	16.51	5.14	4.55
query35	4.51	4.52	4.50
query36	0.67	0.48	0.49
query37	0.09	0.06	0.06
query38	0.04	0.05	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.86 s
Total hot run time: 31.29 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 15, 2025

run p0

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 15, 2025

run cloud_p0

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 16, 2025

run p0

… in `SCHEMA_CHANGE`/`ROLLUP` in FE (apache#46866)

Related PR: apache#22133

Problem Summary:

apache#22133 forbid doing partial update
during schema change on BE, but this may failed to work when some of
replicas finished alter process on BE and some of them don't. This PR
forbids partial update during schema change on FE to avoid this
situation.
@bobhan1
Copy link
Contributor Author

bobhan1 commented Jan 16, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32775 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6b99c85a3225b632bcc0acb8a6fbcbb3cc0098eb, data reload: false

------ Round 1 ----------------------------------
q1	17578	5476	5400	5400
q2	2055	323	173	173
q3	10377	1235	753	753
q4	10211	989	545	545
q5	7541	2413	2161	2161
q6	190	171	132	132
q7	904	775	611	611
q8	9251	1372	1193	1193
q9	5220	4952	4971	4952
q10	6868	2343	1920	1920
q11	495	278	260	260
q12	357	372	229	229
q13	17767	3728	3124	3124
q14	242	241	214	214
q15	517	481	470	470
q16	629	614	594	594
q17	597	871	331	331
q18	6991	6642	6520	6520
q19	2010	955	549	549
q20	306	309	183	183
q21	2925	2291	2148	2148
q22	376	343	313	313
Total cold run time: 103407 ms
Total hot run time: 32775 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5586	5472	5567	5472
q2	235	327	232	232
q3	2328	2723	2394	2394
q4	1466	1936	1448	1448
q5	4621	4770	4782	4770
q6	167	159	127	127
q7	2104	1954	1809	1809
q8	2611	2858	2725	2725
q9	7456	7217	7437	7217
q10	3024	3346	2762	2762
q11	582	519	510	510
q12	697	870	625	625
q13	3564	4020	3279	3279
q14	294	309	276	276
q15	525	474	492	474
q16	636	688	629	629
q17	1273	1759	1264	1264
q18	7687	7562	7414	7414
q19	855	1138	1083	1083
q20	1989	2043	1894	1894
q21	5887	5188	5239	5188
q22	601	663	636	636
Total cold run time: 54188 ms
Total hot run time: 52228 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195187 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6b99c85a3225b632bcc0acb8a6fbcbb3cc0098eb, data reload: false

query1	1316	924	919	919
query2	6207	1999	2022	1999
query3	11025	4574	4624	4574
query4	32566	23692	23364	23364
query5	4923	609	469	469
query6	295	207	206	206
query7	4000	502	315	315
query8	307	257	234	234
query9	9204	2650	2648	2648
query10	494	310	247	247
query11	17812	15224	14954	14954
query12	163	109	101	101
query13	1558	512	403	403
query14	10677	6905	7000	6905
query15	241	211	188	188
query16	7768	651	490	490
query17	1526	746	586	586
query18	2110	421	320	320
query19	219	193	170	170
query20	134	120	118	118
query21	205	129	109	109
query22	4547	4669	4261	4261
query23	34401	33480	33685	33480
query24	6736	2356	2440	2356
query25	490	507	423	423
query26	860	275	162	162
query27	2036	478	334	334
query28	5751	2515	2516	2515
query29	564	578	432	432
query30	212	188	158	158
query31	976	872	812	812
query32	67	62	58	58
query33	479	362	300	300
query34	767	921	510	510
query35	837	847	773	773
query36	1011	1062	983	983
query37	119	102	82	82
query38	4321	4385	4270	4270
query39	1512	1435	1433	1433
query40	213	118	105	105
query41	50	53	51	51
query42	129	112	117	112
query43	519	537	487	487
query44	1458	831	833	831
query45	187	175	172	172
query46	912	1075	669	669
query47	1904	1931	1866	1866
query48	395	416	319	319
query49	731	486	400	400
query50	658	680	412	412
query51	7014	7063	7019	7019
query52	106	103	95	95
query53	235	263	192	192
query54	499	525	434	434
query55	91	81	82	81
query56	271	250	239	239
query57	1226	1191	1128	1128
query58	253	264	240	240
query59	3015	3226	3102	3102
query60	298	287	257	257
query61	120	125	137	125
query62	809	741	678	678
query63	232	190	196	190
query64	3105	1040	667	667
query65	3315	3194	3189	3189
query66	960	406	303	303
query67	15866	15824	15669	15669
query68	5726	833	524	524
query69	481	296	256	256
query70	1214	1147	1151	1147
query71	410	307	249	249
query72	5929	3858	3799	3799
query73	660	752	360	360
query74	10587	9187	8843	8843
query75	3227	3191	2688	2688
query76	3088	1190	802	802
query77	462	383	267	267
query78	10120	10119	9385	9385
query79	3066	811	592	592
query80	665	518	444	444
query81	507	279	233	233
query82	441	155	125	125
query83	187	167	154	154
query84	229	90	111	90
query85	780	357	303	303
query86	384	315	313	313
query87	4500	4497	4474	4474
query88	4826	2212	2182	2182
query89	399	335	291	291
query90	1872	190	194	190
query91	138	132	107	107
query92	65	53	54	53
query93	2403	871	521	521
query94	698	422	302	302
query95	338	264	264	264
query96	491	626	281	281
query97	2765	2836	2783	2783
query98	226	202	194	194
query99	1317	1397	1278	1278
Total cold run time: 291208 ms
Total hot run time: 195187 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.01 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6b99c85a3225b632bcc0acb8a6fbcbb3cc0098eb, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.40	0.43	0.39
query6	1.15	0.65	0.65
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.60	0.50	0.50
query10	0.56	0.57	0.54
query11	0.15	0.10	0.09
query12	0.14	0.12	0.11
query13	0.61	0.60	0.60
query14	2.75	2.81	2.82
query15	0.90	0.82	0.82
query16	0.39	0.39	0.39
query17	1.06	1.00	1.05
query18	0.21	0.21	0.21
query19	1.91	1.86	1.95
query20	0.02	0.01	0.01
query21	15.36	0.98	0.58
query22	0.76	0.84	0.66
query23	15.27	1.46	0.51
query24	3.42	1.85	1.30
query25	0.18	0.16	0.15
query26	0.28	0.17	0.13
query27	0.05	0.08	0.04
query28	13.85	0.97	0.44
query29	12.56	3.99	3.28
query30	0.25	0.09	0.06
query31	2.81	0.62	0.38
query32	3.23	0.54	0.44
query33	2.99	3.10	3.06
query34	16.61	5.06	4.43
query35	4.57	4.50	4.50
query36	0.64	0.49	0.48
query37	0.10	0.06	0.07
query38	0.04	0.04	0.04
query39	0.04	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.19 s
Total hot run time: 31.01 s

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 17, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@hust-hhb hust-hhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit 3c4a609 into apache:master Jan 17, 2025
25 of 26 checks passed
bobhan1 added a commit to bobhan1/doris that referenced this pull request Jan 17, 2025
…CHANGE/ROLLUP` in FE (apache#46985)

Related PR: apache#22133

Problem Summary:

apache#22133 forbid doing partial update
during schema change on BE, but this may failed to work when some of
replicas finished alter process on BE and some of them don't. This PR
forbids partial update during schema change on FE to avoid this
situation.
dataroaring pushed a commit that referenced this pull request Jan 31, 2025
zhannngchen pushed a commit that referenced this pull request Feb 10, 2025
### What problem does this PR solve?

#46985 forbid partial update on FE,
so change the corresponding error msg in case.
github-actions bot pushed a commit that referenced this pull request Feb 10, 2025
### What problem does this PR solve?

#46985 forbid partial update on FE,
so change the corresponding error msg in case.
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
…CHANGE/ROLLUP` in FE (apache#46985)

Related PR: apache#22133

Problem Summary:

apache#22133 forbid doing partial update
during schema change on BE, but this may failed to work when some of
replicas finished alter process on BE and some of them don't. This PR
forbids partial update during schema change on FE to avoid this
situation.
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
### What problem does this PR solve?

apache#46985 forbid partial update on FE,
so change the corresponding error msg in case.
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
### What problem does this PR solve?

apache#46985 forbid partial update on FE,
so change the corresponding error msg in case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.8-merged dev/3.0.4-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants