Skip to content

[fix](UT) Fix cloud UT network_util_test and resource_test #47582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hello-stephen merged 2 commits into from
Feb 8, 2025
Merged

[fix](UT) Fix cloud UT network_util_test and resource_test #47582

hello-stephen merged 2 commits into from
Feb 8, 2025

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Feb 7, 2025

What problem does this PR solve?

Related PR: #45255

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

gavinchou commented Feb 7, 2025

run buildall

deardeng
deardeng approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@deardeng deardeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR approved by anyone and no changes requested.

hello-stephen
hello-stephen previously approved these changes Feb 7, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 8, 2025
@gavinchou
Copy link
Contributor Author

gavinchou commented Feb 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Feb 8, 2025

TeamCity cloud ut coverage result:
Function Coverage: 82.38% (1061/1288)
Line Coverage: 65.90% (17553/26635)
Region Coverage: 65.42% (8660/13237)
Branch Coverage: 55.29% (4668/8442)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3ba5508d911a08ba7905051e1feff9885c529998_3ba5508d911a08ba7905051e1feff9885c529998_cloud/report/index.html

@gavinchou gavinchou changed the title [fix](UT) Fix cloud UT network_util_test [fix](UT) Fix cloud UT network_util_test and resource_test Feb 8, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 8, 2025

skip buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025

PR approved by at least one committer and no changes requested.

dataroaring
dataroaring approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen hello-stephen merged commit c689789 into apache:master Feb 8, 2025
31 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 8, 2025
@gavinchou
[fix](UT) Fix cloud UT network_util_test and resource_test (#47582)
ea255db 
### What problem does this PR solve?

Related PR: #45255
@github-actions github-actions bot mentioned this pull request Feb 8, 2025
Merged
hello-stephen added a commit that referenced this pull request Feb 8, 2025
@github-actions @gavinchou @hello-stephen
branch-3.0: [fix](UT) Fix cloud UT network_util_test and resource_test …
7a4ea1a 
…#47582 (#47641)

Cherry-picked from #47582

Co-authored-by: Gavin Chou <gavin@selectdb.com>
Co-authored-by: Dongyang Li <lidongyang@selectdb.com>
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@gavinchou @lzyy2024
[fix](UT) Fix cloud UT network_util_test and resource_test (apache#47582
18fce35 
)

### What problem does this PR solve?

Related PR: apache#45255
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@gavinchou @koarz
[fix](UT) Fix cloud UT network_util_test and resource_test (apache#47582
629a14e 
)

### What problem does this PR solve?

Related PR: apache#45255
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@w41ter w41ter w41ter approved these changes

@hello-stephen hello-stephen hello-stephen approved these changes

@dataroaring dataroaring dataroaring approved these changes

+2 more reviewers

@deardeng deardeng deardeng approved these changes

@Yukang-Lian Yukang-Lian Yukang-Lian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.4-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gavinchou @hello-stephen @doris-robot @deardeng @w41ter @Yukang-Lian @dataroaring @wm1581066