[Fix](memory) Add try catch block for call to DorisCallOnce::call()#47605
Closed
bobhan1 wants to merge 3 commits into
Closed
[Fix](memory) Add try catch block for call to DorisCallOnce::call()#47605bobhan1 wants to merge 3 commits into
DorisCallOnce::call()#47605bobhan1 wants to merge 3 commits into
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31498 ms |
TPC-DS: Total hot run time: 190618 ms |
ClickBench: Total hot run time: 30.47 s |
|
TeamCity be ut coverage result: |
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
cad2c5f to
d9024f1
Compare
insert_many_continuous_binary_data()DorisCallOnce::call()
d617079 to
2f22f6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, memory allocation failure exception will only be thrown when there exists
RETURN_IF_CATCH_EXCEPTION/...in some frame in the calling stack. However,DorisCallOncewill catch and store the exception thrown by inner function and re-throw it for later calls in maybe different calling stack in which there is no try catch block. In this case, it will cause coredump. So this PR add try catch block for every call toDorisCallOnce::call()to avoid coredump.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)