Skip to content

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Feb 10, 2025

What problem does this PR solve?

rename file and usage for :#47677
Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@amorynan amorynan changed the title [fix](ut) fix cases for rename file name link: https://github.com/apache/doris/pull/47677 [fix](ut) fix cases for rename file name link pr 47677 Feb 10, 2025
@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 31479 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f61ef56f2403261601d47abe8278d0a486e0be4e, data reload: false

------ Round 1 ----------------------------------
q1	17632	5423	5058	5058
q2	2036	297	164	164
q3	10422	1221	762	762
q4	10211	1023	538	538
q5	7850	2411	2362	2362
q6	195	169	134	134
q7	897	762	598	598
q8	9300	1267	1140	1140
q9	4768	4675	4643	4643
q10	6858	2328	1880	1880
q11	475	277	252	252
q12	343	352	214	214
q13	17762	3722	3092	3092
q14	235	235	206	206
q15	498	464	462	462
q16	633	633	584	584
q17	570	858	332	332
q18	6941	6239	6135	6135
q19	1318	946	541	541
q20	313	324	189	189
q21	2845	2149	1889	1889
q22	360	324	304	304
Total cold run time: 102462 ms
Total hot run time: 31479 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5130	5158	5128	5128
q2	242	327	236	236
q3	2177	2686	2326	2326
q4	1492	1821	1337	1337
q5	4243	4138	4119	4119
q6	205	164	124	124
q7	1840	1835	1721	1721
q8	2586	2538	2590	2538
q9	7209	7182	7141	7141
q10	3012	3208	2793	2793
q11	577	516	484	484
q12	676	809	644	644
q13	3454	3905	3311	3311
q14	284	296	286	286
q15	514	462	447	447
q16	630	672	630	630
q17	1131	1617	1319	1319
q18	7499	7418	7428	7418
q19	808	802	880	802
q20	1946	2005	1844	1844
q21	5437	4936	4755	4755
q22	627	568	563	563
Total cold run time: 51719 ms
Total hot run time: 49966 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 190065 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f61ef56f2403261601d47abe8278d0a486e0be4e, data reload: false

query1	1296	956	935	935
query2	6199	1912	1839	1839
query3	11058	4783	4632	4632
query4	56391	26151	23474	23474
query5	5241	546	479	479
query6	380	200	211	200
query7	5141	511	298	298
query8	325	268	237	237
query9	6573	2495	2495	2495
query10	422	320	257	257
query11	15221	15135	14955	14955
query12	158	109	104	104
query13	1183	533	391	391
query14	10361	6767	6446	6446
query15	199	204	175	175
query16	6981	698	480	480
query17	1057	728	574	574
query18	1515	423	303	303
query19	199	209	157	157
query20	145	128	126	126
query21	215	121	101	101
query22	4615	4614	4349	4349
query23	34148	33404	33285	33285
query24	5800	2470	2421	2421
query25	454	486	409	409
query26	645	282	153	153
query27	1624	511	346	346
query28	2942	2411	2392	2392
query29	613	602	432	432
query30	221	182	161	161
query31	889	865	796	796
query32	75	70	64	64
query33	434	365	300	300
query34	791	863	522	522
query35	821	870	730	730
query36	956	1017	934	934
query37	125	101	81	81
query38	4319	4408	4222	4222
query39	1523	1491	1470	1470
query40	202	118	105	105
query41	55	48	49	48
query42	127	109	107	107
query43	513	504	476	476
query44	1369	831	809	809
query45	187	178	165	165
query46	897	1055	648	648
query47	1856	1860	1786	1786
query48	399	429	324	324
query49	712	527	439	439
query50	746	759	420	420
query51	4259	4265	4213	4213
query52	107	108	102	102
query53	243	284	188	188
query54	505	504	424	424
query55	83	89	83	83
query56	253	249	272	249
query57	1208	1227	1096	1096
query58	247	235	241	235
query59	2870	3025	2764	2764
query60	306	316	283	283
query61	147	155	119	119
query62	758	737	676	676
query63	229	195	194	194
query64	1424	1046	685	685
query65	3290	3201	3134	3134
query66	729	403	296	296
query67	16014	15457	15338	15338
query68	4556	786	499	499
query69	506	296	263	263
query70	1216	1127	1102	1102
query71	422	298	260	260
query72	6344	3717	3784	3717
query73	853	783	343	343
query74	9038	9222	8701	8701
query75	3208	3178	2650	2650
query76	3641	1170	745	745
query77	533	379	282	282
query78	10053	10088	9313	9313
query79	1911	807	582	582
query80	727	522	455	455
query81	510	272	243	243
query82	422	152	118	118
query83	177	176	154	154
query84	293	96	71	71
query85	741	358	376	358
query86	352	325	288	288
query87	4393	4638	4336	4336
query88	2841	2205	2171	2171
query89	400	311	279	279
query90	1734	194	192	192
query91	132	143	105	105
query92	63	60	55	55
query93	2355	1024	569	569
query94	660	425	305	305
query95	349	271	256	256
query96	499	555	274	274
query97	2786	2885	2742	2742
query98	224	203	202	202
query99	1294	1393	1304	1304
Total cold run time: 294223 ms
Total hot run time: 190065 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.99 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f61ef56f2403261601d47abe8278d0a486e0be4e, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.04	0.03
query3	0.24	0.07	0.06
query4	1.62	0.10	0.10
query5	0.43	0.41	0.39
query6	1.17	0.66	0.66
query7	0.02	0.02	0.02
query8	0.03	0.03	0.03
query9	0.58	0.52	0.52
query10	0.58	0.58	0.56
query11	0.15	0.10	0.10
query12	0.14	0.12	0.11
query13	0.63	0.60	0.60
query14	2.77	2.73	2.72
query15	0.92	0.85	0.86
query16	0.38	0.37	0.38
query17	1.02	1.02	1.00
query18	0.21	0.19	0.19
query19	1.92	1.82	2.06
query20	0.02	0.01	0.02
query21	15.36	0.89	0.55
query22	0.75	1.13	0.70
query23	15.00	1.38	0.64
query24	6.69	1.42	1.18
query25	0.50	0.25	0.06
query26	0.49	0.17	0.13
query27	0.06	0.05	0.04
query28	9.57	0.87	0.43
query29	12.55	3.98	3.30
query30	0.24	0.09	0.06
query31	2.82	0.63	0.39
query32	3.22	0.54	0.45
query33	3.07	2.99	3.05
query34	15.79	5.21	4.57
query35	4.57	4.55	4.56
query36	0.66	0.49	0.48
query37	0.09	0.06	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.14	0.12
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.78 s
Total hot run time: 30.99 s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 42.71% (11232/26298)
Line Coverage: 32.73% (94453/288539)
Region Coverage: 31.87% (48390/151820)
Branch Coverage: 27.76% (24413/87932)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f61ef56f2403261601d47abe8278d0a486e0be4e_f61ef56f2403261601d47abe8278d0a486e0be4e/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 10, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Collaborator

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 53337ed into apache:master Feb 10, 2025
26 of 29 checks passed
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants