Skip to content

[regression](storage vault) test minio as storage vault using Virtual Host Style#47992

Merged
dataroaring merged 1 commit intoapache:masterfrom
yagagagaga:minio_host
Feb 20, 2025
Merged

[regression](storage vault) test minio as storage vault using Virtual Host Style#47992
dataroaring merged 1 commit intoapache:masterfrom
yagagagaga:minio_host

Conversation

@yagagagaga
Copy link
Contributor

@yagagagaga yagagagaga commented Feb 18, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Feb 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yagagagaga yagagagaga changed the title [regression](storage vault) test minio as storage vault using Virtual… [regression](storage vault) test minio as storage vault using Virtual Host Style Feb 18, 2025
@yagagagaga
Copy link
Contributor Author

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 20, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 6d06796 into apache:master Feb 20, 2025
29 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 20, 2025
@yagagagaga yagagagaga deleted the minio_host branch February 20, 2025 03:47
dataroaring pushed a commit that referenced this pull request Feb 20, 2025
…sing Virtual Host Style #47992 (#48124)

Cherry-picked from #47992

Co-authored-by: yagagagaga <zhangminke@selectdb.com>
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.5-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants