Skip to content

[fix](spill) fix and improve some issues#48167

Closed
jacktengg wants to merge 2 commits intoapache:spill_and_reservefrom
jacktengg:spill_and_reserve-fuguo-fix-deadlock-and-cannot-spill
Closed

[fix](spill) fix and improve some issues#48167
jacktengg wants to merge 2 commits intoapache:spill_and_reservefrom
jacktengg:spill_and_reserve-fuguo-fix-deadlock-and-cannot-spill

Conversation

@jacktengg
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

1. improve exchange sink low mem mode;
2. fix string hash table memory usage;
3. improve reserve memory;
4. add debug logs
1. improve exchange memory usage counter;
2. fix deadlock if disable_memory_gc;
3. fix cannot spill but actually have spillable mem;
4. improve some log prints;
5. remove duplicated code.
@Thearas
Copy link
Contributor

Thearas commented Feb 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@jacktengg jacktengg changed the title Spill and reserve fuguo fix deadlock and cannot spill [fix](spill) fix and improve some issues Feb 21, 2025
@jacktengg jacktengg closed this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants