Skip to content

branch-3.0-pick: [Opt](merge-on-write) Check delete bitmap cache after writing it (#48233)#48493

Merged
dataroaring merged 1 commit intoapache:branch-3.0from
bobhan1:branch-3.0-pick-48233
Mar 10, 2025
Merged

branch-3.0-pick: [Opt](merge-on-write) Check delete bitmap cache after writing it (#48233)#48493
dataroaring merged 1 commit intoapache:branch-3.0from
bobhan1:branch-3.0-pick-48233

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Feb 28, 2025

pick #48233

@bobhan1 bobhan1 requested a review from dataroaring as a code owner February 28, 2025 10:26
@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 28, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@bobhan1
Copy link
Contributor Author

bobhan1 commented Feb 28, 2025

run buildall

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 1, 2025

run p0

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 1, 2025

run performance

dataroaring
dataroaring approved these changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2025

PR approved by anyone and no changes requested.

@bobhan1 bobhan1 force-pushed the branch-3.0-pick-48233 branch from 0546b28 to fb006b6 Compare March 4, 2025 08:17
@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 4, 2025

run buildall

@dataroaring dataroaring force-pushed the branch-3.0-pick-48233 branch from fb006b6 to 7b293d5 Compare March 4, 2025 12:43
@dataroaring
Copy link
Contributor

dataroaring commented Mar 4, 2025

run buildall

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 5, 2025

run p0

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 5, 2025

run beut

1 similar comment
@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 5, 2025

run beut

@bobhan1
[Opt](merge-on-write) Check delete bitmap cache after writing it (apa…
c28f7ca 
…che#48233)

check the delete bitmap written to delete bitmap cache has the same
cardinality with the current load's.
@bobhan1 bobhan1 force-pushed the branch-3.0-pick-48233 branch from 7b293d5 to c28f7ca Compare March 7, 2025 02:09
@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 7, 2025

run buildall

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 7, 2025

run beut

1 similar comment
@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 7, 2025

run beut

@bobhan1
Copy link
Contributor Author

bobhan1 commented Mar 7, 2025

run cloud_p0

@dataroaring dataroaring merged commit 32eb082 into apache:branch-3.0 Mar 10, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobhan1 @hello-stephen @dataroaring