Skip to content

branch-3.0: [fix](test) Remove incorrect checks for light_schema_change #48797#48885

Merged
dataroaring merged 1 commit intobranch-3.0from
auto-pick-48797-branch-3.0
Mar 12, 2025
Merged

branch-3.0: [fix](test) Remove incorrect checks for light_schema_change #48797#48885
dataroaring merged 1 commit intobranch-3.0from
auto-pick-48797-branch-3.0

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #48797

test table:
```
CREATE TABLE if NOT EXISTS t
(
    `test` INT,
    `id` INT
)
AGGREGATE KEY(`test`, `id`)
DISTRIBUTED BY HASH(id) BUCKETS 1
PROPERTIES (
    "replication_allocation" = "tag.location.default: 1",
    "light_schema_change" = "true"
);
```

```

CREATE TABLE if NOT EXISTS t
(
    `test` INT,
    `id` INT
)
AGGREGATE KEY(`test`, `id`)
DISTRIBUTED BY HASH(id) BUCKETS 1
PROPERTIES (
    "replication_allocation" = "tag.location.default: 1"
);
```
use `show create table` sql to generate table which is not enable
`light_schema_change`, it will get table which is
enable`light_schema_change`, so there is no need to filter it
```
origin       -> internal       ->target
lsc = true    lsc = true      lsc = true
lsc = false   lsc = true      lsc = true

check internal and target
```
@github-actions github-actions bot requested a review from dataroaring as a code owner March 10, 2025 12:39
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 10, 2025
@hello-stephen
Copy link
Contributor

run buildall

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 12, 2025
@github-actions
Copy link
Contributor Author

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 602f8a2 into branch-3.0 Mar 12, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48797-branch-3.0 branch March 12, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants