Skip to content

Conversation

@meox3259
Copy link

What problem does this PR solve?

Related PR: #48203

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Mar 14, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@superdiaodiao
Copy link
Contributor

run buildall

scalar(Ignore.class, "ignore"),
scalar(Initcap.class, "initcap"),
scalar(InnerProduct.class, "inner_product"),
scalar(InnerProduct.class, "inner_product", "array_dot_product"),
Copy link
Contributor

@superdiaodiao superdiaodiao Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the issue #48203, the function name doesn't have the array prefix.

Suggested change
scalar(InnerProduct.class, "inner_product", "array_dot_product"),
scalar(InnerProduct.class, "inner_product", "dot_product"),

So does the PR title.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@doris-robot
Copy link

TeamCity cloud ut coverage result:
Function Coverage: 82.88% (1075/1297)
Line Coverage: 65.85% (17729/26923)
Region Coverage: 65.18% (8725/13385)
Branch Coverage: 55.16% (4706/8532)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2127404cdd7e3ce28601e9fb9b9116dfccd7488b_2127404cdd7e3ce28601e9fb9b9116dfccd7488b_cloud/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 32473 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2127404cdd7e3ce28601e9fb9b9116dfccd7488b, data reload: false

------ Round 1 ----------------------------------
q1	17607	5145	5087	5087
q2	2038	279	162	162
q3	10573	1220	757	757
q4	10233	1030	539	539
q5	7928	2369	2316	2316
q6	196	162	135	135
q7	915	759	615	615
q8	9323	1246	1066	1066
q9	4880	4706	4824	4706
q10	6857	2309	1939	1939
q11	484	273	262	262
q12	347	355	222	222
q13	17764	3674	3087	3087
q14	233	229	208	208
q15	547	488	484	484
q16	618	626	575	575
q17	577	865	336	336
q18	6795	6471	6311	6311
q19	2047	939	576	576
q20	315	322	195	195
q21	2868	2216	1930	1930
q22	1058	1055	965	965
Total cold run time: 104203 ms
Total hot run time: 32473 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5252	5264	5203	5203
q2	231	328	236	236
q3	2274	2762	2440	2440
q4	1469	1889	1428	1428
q5	4341	4223	4174	4174
q6	206	162	128	128
q7	1988	1933	1782	1782
q8	2604	2539	2622	2539
q9	7249	7284	7199	7199
q10	3075	3262	2791	2791
q11	590	524	500	500
q12	672	704	564	564
q13	3568	4027	3338	3338
q14	280	287	277	277
q15	526	479	488	479
q16	685	709	656	656
q17	1160	1588	1374	1374
q18	7742	7535	7561	7535
q19	852	873	1070	873
q20	1964	2050	1913	1913
q21	5537	4975	4773	4773
q22	1112	1096	1066	1066
Total cold run time: 53377 ms
Total hot run time: 51268 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193433 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2127404cdd7e3ce28601e9fb9b9116dfccd7488b, data reload: false

query1	1382	1018	976	976
query2	6355	1907	1906	1906
query3	11148	4576	4623	4576
query4	55644	24640	23589	23589
query5	5240	566	478	478
query6	370	199	183	183
query7	5046	519	294	294
query8	344	248	237	237
query9	6650	2610	2629	2610
query10	394	304	262	262
query11	15305	15200	15045	15045
query12	161	109	109	109
query13	1142	518	410	410
query14	10230	7072	6904	6904
query15	196	204	180	180
query16	7018	676	536	536
query17	1107	710	561	561
query18	1503	421	321	321
query19	192	188	158	158
query20	127	122	123	122
query21	214	128	114	114
query22	4542	4610	4468	4468
query23	34212	33271	33523	33271
query24	5592	2492	2461	2461
query25	468	463	404	404
query26	709	280	155	155
query27	1972	485	340	340
query28	2765	2483	2455	2455
query29	598	570	436	436
query30	277	218	193	193
query31	869	863	775	775
query32	78	98	67	67
query33	455	373	315	315
query34	753	855	515	515
query35	801	815	766	766
query36	944	987	909	909
query37	125	101	78	78
query38	4439	4398	4169	4169
query39	1502	1429	1422	1422
query40	207	124	110	110
query41	53	54	49	49
query42	130	109	110	109
query43	505	520	500	500
query44	1360	817	822	817
query45	185	180	175	175
query46	854	1042	657	657
query47	1845	1877	1766	1766
query48	404	425	314	314
query49	684	517	436	436
query50	700	757	449	449
query51	4226	4307	4245	4245
query52	119	110	98	98
query53	242	265	205	205
query54	509	507	431	431
query55	82	79	84	79
query56	278	265	267	265
query57	1173	1191	1104	1104
query58	259	250	238	238
query59	2818	2858	2718	2718
query60	279	292	269	269
query61	152	158	152	152
query62	787	761	688	688
query63	234	208	199	199
query64	1850	1168	840	840
query65	4529	4473	4383	4383
query66	711	393	292	292
query67	16013	15647	15228	15228
query68	6587	887	507	507
query69	540	301	265	265
query70	1208	1155	1127	1127
query71	483	293	270	270
query72	6048	3659	3765	3659
query73	1118	760	353	353
query74	8944	9085	8855	8855
query75	3699	3167	2727	2727
query76	4125	1186	763	763
query77	627	372	282	282
query78	10242	10143	9321	9321
query79	2853	837	586	586
query80	693	524	459	459
query81	496	253	225	225
query82	608	125	97	97
query83	186	173	155	155
query84	288	102	77	77
query85	784	375	317	317
query86	395	296	287	287
query87	4548	4631	4401	4401
query88	3648	2301	2266	2266
query89	415	314	279	279
query90	1780	217	217	217
query91	142	138	111	111
query92	79	61	58	58
query93	2378	1086	575	575
query94	681	429	323	323
query95	349	280	268	268
query96	493	566	280	280
query97	3372	3413	3257	3257
query98	239	214	200	200
query99	1687	1400	1280	1280
Total cold run time: 301792 ms
Total hot run time: 193433 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.26 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2127404cdd7e3ce28601e9fb9b9116dfccd7488b, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.03
query3	0.23	0.06	0.07
query4	1.63	0.10	0.10
query5	0.57	0.55	0.54
query6	1.20	0.72	0.72
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.60	0.52	0.52
query10	0.58	0.59	0.58
query11	0.16	0.10	0.11
query12	0.15	0.12	0.11
query13	0.62	0.60	0.60
query14	2.68	2.78	2.71
query15	0.94	0.86	0.85
query16	0.38	0.38	0.37
query17	1.07	1.01	1.04
query18	0.21	0.20	0.20
query19	1.97	1.97	1.85
query20	0.01	0.01	0.01
query21	15.36	0.92	0.55
query22	0.78	1.13	0.65
query23	14.98	1.40	0.60
query24	6.62	1.85	1.19
query25	0.50	0.16	0.08
query26	0.78	0.16	0.13
query27	0.05	0.06	0.04
query28	9.88	0.88	0.43
query29	12.58	3.97	3.31
query30	0.25	0.09	0.06
query31	2.81	0.60	0.38
query32	3.23	0.55	0.47
query33	3.06	3.01	3.06
query34	15.72	5.18	4.57
query35	4.58	4.58	4.55
query36	0.67	0.50	0.49
query37	0.08	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.03
query40	0.18	0.13	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.53 s
Total hot run time: 31.26 s

Copy link
Contributor

@superdiaodiao superdiaodiao Mar 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file remains unchanged is OK. Since only the old planner needs it, the new feature doesn't.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 48.34% (12931/26752)
Line Coverage 37.84% (110946/293178)
Region Coverage 36.80% (56606/153834)
Branch Coverage 32.02% (28507/89022)

@superdiaodiao
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34367 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8ab57a3b4ed702eb44c4516842d73e8e4e4cf0b3, data reload: false

------ Round 1 ----------------------------------
q1	24226	5044	5061	5044
q2	2044	306	207	207
q3	10348	1236	682	682
q4	10240	992	535	535
q5	7517	2354	2308	2308
q6	185	165	130	130
q7	907	749	608	608
q8	9309	1292	1069	1069
q9	6814	5152	5151	5151
q10	6827	2326	1905	1905
q11	476	280	269	269
q12	357	352	220	220
q13	17813	3798	3190	3190
q14	234	227	211	211
q15	535	489	493	489
q16	615	621	591	591
q17	572	844	353	353
q18	7564	7150	7173	7150
q19	1211	944	562	562
q20	340	330	199	199
q21	4078	3516	2531	2531
q22	1059	1024	963	963
Total cold run time: 113271 ms
Total hot run time: 34367 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5110	5152	5191	5152
q2	236	324	237	237
q3	2163	2662	2474	2474
q4	1478	1851	1448	1448
q5	4587	4581	4586	4581
q6	221	169	131	131
q7	2071	1957	1850	1850
q8	2694	2666	2540	2540
q9	7397	7314	7081	7081
q10	2966	3247	2756	2756
q11	594	517	492	492
q12	700	737	587	587
q13	3543	3920	3296	3296
q14	292	304	264	264
q15	536	475	478	475
q16	653	667	643	643
q17	1135	1618	1285	1285
q18	7842	7890	7563	7563
q19	832	888	1065	888
q20	1987	2040	1870	1870
q21	5532	4889	4895	4889
q22	1104	1025	1044	1025
Total cold run time: 53673 ms
Total hot run time: 51527 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193660 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8ab57a3b4ed702eb44c4516842d73e8e4e4cf0b3, data reload: false

query1	1392	1056	1028	1028
query2	6101	1880	1913	1880
query3	11057	4546	4557	4546
query4	55082	24277	23256	23256
query5	5289	534	486	486
query6	387	200	179	179
query7	5246	495	275	275
query8	322	233	223	223
query9	6767	2607	2601	2601
query10	424	305	258	258
query11	15331	15036	15006	15006
query12	166	109	108	108
query13	1212	503	422	422
query14	10196	7314	7365	7314
query15	203	202	185	185
query16	6913	656	462	462
query17	1103	724	567	567
query18	1484	389	300	300
query19	200	195	171	171
query20	133	131	118	118
query21	210	123	106	106
query22	4537	4439	4276	4276
query23	33910	33098	33480	33098
query24	5674	2443	2408	2408
query25	456	459	415	415
query26	686	270	145	145
query27	2047	502	318	318
query28	2956	2435	2423	2423
query29	571	573	437	437
query30	274	216	191	191
query31	880	882	789	789
query32	108	66	60	60
query33	444	358	310	310
query34	758	836	504	504
query35	826	853	753	753
query36	952	1032	916	916
query37	120	99	76	76
query38	4167	4208	4129	4129
query39	1490	1463	1481	1463
query40	206	120	105	105
query41	53	51	51	51
query42	131	109	104	104
query43	472	497	458	458
query44	1302	830	817	817
query45	178	180	171	171
query46	829	1029	660	660
query47	1803	1866	1793	1793
query48	382	420	312	312
query49	723	530	463	463
query50	699	758	418	418
query51	4264	4351	4290	4290
query52	115	105	99	99
query53	218	260	174	174
query54	475	495	410	410
query55	85	81	81	81
query56	291	279	267	267
query57	1176	1215	1120	1120
query58	273	254	237	237
query59	2661	2876	2515	2515
query60	311	299	281	281
query61	164	155	155	155
query62	714	743	725	725
query63	219	182	175	175
query64	1501	1051	739	739
query65	4592	4465	4451	4451
query66	763	390	289	289
query67	15728	15424	15204	15204
query68	8695	870	504	504
query69	531	297	273	273
query70	1219	1108	1109	1108
query71	470	288	255	255
query72	6010	5175	5285	5175
query73	985	691	339	339
query74	9067	9089	8694	8694
query75	3852	3257	2741	2741
query76	4073	1190	750	750
query77	596	355	272	272
query78	10779	10043	9260	9260
query79	2549	871	568	568
query80	711	524	444	444
query81	487	256	227	227
query82	530	125	97	97
query83	176	168	154	154
query84	297	93	78	78
query85	858	364	309	309
query86	401	300	290	290
query87	4451	4583	4292	4292
query88	3545	2253	2257	2253
query89	406	312	271	271
query90	1786	211	206	206
query91	138	138	107	107
query92	77	57	58	57
query93	2250	1057	578	578
query94	659	393	300	300
query95	349	265	332	265
query96	484	569	275	275
query97	3347	3382	3278	3278
query98	224	211	198	198
query99	1346	1403	1276	1276
Total cold run time: 301750 ms
Total hot run time: 193660 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.16 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8ab57a3b4ed702eb44c4516842d73e8e4e4cf0b3, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.11	0.10
query3	0.25	0.19	0.20
query4	1.58	0.20	0.19
query5	0.58	0.59	0.58
query6	1.19	0.72	0.73
query7	0.04	0.01	0.02
query8	0.04	0.04	0.04
query9	0.57	0.53	0.54
query10	0.56	0.59	0.57
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.62	0.61	0.59
query14	2.71	2.74	2.70
query15	0.91	0.84	0.85
query16	0.37	0.39	0.39
query17	1.03	1.06	1.02
query18	0.22	0.21	0.20
query19	1.95	2.03	1.84
query20	0.01	0.01	0.02
query21	15.34	0.93	0.56
query22	0.76	1.33	0.69
query23	14.79	1.41	0.63
query24	6.67	1.93	0.64
query25	0.56	0.29	0.13
query26	0.56	0.16	0.15
query27	0.05	0.05	0.05
query28	9.78	0.94	0.44
query29	12.55	4.07	3.41
query30	0.25	0.09	0.06
query31	2.84	0.59	0.38
query32	3.23	0.54	0.46
query33	2.97	3.05	3.00
query34	15.83	5.09	4.52
query35	4.54	4.50	4.56
query36	0.66	0.49	0.47
query37	0.08	0.07	0.06
query38	0.04	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.13	0.13
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 104.95 s
Total hot run time: 31.16 s

scalar(InnerProduct.class, "inner_product"),
scalar(Instr.class, "instr"),
scalar(InnerProduct.class, "inner_product", "dot_product"),
scalar(Instr.class, "instr"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the tabsize

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late, there is some problem with my PC running regression test, I will try to fix it.

Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add some regression testcases to make sure the function with new name works.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Oct 6, 2025
@github-actions github-actions bot closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants