-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Enhancement] Add other name of inner_product as array_dot_product #49057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Add other name of inner_product as array_dot_product #49057
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
| scalar(Ignore.class, "ignore"), | ||
| scalar(Initcap.class, "initcap"), | ||
| scalar(InnerProduct.class, "inner_product"), | ||
| scalar(InnerProduct.class, "inner_product", "array_dot_product"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the issue #48203, the function name doesn't have the array prefix.
| scalar(InnerProduct.class, "inner_product", "array_dot_product"), | |
| scalar(InnerProduct.class, "inner_product", "dot_product"), |
So does the PR title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 32473 ms |
TPC-DS: Total hot run time: 193433 ms |
ClickBench: Total hot run time: 31.26 s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file remains unchanged is OK. Since only the old planner needs it, the new feature doesn't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
TPC-H: Total hot run time: 34367 ms |
TPC-DS: Total hot run time: 193660 ms |
ClickBench: Total hot run time: 31.16 s |
| scalar(InnerProduct.class, "inner_product"), | ||
| scalar(Instr.class, "instr"), | ||
| scalar(InnerProduct.class, "inner_product", "dot_product"), | ||
| scalar(Instr.class, "instr"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix the tabsize
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late, there is some problem with my PC running regression test, I will try to fix it.
zclllyybb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add some regression testcases to make sure the function with new name works.
|
We're closing this PR because it hasn't been updated in a while. |
What problem does this PR solve?
Related PR: #48203
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)