Skip to content

branch-3.0: [Fix](function) Fix wrong FE fold constant implementation of function date_format #49032#49085

Merged
dataroaring merged 1 commit intobranch-3.0from
auto-pick-49032-branch-3.0
Mar 17, 2025
Merged

branch-3.0: [Fix](function) Fix wrong FE fold constant implementation of function date_format #49032#49085
dataroaring merged 1 commit intobranch-3.0from
auto-pick-49032-branch-3.0

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #49032

@github-actions github-actions bot requested a review from dataroaring as a code owner March 14, 2025 08:57
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 14, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39977 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e5be15563967bb45d69d563a747f476b9a36ddc7, data reload: false

------ Round 1 ----------------------------------
q1	17573	7001	6545	6545
q2	2076	167	162	162
q3	10715	1083	1151	1083
q4	10570	751	713	713
q5	7735	2861	2825	2825
q6	219	136	133	133
q7	964	604	606	604
q8	9343	1956	1992	1956
q9	6639	6349	6413	6349
q10	7028	2257	2295	2257
q11	463	258	256	256
q12	402	207	200	200
q13	17777	3007	3002	3002
q14	241	212	217	212
q15	502	469	479	469
q16	665	592	579	579
q17	969	528	590	528
q18	7158	6711	6730	6711
q19	1390	1104	1032	1032
q20	504	205	198	198
q21	3987	3190	3233	3190
q22	1080	973	977	973
Total cold run time: 108000 ms
Total hot run time: 39977 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6819	6664	6632	6632
q2	338	233	233	233
q3	3046	2849	3034	2849
q4	2115	1854	1800	1800
q5	5822	5756	5796	5756
q6	211	126	122	122
q7	2212	1834	1810	1810
q8	3448	3601	3526	3526
q9	8973	8992	9031	8992
q10	3599	3536	3524	3524
q11	595	493	501	493
q12	799	622	606	606
q13	10479	3280	3283	3280
q14	309	287	289	287
q15	525	473	476	473
q16	716	685	659	659
q17	1855	1674	1618	1618
q18	8896	8341	7794	7794
q19	4758	1733	1668	1668
q20	2119	1899	1814	1814
q21	5437	5432	5349	5349
q22	1110	1029	1030	1029
Total cold run time: 74181 ms
Total hot run time: 60314 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197688 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e5be15563967bb45d69d563a747f476b9a36ddc7, data reload: false

query1	1293	921	882	882
query2	6397	2020	2042	2020
query3	10824	4383	4327	4327
query4	62605	28774	23341	23341
query5	5140	467	462	462
query6	426	181	190	181
query7	5492	313	312	312
query8	313	224	229	224
query9	8760	2649	2638	2638
query10	472	276	262	262
query11	17770	15162	15750	15162
query12	162	102	103	102
query13	1466	464	438	438
query14	10819	7584	7676	7584
query15	201	179	180	179
query16	7095	474	496	474
query17	1261	605	578	578
query18	2022	321	310	310
query19	218	162	175	162
query20	113	115	109	109
query21	210	103	102	102
query22	4794	4648	4580	4580
query23	34428	34047	33892	33892
query24	6141	2949	2999	2949
query25	571	414	435	414
query26	672	169	167	167
query27	1892	358	366	358
query28	4311	2483	2435	2435
query29	706	440	435	435
query30	237	165	162	162
query31	983	806	855	806
query32	68	57	59	57
query33	494	279	284	279
query34	913	505	496	496
query35	840	739	719	719
query36	1083	966	963	963
query37	113	66	65	65
query38	4177	4015	4077	4015
query39	1503	1521	1561	1521
query40	208	101	100	100
query41	54	55	49	49
query42	114	105	105	105
query43	543	503	509	503
query44	1211	855	831	831
query45	188	167	168	167
query46	1130	734	719	719
query47	1992	1852	1934	1852
query48	483	371	391	371
query49	754	412	401	401
query50	843	420	435	420
query51	7478	7174	7172	7172
query52	105	93	93	93
query53	266	189	188	188
query54	573	464	462	462
query55	80	83	81	81
query56	259	267	240	240
query57	1290	1126	1181	1126
query58	235	208	211	208
query59	3069	3071	3037	3037
query60	277	263	246	246
query61	109	108	107	107
query62	778	670	650	650
query63	219	184	185	184
query64	1843	695	635	635
query65	3235	3209	3245	3209
query66	724	299	299	299
query67	15930	15811	15543	15543
query68	4265	585	585	585
query69	416	261	261	261
query70	1157	1110	1078	1078
query71	340	258	255	255
query72	6340	4010	4013	4010
query73	745	352	361	352
query74	10144	9174	9021	9021
query75	3371	2622	2655	2622
query76	1956	1032	1050	1032
query77	553	268	277	268
query78	10672	9705	9570	9570
query79	1135	603	592	592
query80	840	428	440	428
query81	511	249	239	239
query82	1304	91	90	90
query83	241	149	148	148
query84	285	82	77	77
query85	894	300	289	289
query86	311	307	294	294
query87	4415	4224	4232	4224
query88	3460	2423	2387	2387
query89	411	290	290	290
query90	2002	184	188	184
query91	183	154	151	151
query92	64	49	50	49
query93	1329	549	553	549
query94	759	296	285	285
query95	361	258	254	254
query96	605	284	280	280
query97	3289	3176	3184	3176
query98	212	199	194	194
query99	1847	1294	1301	1294
Total cold run time: 315392 ms
Total hot run time: 197688 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.34 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e5be15563967bb45d69d563a747f476b9a36ddc7, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.02	0.03
query3	0.23	0.07	0.07
query4	1.63	0.10	0.11
query5	0.51	0.53	0.49
query6	1.13	0.73	0.74
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.57	0.51	0.49
query10	0.55	0.55	0.55
query11	0.14	0.11	0.10
query12	0.14	0.10	0.12
query13	0.60	0.60	0.58
query14	2.75	2.77	2.75
query15	0.88	0.82	0.82
query16	0.38	0.38	0.38
query17	1.03	1.03	1.03
query18	0.23	0.22	0.22
query19	1.99	1.84	2.00
query20	0.02	0.01	0.01
query21	15.37	0.55	0.57
query22	2.96	1.87	2.52
query23	16.92	1.01	0.96
query24	2.93	1.04	1.48
query25	0.29	0.11	0.12
query26	0.49	0.13	0.13
query27	0.04	0.03	0.05
query28	10.01	0.50	0.45
query29	12.66	3.22	3.19
query30	0.25	0.06	0.06
query31	2.88	0.38	0.37
query32	3.24	0.46	0.45
query33	2.96	3.07	3.02
query34	16.97	4.46	4.51
query35	4.56	4.55	4.52
query36	0.68	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.03
query39	0.04	0.03	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 106.62 s
Total hot run time: 32.34 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 252645c into branch-3.0 Mar 17, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49032-branch-3.0 branch March 17, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants