Skip to content

branch-3.0: [fix](nereids)fix the cascadesContext.getMemo()==null #48771#49094

Merged
dataroaring merged 1 commit intobranch-3.0from
auto-pick-48771-branch-3.0
Mar 15, 2025
Merged

branch-3.0: [fix](nereids)fix the cascadesContext.getMemo()==null #48771#49094
dataroaring merged 1 commit intobranch-3.0from
auto-pick-48771-branch-3.0

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #48771

### What problem does this PR solve?

fix the cascadesContext.getMemo() == null, the error:
Cannot invoke "org.apache.doris.nereids.memo.Memo.toString()" because
the return value of "org.apache.doris.nereids.CascadesContext.getMemo()"
is null
@github-actions github-actions bot requested a review from dataroaring as a code owner March 14, 2025 10:20
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Mar 14, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41062 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5e3365609d5f367c0db305dbf8961a38e4899b3e, data reload: false

------ Round 1 ----------------------------------
q1	16266	6980	6715	6715
q2	2054	171	166	166
q3	6060	1298	1196	1196
q4	9205	760	827	760
q5	7364	2982	2880	2880
q6	226	133	137	133
q7	1015	645	636	636
q8	8667	1989	2098	1989
q9	6584	6527	6521	6521
q10	7348	2319	2351	2319
q11	469	273	266	266
q12	509	227	228	227
q13	3947	3125	3151	3125
q14	248	219	218	218
q15	499	470	478	470
q16	677	598	593	593
q17	980	565	550	550
q18	7269	6797	6789	6789
q19	1275	1043	1053	1043
q20	399	202	204	202
q21	4041	3341	3289	3289
q22	1071	975	989	975
Total cold run time: 86173 ms
Total hot run time: 41062 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6663	6628	6626	6626
q2	325	229	225	225
q3	2929	2795	2787	2787
q4	1942	1682	1761	1682
q5	5473	5505	5650	5505
q6	212	131	127	127
q7	2264	1851	1800	1800
q8	3353	3533	3547	3533
q9	8988	8981	8850	8850
q10	3429	3476	3441	3441
q11	604	489	490	489
q12	827	553	575	553
q13	4522	3014	3022	3014
q14	282	253	272	253
q15	507	462	462	462
q16	679	640	624	624
q17	1809	1588	1554	1554
q18	7951	7617	7323	7323
q19	1660	1409	1547	1409
q20	2025	1830	1825	1825
q21	5407	5248	5192	5192
q22	1088	1024	996	996
Total cold run time: 62939 ms
Total hot run time: 58270 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191107 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5e3365609d5f367c0db305dbf8961a38e4899b3e, data reload: false

query1	970	370	363	363
query2	6526	2032	2065	2032
query3	6704	221	214	214
query4	34120	23552	23375	23375
query5	4415	465	449	449
query6	284	184	182	182
query7	4634	318	318	318
query8	288	232	223	223
query9	9654	2637	2630	2630
query10	462	282	273	273
query11	18530	15251	15115	15115
query12	161	112	104	104
query13	1655	442	431	431
query14	10730	7339	6634	6634
query15	253	172	183	172
query16	8061	451	496	451
query17	1622	581	563	563
query18	2123	321	317	317
query19	305	175	154	154
query20	118	114	107	107
query21	211	101	103	101
query22	4364	4407	4194	4194
query23	35780	33770	34240	33770
query24	11871	2856	2813	2813
query25	598	413	420	413
query26	1275	174	174	174
query27	2848	352	349	349
query28	7763	2433	2456	2433
query29	688	450	437	437
query30	335	166	167	166
query31	1070	818	813	813
query32	103	61	60	60
query33	797	306	315	306
query34	945	495	531	495
query35	851	715	727	715
query36	1144	953	927	927
query37	222	66	68	66
query38	3926	3818	3854	3818
query39	1487	1426	1431	1426
query40	291	101	99	99
query41	56	49	51	49
query42	114	99	103	99
query43	517	510	495	495
query44	1326	834	828	828
query45	184	166	166	166
query46	1156	693	702	693
query47	1923	1804	1838	1804
query48	475	383	384	383
query49	1255	397	405	397
query50	794	405	409	405
query51	7249	7131	7091	7091
query52	102	94	91	91
query53	260	186	185	185
query54	1142	469	453	453
query55	85	74	80	74
query56	274	245	244	244
query57	1236	1082	1096	1082
query58	238	207	217	207
query59	3132	2992	3003	2992
query60	295	270	264	264
query61	116	105	125	105
query62	851	670	671	670
query63	216	194	187	187
query64	5156	678	668	668
query65	3323	3208	3218	3208
query66	1237	337	315	315
query67	16036	15591	15657	15591
query68	4922	594	587	587
query69	453	266	261	261
query70	1186	1085	1124	1085
query71	395	257	268	257
query72	6094	4101	4012	4012
query73	765	343	362	343
query74	10461	9044	9283	9044
query75	3413	2615	2625	2615
query76	3141	1101	1132	1101
query77	410	291	273	273
query78	10399	9683	9589	9589
query79	1071	610	605	605
query80	633	446	426	426
query81	498	239	244	239
query82	190	91	88	88
query83	203	153	149	149
query84	240	82	81	81
query85	939	328	317	317
query86	342	282	292	282
query87	4390	4282	4252	4252
query88	3878	2407	2385	2385
query89	393	300	290	290
query90	2024	190	189	189
query91	185	149	151	149
query92	61	53	53	53
query93	1081	571	558	558
query94	737	304	284	284
query95	359	254	260	254
query96	614	284	285	284
query97	3283	3124	3197	3124
query98	217	210	198	198
query99	1490	1344	1305	1305
Total cold run time: 301399 ms
Total hot run time: 191107 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5e3365609d5f367c0db305dbf8961a38e4899b3e, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.06
query4	1.63	0.10	0.10
query5	0.55	0.51	0.53
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.56	0.51	0.50
query10	0.55	0.55	0.56
query11	0.14	0.11	0.11
query12	0.14	0.14	0.11
query13	0.60	0.61	0.60
query14	2.72	2.76	2.74
query15	0.90	0.83	0.82
query16	0.39	0.41	0.36
query17	1.08	1.07	1.02
query18	0.24	0.23	0.21
query19	1.95	1.97	1.74
query20	0.02	0.01	0.01
query21	15.36	0.58	0.59
query22	2.70	2.09	1.62
query23	17.07	0.91	0.73
query24	2.91	1.48	0.67
query25	0.21	0.08	0.14
query26	0.40	0.13	0.15
query27	0.04	0.04	0.04
query28	10.66	0.53	0.44
query29	13.07	3.25	3.19
query30	0.25	0.06	0.06
query31	2.85	0.38	0.38
query32	3.25	0.46	0.46
query33	2.98	3.02	3.00
query34	17.07	4.52	4.48
query35	4.56	4.48	4.46
query36	0.68	0.50	0.48
query37	0.10	0.06	0.07
query38	0.05	0.03	0.03
query39	0.04	0.03	0.02
query40	0.18	0.13	0.13
query41	0.09	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.02
Total cold run time: 107.58 s
Total hot run time: 31.36 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 40805f2 into branch-3.0 Mar 15, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-48771-branch-3.0 branch March 15, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants