Skip to content

[fix](mtmv) Fix collecting mv candidates when dml controlled by enable_dml_materialized_view_rewrite switch #48374#49263

Merged
yiguolei merged 2 commits intoapache:branch-2.1from
seawinde:fix_collect_candidates_21
Mar 20, 2025
Merged

[fix](mtmv) Fix collecting mv candidates when dml controlled by enable_dml_materialized_view_rewrite switch #48374#49263
yiguolei merged 2 commits intoapache:branch-2.1from
seawinde:fix_collect_candidates_21

Conversation

@seawinde
Copy link
Member

What problem does this PR solve?

pr: #48374
commitId: 0c9ce72

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…le_dml_materialized_view_rewrite switch (apache#48374)

fix collecting mv candidates when dml controlled by
enable_dml_materialized_view_rewrite switch

if we run set command as following:

set global enable_dml_materialized_view_rewrite = false;

when we run refresh command as following

refresh materialized view mv_name complete;

should not try to collect candidates for mv rewritting, but now would
collect candidates
@seawinde seawinde requested a review from yiguolei as a code owner March 19, 2025 10:04
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@seawinde
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 20, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 17ffd30 into apache:branch-2.1 Mar 20, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants