Skip to content

fix[variant] fix base sprase column reader #49385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 1 commit into from
Mar 24, 2025
Merged

fix[variant] fix base sprase column reader #49385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions be/src/olap/rowset/segment_v2/hierarchical_data_reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,10 +193,22 @@ class BaseSparseColumnProcessor : public ColumnIterator {
return _sparse_column_reader->init(opts);
}

// When performing compaction, multiple columns are extracted from the sparse columns,
// and the sparse columns only need to be read once.
// So we need to cache the sparse column and reuse it.
// The cache is only used when the compaction reader is used.
bool has_sparse_column_cache() const {
Copy link
Member

@eldenmoon eldenmoon Mar 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need ut in further test

return _read_opts && _read_opts->sparse_column_cache[_col.parent_unique_id()] &&
ColumnReader::is_compaction_reader_type(_read_opts->io_ctx.reader_type);
}

// Standard seek implementations
Status seek_to_first() override { return _sparse_column_reader->seek_to_first(); }

Status seek_to_ordinal(ordinal_t ord) override {
if (has_sparse_column_cache()) {
return Status::OK();
}
return _sparse_column_reader->seek_to_ordinal(ord);
}

Expand All @@ -209,14 +221,14 @@ class BaseSparseColumnProcessor : public ColumnIterator {
Status _process_batch(ReadMethod&& read_method, size_t nrows,
vectorized::MutableColumnPtr& dst) {
// Cache check and population logic
if (_read_opts && _read_opts->sparse_column_cache[_col.parent_unique_id()] &&
ColumnReader::is_compaction_reader_type(_read_opts->io_ctx.reader_type)) {
if (has_sparse_column_cache()) {
_sparse_column =
_read_opts->sparse_column_cache[_col.parent_unique_id()]->assume_mutable();
} else {
_sparse_column->clear();
RETURN_IF_ERROR(read_method());

// cache the sparse column
if (_read_opts) {
_read_opts->sparse_column_cache[_col.parent_unique_id()] =
_sparse_column->get_ptr();
Expand Down