Skip to content

[fix](tracker) Missing attaching task in fold constant executor#49405

Merged
yiguolei merged 1 commit intoapache:masterfrom
mrhhsg:fix_fold_const
Mar 24, 2025
Merged

[fix](tracker) Missing attaching task in fold constant executor#49405
yiguolei merged 1 commit intoapache:masterfrom
mrhhsg:fix_fold_const

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Mar 24, 2025

What problem does this PR solve?

*** SIGABRT unknown detail explain (@0x153a) received by PID 5434 (TID 6259 OR 0x7fc8ace97640) from PID 5434; stack trace: ***
F20250320 23:44:04.857388  6195 thread_context.h:202] Check failed: is_attach_task() 
*** Check failure stack trace: ***
    @     0x55da7cd769a6  google::LogMessage::SendToLog()
    @     0x55da7cd733f0  google::LogMessage::Flush()
    @     0x55da7cd771e9  google::LogMessageFatal::~LogMessageFatal()
    @     0x55da7709482f  Allocator<>::sys_memory_check()
    @     0x55da7709665d  Allocator<>::alloc_impl()
    @     0x55da72495ab7  doris::vectorized::ColumnVector<>::reserve()
    @     0x55da770f7a82  doris::vectorized::IDataType::create_column_const()
    @     0x55da774d2ccf  doris::vectorized::VLiteral::init()
    @     0x55da774ae32f  std::_Sp_counted_ptr_inplace<>::_Sp_counted_ptr_inplace<>()
    @     0x55da774a2209  doris::vectorized::VExpr::create_expr()
    @     0x55da774a3b50  doris::vectorized::VExpr::create_tree_from_thrift()
    @     0x55da774a3e6b  doris::vectorized::VExpr::create_expr_tree()
    @     0x55da72a1582f  doris::FoldConstantExecutor::fold_constant_vexpr()
    @     0x55da729eecf4  doris::PInternalService::_fold_constant_expr()
    @     0x55da729fd41d  std::_Function_handler<>::_M_invoke()
    @     0x55da72a0da1b  doris::WorkThreadPool<>::work_thread()
    @     0x55da7fd974f0  execute_native_thread_routine
    @     0x7fca5d9faac3  (unknown)
    @     0x7fca5da8c850  (unknown)
    @              (nil)  (unknown)

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@mrhhsg
Copy link
Member Author

mrhhsg commented Mar 24, 2025

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 34345 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit af812db38738b8f39e24ef5d47037c2dcb678c8b, data reload: false

------ Round 1 ----------------------------------
q1	25996	5161	5050	5050
q2	2061	281	167	167
q3	10415	1247	674	674
q4	10221	993	526	526
q5	7484	2388	2341	2341
q6	182	161	135	135
q7	920	752	607	607
q8	9315	1266	1104	1104
q9	6807	5123	5145	5123
q10	6871	2293	1918	1918
q11	485	280	260	260
q12	346	356	216	216
q13	17766	3644	3161	3161
q14	235	229	213	213
q15	522	491	482	482
q16	617	609	593	593
q17	583	853	346	346
q18	7521	7131	7147	7131
q19	1883	961	559	559
q20	316	326	195	195
q21	3817	3496	2581	2581
q22	1016	1031	963	963
Total cold run time: 115379 ms
Total hot run time: 34345 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5268	5177	5149	5149
q2	241	326	232	232
q3	2164	2651	2319	2319
q4	1373	1842	1455	1455
q5	4509	4397	4401	4397
q6	218	169	130	130
q7	2021	1898	1780	1780
q8	2614	2654	2542	2542
q9	7341	7205	7058	7058
q10	2996	3183	2751	2751
q11	565	508	505	505
q12	720	785	607	607
q13	3526	3913	3369	3369
q14	304	317	267	267
q15	508	476	472	472
q16	653	690	646	646
q17	1156	1551	1436	1436
q18	7797	7609	7436	7436
q19	810	754	853	754
q20	1928	1969	1839	1839
q21	5388	4888	4896	4888
q22	1095	1083	1037	1037
Total cold run time: 53195 ms
Total hot run time: 51069 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193205 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit af812db38738b8f39e24ef5d47037c2dcb678c8b, data reload: false

query1	1490	1071	1047	1047
query2	6097	2000	1996	1996
query3	11012	4498	4499	4498
query4	53472	24811	22888	22888
query5	5078	582	471	471
query6	329	206	192	192
query7	4879	505	279	279
query8	321	270	241	241
query9	5503	2623	2621	2621
query10	379	315	254	254
query11	15201	15140	14928	14928
query12	165	117	104	104
query13	1054	499	378	378
query14	10144	6321	6389	6321
query15	186	197	172	172
query16	7051	660	474	474
query17	1063	744	582	582
query18	1555	417	317	317
query19	207	184	165	165
query20	127	132	122	122
query21	211	121	109	109
query22	4389	4396	4253	4253
query23	34117	33489	33333	33333
query24	6547	2427	2427	2427
query25	454	454	403	403
query26	650	276	146	146
query27	2541	501	335	335
query28	3013	2477	2469	2469
query29	592	576	438	438
query30	283	229	189	189
query31	884	863	795	795
query32	70	67	62	62
query33	458	388	324	324
query34	749	862	493	493
query35	808	914	776	776
query36	956	1009	908	908
query37	120	96	75	75
query38	4199	4244	4190	4190
query39	1506	1458	1439	1439
query40	215	117	102	102
query41	55	52	51	51
query42	151	112	104	104
query43	496	513	503	503
query44	1363	834	832	832
query45	183	176	171	171
query46	863	1035	662	662
query47	1874	1901	1791	1791
query48	372	432	306	306
query49	682	490	446	446
query50	742	758	435	435
query51	4260	4371	4262	4262
query52	114	114	97	97
query53	242	264	184	184
query54	491	525	462	462
query55	88	85	91	85
query56	312	309	308	308
query57	1174	1230	1151	1151
query58	275	273	260	260
query59	2800	2868	2687	2687
query60	289	306	276	276
query61	167	147	148	147
query62	726	728	678	678
query63	235	194	189	189
query64	1506	1052	677	677
query65	4549	4499	4483	4483
query66	787	395	298	298
query67	16034	15547	15280	15280
query68	7316	826	506	506
query69	551	311	268	268
query70	1252	1063	1153	1063
query71	497	302	259	259
query72	5781	5265	5321	5265
query73	1513	685	348	348
query74	9001	8994	8843	8843
query75	3959	3218	2746	2746
query76	4217	1206	767	767
query77	630	380	286	286
query78	10233	10018	9209	9209
query79	2584	797	563	563
query80	705	518	428	428
query81	493	253	215	215
query82	624	128	97	97
query83	198	173	156	156
query84	291	97	73	73
query85	796	350	308	308
query86	383	284	264	264
query87	4604	4499	4407	4407
query88	3446	2226	2194	2194
query89	408	308	276	276
query90	1774	204	206	204
query91	144	136	107	107
query92	70	60	56	56
query93	2490	1058	580	580
query94	669	418	306	306
query95	353	275	265	265
query96	490	572	278	278
query97	3340	3392	3259	3259
query98	233	250	205	205
query99	1451	1394	1263	1263
Total cold run time: 299401 ms
Total hot run time: 193205 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.25 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit af812db38738b8f39e24ef5d47037c2dcb678c8b, data reload: false

query1	0.04	0.03	0.03
query2	0.14	0.10	0.10
query3	0.26	0.20	0.19
query4	1.59	0.19	0.19
query5	0.61	0.58	0.58
query6	1.18	0.70	0.71
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.58	0.52	0.52
query10	0.56	0.61	0.57
query11	0.15	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.59	0.60
query14	2.80	2.84	2.81
query15	0.93	0.85	0.84
query16	0.38	0.37	0.37
query17	1.00	1.03	1.03
query18	0.20	0.20	0.19
query19	1.96	1.97	1.84
query20	0.01	0.01	0.01
query21	15.36	0.89	0.53
query22	0.76	1.06	0.62
query23	15.13	1.36	0.64
query24	6.85	1.26	0.80
query25	0.49	0.22	0.12
query26	0.76	0.16	0.14
query27	0.05	0.05	0.04
query28	9.82	0.93	0.43
query29	12.58	3.95	3.34
query30	0.25	0.10	0.06
query31	2.84	0.58	0.39
query32	3.23	0.55	0.48
query33	3.01	3.09	3.04
query34	15.73	5.11	4.51
query35	4.50	4.48	4.51
query36	0.67	0.48	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.02	0.02	0.02
query40	0.17	0.14	0.14
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.71 s
Total hot run time: 31.25 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 50.23% (13441/26760)
Line Coverage 39.68% (116451/293478)
Region Coverage 38.39% (59176/154162)
Branch Coverage 33.52% (29895/89182)

Copy link
Contributor

@xinyiZzz xinyiZzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 24, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 0b0d218 into apache:master Mar 24, 2025
24 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 24, 2025
### What problem does this PR solve?

```
*** SIGABRT unknown detail explain (@0x153a) received by PID 5434 (TID 6259 OR 0x7fc8ace97640) from PID 5434; stack trace: ***
F20250320 23:44:04.857388  6195 thread_context.h:202] Check failed: is_attach_task() 
*** Check failure stack trace: ***
    @     0x55da7cd769a6  google::LogMessage::SendToLog()
    @     0x55da7cd733f0  google::LogMessage::Flush()
    @     0x55da7cd771e9  google::LogMessageFatal::~LogMessageFatal()
    @     0x55da7709482f  Allocator<>::sys_memory_check()
    @     0x55da7709665d  Allocator<>::alloc_impl()
    @     0x55da72495ab7  doris::vectorized::ColumnVector<>::reserve()
    @     0x55da770f7a82  doris::vectorized::IDataType::create_column_const()
    @     0x55da774d2ccf  doris::vectorized::VLiteral::init()
    @     0x55da774ae32f  std::_Sp_counted_ptr_inplace<>::_Sp_counted_ptr_inplace<>()
    @     0x55da774a2209  doris::vectorized::VExpr::create_expr()
    @     0x55da774a3b50  doris::vectorized::VExpr::create_tree_from_thrift()
    @     0x55da774a3e6b  doris::vectorized::VExpr::create_expr_tree()
    @     0x55da72a1582f  doris::FoldConstantExecutor::fold_constant_vexpr()
    @     0x55da729eecf4  doris::PInternalService::_fold_constant_expr()
    @     0x55da729fd41d  std::_Function_handler<>::_M_invoke()
    @     0x55da72a0da1b  doris::WorkThreadPool<>::work_thread()
    @     0x55da7fd974f0  execute_native_thread_routine
    @     0x7fca5d9faac3  (unknown)
    @     0x7fca5da8c850  (unknown)
    @              (nil)  (unknown)
```

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
dataroaring pushed a commit that referenced this pull request Mar 27, 2025
…ecutor #49405 (#49423)

Cherry-picked from #49405

Co-authored-by: Jerry Hu <hushenggang@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
…he#49405)

### What problem does this PR solve?

```
*** SIGABRT unknown detail explain (@0x153a) received by PID 5434 (TID 6259 OR 0x7fc8ace97640) from PID 5434; stack trace: ***
F20250320 23:44:04.857388  6195 thread_context.h:202] Check failed: is_attach_task() 
*** Check failure stack trace: ***
    @     0x55da7cd769a6  google::LogMessage::SendToLog()
    @     0x55da7cd733f0  google::LogMessage::Flush()
    @     0x55da7cd771e9  google::LogMessageFatal::~LogMessageFatal()
    @     0x55da7709482f  Allocator<>::sys_memory_check()
    @     0x55da7709665d  Allocator<>::alloc_impl()
    @     0x55da72495ab7  doris::vectorized::ColumnVector<>::reserve()
    @     0x55da770f7a82  doris::vectorized::IDataType::create_column_const()
    @     0x55da774d2ccf  doris::vectorized::VLiteral::init()
    @     0x55da774ae32f  std::_Sp_counted_ptr_inplace<>::_Sp_counted_ptr_inplace<>()
    @     0x55da774a2209  doris::vectorized::VExpr::create_expr()
    @     0x55da774a3b50  doris::vectorized::VExpr::create_tree_from_thrift()
    @     0x55da774a3e6b  doris::vectorized::VExpr::create_expr_tree()
    @     0x55da72a1582f  doris::FoldConstantExecutor::fold_constant_vexpr()
    @     0x55da729eecf4  doris::PInternalService::_fold_constant_expr()
    @     0x55da729fd41d  std::_Function_handler<>::_M_invoke()
    @     0x55da72a0da1b  doris::WorkThreadPool<>::work_thread()
    @     0x55da7fd974f0  execute_native_thread_routine
    @     0x7fca5d9faac3  (unknown)
    @     0x7fca5da8c850  (unknown)
    @              (nil)  (unknown)
```

Related PR: #xxx

Problem Summary:

### Release note

None

### Check List (For Author)

- Test <!-- At least one of them must be included. -->
    - [ ] Regression test
    - [ ] Unit Test
    - [ ] Manual test (add detailed scripts or steps below)
    - [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
        - [ ] Previous test can cover this change.
        - [ ] No code files have been changed.
        - [ ] Other reason <!-- Add your reason?  -->

- Behavior changed:
    - [ ] No.
    - [ ] Yes. <!-- Explain the behavior change -->

- Does this need documentation?
    - [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
apache/doris-website#1214 -->

### Check List (For Reviewer who merge this PR)

- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.5-merged p0_c reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants