[feature](catalog) support trino connector catalog sink #49407
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
morningman
reviewed
Apr 2, 2025
| return new IcebergTransactionManager(ops); | ||
| } | ||
|
|
||
| public static TransactionManager createTrinoConnectorTransactionManager() { |
| super(); | ||
| } | ||
|
|
||
| public TrinoConnectorInsertCommandContext(Map<String, String> trinoConnectorOptions) { |
Contributor
There was a problem hiding this comment.
This constructor is not used
| )); | ||
|
|
||
| // Set transaction flag | ||
| tTrinoConnectorTableSink.setUseTransaction(false); |
Contributor
There was a problem hiding this comment.
What is diff between true and false?
| private void initConnector() { | ||
| String connectorName = trinoConnectorOptionParams.remove("connector.name"); | ||
|
|
||
| TrinoConnectorCacheKey cacheKey = new TrinoConnectorCacheKey(catalogNameString, connectorName, |
Contributor
There was a problem hiding this comment.
I think better use catalog id instead of createtime
| LOG.error("Exception: " + stringWriter); | ||
| } | ||
|
|
||
| private String mapTrinoTypeToDorisType(String trinoType) { |
Contributor
There was a problem hiding this comment.
what about complex type?
| } else if (trinoType.startsWith("varbinary")) { | ||
| return "BINARY"; | ||
| } else { | ||
| return "VARCHAR"; |
Contributor
There was a problem hiding this comment.
Is it safe to use varchar for all other types?
| return status; | ||
| } | ||
|
|
||
| LOG(INFO) << "Successfully wrote " << num_rows << " rows to Trino connector"; |
| return status; | ||
| } | ||
|
|
||
| LOG(INFO) << "Successfully finished writing to Trino connector"; |
| : AsyncResultWriter(output_exprs, dep, fin_dep) { | ||
| const TTrinoConnnectorTableSink& t_trino_sink = t_sink.trino_connector_table_sink; | ||
|
|
||
| // 收集列名和类型 |
| return Status::OK(); | ||
| } | ||
|
|
||
| Status VTrinoConnectorTableWriter::finish(RuntimeState* state) { |
Contributor
There was a problem hiding this comment.
Add some profile metric for these phases. like write, finish
zy-kkk
commented
May 27, 2025
| std::unique_ptr<long[]> meta_data; | ||
| RETURN_IF_ERROR(JniConnector::to_java_table(block, meta_data)); | ||
| long meta_address = (long)meta_data.get(); | ||
| auto table_schema = JniConnector::parse_table_schema(block); |
| return Status::OK(); | ||
| } | ||
|
|
||
| Status JniConnector::_init_jni_writer(JNIEnv* env) { |
| ConnectorSession connectorSession = session.toConnectorSession(catalogHandle); | ||
| metadata = connector.getMetadata(connectorSession, connectorTransactionHandle); | ||
|
|
||
| insertTableHandle = metadata.beginInsert( |
Member
Author
There was a problem hiding this comment.
insertTableHandle 是否需要放到 FE
| Objects.requireNonNull(connectorPageSinkProvider, | ||
| String.format("Connector '%s' returned a null page sink provider", catalogNameString)); | ||
| } catch (UnsupportedOperationException e) { | ||
| LOG.debug("exception when getPageSinkProvider: {}", e.getMessage()); |
| new ConnectorPageSinkId() { | ||
| @Override | ||
| public long getId() { | ||
| return 0; |
| String typeName = trinoType.getDisplayName(); | ||
| BlockBuilder blockBuilder = pageBuilder.getBlockBuilder(colIdx); | ||
|
|
||
| if (typeName.equals("boolean")) { |
Contributor
|
We're closing this PR because it hasn't been updated in a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.