Skip to content

Conversation

@yx-keith
Copy link
Contributor

@yx-keith yx-keith commented Apr 8, 2025

What problem does this PR solve?

Issue Number: #42792

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yx-keith
Copy link
Contributor Author

yx-keith commented Jun 8, 2025

run buildall

@yx-keith
Copy link
Contributor Author

yx-keith commented Jun 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33709 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 211790a61cb62a97900ff5338539798870e33a01, data reload: false

------ Round 1 ----------------------------------
q1	25764	5055	4950	4950
q2	1947	272	185	185
q3	10301	1228	681	681
q4	10227	993	532	532
q5	7525	2372	2294	2294
q6	183	173	137	137
q7	889	743	629	629
q8	9302	1215	1046	1046
q9	6899	5169	5128	5128
q10	6907	2372	1908	1908
q11	499	290	281	281
q12	344	352	217	217
q13	17890	3705	3067	3067
q14	224	231	221	221
q15	562	492	485	485
q16	432	446	372	372
q17	595	855	359	359
q18	7439	7110	7009	7009
q19	1758	945	573	573
q20	344	348	218	218
q21	3629	3185	2415	2415
q22	1050	1023	1002	1002
Total cold run time: 114710 ms
Total hot run time: 33709 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5061	5008	5021	5008
q2	236	316	219	219
q3	2191	2657	2321	2321
q4	1365	1788	1416	1416
q5	4410	4344	4377	4344
q6	221	175	129	129
q7	2013	1879	1775	1775
q8	2576	2600	2545	2545
q9	7198	7235	6977	6977
q10	3082	3193	2787	2787
q11	579	504	492	492
q12	683	759	597	597
q13	3556	3897	3222	3222
q14	269	300	293	293
q15	519	481	484	481
q16	446	490	429	429
q17	1132	1493	1420	1420
q18	7659	7621	7453	7453
q19	820	899	901	899
q20	2005	2077	1853	1853
q21	4886	4433	4457	4433
q22	1097	1066	1044	1044
Total cold run time: 52004 ms
Total hot run time: 50137 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193493 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 211790a61cb62a97900ff5338539798870e33a01, data reload: false

query1	1419	1080	1060	1060
query2	6407	1816	1793	1793
query3	11134	4641	4567	4567
query4	25473	23752	23552	23552
query5	4895	634	475	475
query6	320	224	200	200
query7	3991	517	290	290
query8	274	233	225	225
query9	8512	2613	2625	2613
query10	510	332	289	289
query11	15150	15113	14824	14824
query12	161	111	112	111
query13	1563	553	401	401
query14	9095	6399	6239	6239
query15	207	197	174	174
query16	7580	658	470	470
query17	1158	783	658	658
query18	2067	430	348	348
query19	205	201	205	201
query20	124	127	118	118
query21	225	143	123	123
query22	4400	4402	4366	4366
query23	34678	33720	33635	33635
query24	8648	2479	2431	2431
query25	498	469	409	409
query26	1167	277	164	164
query27	2807	516	349	349
query28	4736	2154	2163	2154
query29	706	574	453	453
query30	270	218	188	188
query31	930	869	779	779
query32	72	67	64	64
query33	530	364	353	353
query34	808	882	571	571
query35	800	862	763	763
query36	961	1019	903	903
query37	110	104	75	75
query38	4186	4173	4243	4173
query39	1524	1460	1440	1440
query40	221	115	109	109
query41	77	62	55	55
query42	131	108	109	108
query43	506	504	485	485
query44	1343	857	857	857
query45	183	182	170	170
query46	861	1031	655	655
query47	1876	1878	1819	1819
query48	418	436	350	350
query49	706	503	434	434
query50	660	700	415	415
query51	4274	4242	4196	4196
query52	109	122	102	102
query53	229	257	192	192
query54	578	599	512	512
query55	85	86	90	86
query56	345	319	294	294
query57	1178	1217	1108	1108
query58	269	263	267	263
query59	2713	2701	2651	2651
query60	350	329	305	305
query61	128	120	126	120
query62	773	753	660	660
query63	240	195	191	191
query64	4261	1046	683	683
query65	4350	4274	4193	4193
query66	957	401	295	295
query67	15840	15620	15500	15500
query68	8465	894	533	533
query69	487	359	260	260
query70	1180	1165	1109	1109
query71	468	326	293	293
query72	5590	4801	4892	4801
query73	708	619	363	363
query74	9215	9136	8870	8870
query75	3912	3179	2717	2717
query76	4063	1198	814	814
query77	793	371	299	299
query78	10058	10296	9429	9429
query79	1948	861	590	590
query80	594	522	440	440
query81	479	255	217	217
query82	424	121	104	104
query83	252	252	236	236
query84	251	109	95	95
query85	766	395	338	338
query86	326	311	285	285
query87	4418	4503	4306	4306
query88	3479	2324	2278	2278
query89	392	322	286	286
query90	1933	216	216	216
query91	151	140	113	113
query92	70	61	58	58
query93	1471	967	598	598
query94	667	412	312	312
query95	374	294	315	294
query96	486	614	286	286
query97	2711	2754	2647	2647
query98	237	207	208	207
query99	1447	1405	1290	1290
Total cold run time: 279777 ms
Total hot run time: 193493 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 211790a61cb62a97900ff5338539798870e33a01, data reload: false

query1	0.04	0.05	0.03
query2	0.12	0.10	0.10
query3	0.27	0.20	0.19
query4	1.60	0.19	0.11
query5	0.46	0.42	0.42
query6	1.16	0.66	0.66
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.59	0.51	0.51
query10	0.56	0.59	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.60	0.61
query14	0.80	0.80	0.82
query15	0.89	0.86	0.86
query16	0.38	0.37	0.38
query17	1.04	1.08	1.02
query18	0.22	0.20	0.20
query19	1.90	1.86	1.81
query20	0.01	0.01	0.02
query21	15.39	0.89	0.55
query22	0.77	1.25	0.70
query23	14.78	1.39	0.65
query24	7.31	0.74	1.33
query25	0.50	0.19	0.19
query26	0.58	0.16	0.14
query27	0.05	0.05	0.04
query28	9.54	0.89	0.44
query29	12.56	4.16	3.48
query30	0.25	0.09	0.07
query31	2.82	0.59	0.38
query32	3.23	0.55	0.47
query33	3.15	3.11	3.16
query34	15.92	5.15	4.51
query35	4.56	4.52	4.51
query36	0.68	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.02	0.02
query40	0.16	0.15	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 103.63 s
Total hot run time: 29.3 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 59.62% (62/104) 🎉
Increment coverage report
Complete coverage report

@yx-keith
Copy link
Contributor Author

yx-keith commented Jun 9, 2025

run p0

@yx-keith
Copy link
Contributor Author

yx-keith commented Jun 9, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33912 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 17d9e845de5ff29df86c0c04f563df096dcbfd44, data reload: false

------ Round 1 ----------------------------------
q1	25967	5151	4967	4967
q2	1942	285	188	188
q3	10292	1291	726	726
q4	10247	1003	545	545
q5	8292	2453	2352	2352
q6	280	159	133	133
q7	934	753	608	608
q8	9330	1317	1048	1048
q9	6889	5088	5111	5088
q10	6825	2352	1894	1894
q11	475	294	284	284
q12	349	360	214	214
q13	17774	3671	3098	3098
q14	229	228	217	217
q15	568	488	500	488
q16	417	438	372	372
q17	598	881	359	359
q18	7735	7206	7152	7152
q19	1304	950	570	570
q20	343	344	230	230
q21	3736	3201	2410	2410
q22	1080	1048	969	969
Total cold run time: 115606 ms
Total hot run time: 33912 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5056	5032	5048	5032
q2	234	321	224	224
q3	2163	2645	2365	2365
q4	1367	1786	1376	1376
q5	4584	4412	4412	4412
q6	214	170	127	127
q7	1925	1979	1740	1740
q8	2573	2502	2460	2460
q9	7173	7094	7073	7073
q10	2984	3163	2729	2729
q11	587	504	501	501
q12	678	762	586	586
q13	3561	3900	3244	3244
q14	282	305	295	295
q15	513	479	469	469
q16	463	481	461	461
q17	1136	1464	1427	1427
q18	7784	7438	7340	7340
q19	814	832	933	832
q20	1963	2016	1847	1847
q21	4818	4337	4274	4274
q22	1066	1021	995	995
Total cold run time: 51938 ms
Total hot run time: 49809 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186007 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 17d9e845de5ff29df86c0c04f563df096dcbfd44, data reload: false

query1	1000	482	483	482
query2	6573	1836	1799	1799
query3	6745	237	217	217
query4	26531	23421	23652	23421
query5	4366	645	485	485
query6	290	215	191	191
query7	4623	511	302	302
query8	272	242	211	211
query9	8633	2603	2634	2603
query10	464	322	272	272
query11	15712	15046	14916	14916
query12	162	114	114	114
query13	1662	551	414	414
query14	9258	6288	6157	6157
query15	203	194	171	171
query16	7165	611	473	473
query17	1181	739	549	549
query18	1972	388	291	291
query19	186	188	154	154
query20	117	127	119	119
query21	212	122	104	104
query22	3939	4017	4041	4017
query23	33983	33228	33200	33200
query24	8424	2393	2432	2393
query25	532	461	395	395
query26	1228	277	153	153
query27	2757	504	359	359
query28	4344	2130	2110	2110
query29	795	574	440	440
query30	288	209	191	191
query31	959	836	777	777
query32	71	69	64	64
query33	554	368	311	311
query34	801	850	531	531
query35	783	790	727	727
query36	946	968	876	876
query37	109	99	81	81
query38	4134	4083	4084	4083
query39	1500	1456	1405	1405
query40	220	121	105	105
query41	67	60	61	60
query42	122	113	109	109
query43	497	520	488	488
query44	1353	848	829	829
query45	175	175	171	171
query46	870	1032	632	632
query47	1769	1762	1720	1720
query48	412	465	320	320
query49	748	478	429	429
query50	674	688	418	418
query51	4042	4219	4078	4078
query52	114	102	97	97
query53	226	253	188	188
query54	582	575	506	506
query55	87	91	89	89
query56	347	327	308	308
query57	1151	1146	1094	1094
query58	272	289	248	248
query59	2615	2671	2612	2612
query60	329	317	323	317
query61	127	125	126	125
query62	799	726	640	640
query63	228	190	191	190
query64	4399	1028	677	677
query65	4266	4179	4189	4179
query66	1161	411	315	315
query67	15827	15816	15375	15375
query68	7845	892	534	534
query69	479	309	271	271
query70	1171	1118	1075	1075
query71	499	322	302	302
query72	5549	4723	4760	4723
query73	645	617	357	357
query74	8848	8988	8660	8660
query75	3411	3180	2716	2716
query76	3251	1206	767	767
query77	540	382	294	294
query78	9919	10135	9189	9189
query79	2011	830	579	579
query80	583	527	461	461
query81	467	262	213	213
query82	421	126	93	93
query83	256	251	231	231
query84	242	114	92	92
query85	842	354	312	312
query86	335	304	308	304
query87	4462	4435	4352	4352
query88	3526	2297	2277	2277
query89	387	315	287	287
query90	1910	219	215	215
query91	144	151	107	107
query92	77	59	58	58
query93	1284	926	602	602
query94	695	410	303	303
query95	378	300	290	290
query96	497	583	287	287
query97	2714	2800	2701	2701
query98	248	204	204	204
query99	1387	1383	1274	1274
Total cold run time: 271976 ms
Total hot run time: 186007 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.25 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 17d9e845de5ff29df86c0c04f563df096dcbfd44, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.11
query3	0.26	0.20	0.20
query4	1.59	0.19	0.19
query5	0.46	0.47	0.44
query6	1.19	0.67	0.64
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.60	0.52	0.52
query10	0.58	0.58	0.57
query11	0.15	0.10	0.11
query12	0.14	0.12	0.11
query13	0.61	0.59	0.59
query14	0.78	0.81	0.80
query15	0.88	0.86	0.85
query16	0.37	0.39	0.38
query17	1.04	1.01	1.04
query18	0.22	0.20	0.22
query19	1.92	1.83	1.82
query20	0.01	0.01	0.02
query21	15.43	0.88	0.54
query22	0.74	1.21	0.65
query23	14.90	1.40	0.62
query24	6.97	0.88	0.78
query25	0.49	0.22	0.15
query26	0.68	0.15	0.13
query27	0.05	0.05	0.05
query28	9.12	0.91	0.45
query29	12.57	4.08	3.45
query30	0.25	0.09	0.06
query31	2.81	0.61	0.39
query32	3.24	0.55	0.47
query33	3.15	3.08	3.07
query34	15.85	5.08	4.51
query35	4.52	4.58	4.51
query36	0.67	0.50	0.49
query37	0.09	0.06	0.06
query38	0.05	0.05	0.04
query39	0.03	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 102.95 s
Total hot run time: 29.25 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 10, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 8192445 into apache:master Jun 10, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants