Skip to content

branch-3.0: [fix](transaction) limit abort txn reason to avoid value length exceeds limit error #50152#50208

Merged
dataroaring merged 1 commit intobranch-3.0from
auto-pick-50152-branch-3.0
Apr 22, 2025
Merged

branch-3.0: [fix](transaction) limit abort txn reason to avoid value length exceeds limit error #50152#50208
dataroaring merged 1 commit intobranch-3.0from
auto-pick-50152-branch-3.0

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 21, 2025

Cherry-picked from #50152

@sollhui
[fix](transaction) limit abort txn reason to avoid value length excee…
2132d1a 
…ds limit error (#50152)

### What problem does this PR solve?

Abort transaction fail:
```
W20250414 13:59:36.871497 2527221 txn_kv.cpp:543] fdb commit error, code=2103 msg=Value length exceeds limit
I20250414 13:59:36.871556 2527221 meta_service_helper.h:156] finish abort_txn from 10.5.25.196:59646 response=status { code: INVALID_ARGUMENT msg: "failed to commit kv txn, txn_id=78993731163591680 err=Value length exceeds limit" }
```

root cause is abort reason is too long, this pr limits abort reason to
avoid value length exceeds limit error.
@github-actions github-actions bot requested a review from dataroaring as a code owner April 21, 2025 02:19
@Thearas
Copy link
Contributor

Thearas commented Apr 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 21, 2025
@Thearas
Copy link
Contributor

Thearas commented Apr 21, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 21, 2025

TPC-H: Total hot run time: 39974 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2132d1ad0b985efb3a8903a4c900d7812d55fcc2, data reload: false

------ Round 1 ----------------------------------
q1	17596	6734	6626	6626
q2	2048	175	162	162
q3	10748	1088	1208	1088
q4	10565	775	739	739
q5	7748	2864	2796	2796
q6	214	132	131	131
q7	958	612	602	602
q8	9353	1918	2019	1918
q9	6590	6402	6406	6402
q10	7053	2232	2304	2232
q11	461	259	267	259
q12	398	214	211	211
q13	17786	2969	3003	2969
q14	231	205	208	205
q15	513	452	472	452
q16	672	587	601	587
q17	966	620	542	542
q18	7190	6682	6607	6607
q19	1471	1099	1045	1045
q20	468	201	200	200
q21	3944	3270	3214	3214
q22	1111	989	987	987
Total cold run time: 108084 ms
Total hot run time: 39974 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6581	6594	6572	6572
q2	329	227	226	226
q3	2879	2710	2831	2710
q4	2002	1814	1770	1770
q5	5755	5727	5738	5727
q6	206	126	125	125
q7	2264	1789	1832	1789
q8	3400	3583	3523	3523
q9	8909	8744	8901	8744
q10	3548	3483	3526	3483
q11	604	505	494	494
q12	826	629	605	605
q13	11252	3157	3144	3144
q14	294	270	272	270
q15	509	466	464	464
q16	704	657	666	657
q17	1844	1627	1599	1599
q18	8278	7652	7778	7652
q19	1674	1600	1531	1531
q20	2059	1860	1853	1853
q21	5445	5405	5398	5398
q22	1135	1045	1032	1032
Total cold run time: 70497 ms
Total hot run time: 59368 ms

@doris-robot
Copy link

doris-robot commented Apr 21, 2025

TPC-DS: Total hot run time: 197303 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2132d1ad0b985efb3a8903a4c900d7812d55fcc2, data reload: false

query1	1290	904	906	904
query2	6239	1963	2001	1963
query3	10936	4474	4375	4375
query4	61140	28953	23894	23894
query5	5163	462	445	445
query6	390	175	168	168
query7	5481	320	317	317
query8	299	215	207	207
query9	8544	2614	2576	2576
query10	463	290	262	262
query11	17580	15249	16159	15249
query12	164	105	103	103
query13	1438	466	422	422
query14	10571	7087	7234	7087
query15	199	184	181	181
query16	7090	535	513	513
query17	1121	566	568	566
query18	1819	323	305	305
query19	218	153	149	149
query20	113	106	104	104
query21	211	105	104	104
query22	4675	4552	4648	4552
query23	34375	33761	33894	33761
query24	6118	2961	2909	2909
query25	530	412	426	412
query26	665	175	173	173
query27	1814	363	363	363
query28	4139	2503	2427	2427
query29	714	458	462	458
query30	247	172	162	162
query31	989	800	844	800
query32	70	58	56	56
query33	485	295	320	295
query34	889	519	512	512
query35	871	723	733	723
query36	1087	977	955	955
query37	115	77	77	77
query38	3998	3923	3900	3900
query39	1519	1475	1478	1475
query40	212	103	106	103
query41	52	51	51	51
query42	120	101	100	100
query43	534	480	489	480
query44	1175	817	817	817
query45	190	167	176	167
query46	1130	734	733	733
query47	2060	1904	1957	1904
query48	474	390	395	390
query49	741	426	420	420
query50	858	425	436	425
query51	7223	7329	7159	7159
query52	102	94	90	90
query53	267	192	192	192
query54	591	487	480	480
query55	80	75	74	74
query56	269	244	243	243
query57	1269	1137	1186	1137
query58	225	207	234	207
query59	3223	3121	3087	3087
query60	305	254	252	252
query61	110	107	109	107
query62	781	674	717	674
query63	212	189	186	186
query64	1387	670	640	640
query65	3322	3212	3160	3160
query66	710	309	296	296
query67	16077	15714	15382	15382
query68	4332	577	571	571
query69	435	267	266	266
query70	1172	1068	1111	1068
query71	348	267	252	252
query72	6319	4219	4018	4018
query73	743	345	365	345
query74	10144	9007	9024	9007
query75	3353	2644	2675	2644
query76	2081	1009	1133	1009
query77	523	265	263	263
query78	10557	9605	9532	9532
query79	1932	607	590	590
query80	1283	420	426	420
query81	531	245	234	234
query82	642	86	87	86
query83	159	149	142	142
query84	279	79	81	79
query85	956	296	301	296
query86	372	308	300	300
query87	4388	4269	4276	4269
query88	4165	2403	2381	2381
query89	414	297	294	294
query90	1986	184	185	184
query91	174	151	148	148
query92	61	49	50	49
query93	2345	563	563	563
query94	787	299	316	299
query95	360	254	255	254
query96	627	285	281	281
query97	3342	3152	3116	3116
query98	216	203	201	201
query99	1555	1303	1282	1282
Total cold run time: 314049 ms
Total hot run time: 197303 ms

@doris-robot
Copy link

doris-robot commented Apr 21, 2025

ClickBench: Total hot run time: 32.92 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2132d1ad0b985efb3a8903a4c900d7812d55fcc2, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.11	0.11
query5	0.53	0.49	0.51
query6	1.15	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.05
query9	0.57	0.51	0.49
query10	0.56	0.55	0.56
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.61	0.62	0.60
query14	2.75	2.86	2.71
query15	0.88	0.83	0.83
query16	0.38	0.38	0.41
query17	1.01	1.06	1.06
query18	0.24	0.22	0.22
query19	1.98	1.89	2.02
query20	0.01	0.01	0.02
query21	15.36	0.59	0.60
query22	2.47	2.33	1.71
query23	16.92	1.03	0.94
query24	3.57	1.61	1.57
query25	0.31	0.18	0.09
query26	0.48	0.15	0.13
query27	0.04	0.04	0.03
query28	8.92	0.55	0.45
query29	12.58	3.20	3.22
query30	0.24	0.06	0.06
query31	2.88	0.39	0.38
query32	3.25	0.46	0.46
query33	2.97	3.02	3.01
query34	17.06	4.52	4.52
query35	4.56	4.57	4.54
query36	0.67	0.49	0.47
query37	0.09	0.07	0.06
query38	0.05	0.03	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 105.74 s
Total hot run time: 32.92 s

dataroaring
dataroaring approved these changes Apr 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 22, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 22, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 0e8cfbd into branch-3.0 Apr 22, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-50152-branch-3.0 branch April 22, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas @doris-robot @dataroaring @sollhui