Skip to content

Conversation

@zclllyybb
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

Forbid create dynamic partition with non-datelike partition column

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@zclllyybb
Copy link
Contributor Author

run buildall

@Thearas
Copy link
Contributor

Thearas commented Apr 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

TPC-H: Total hot run time: 33953 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7d8bff83f56135c2a671508d9b56b764eed83f52, data reload: false

------ Round 1 ----------------------------------
q1	26242	5077	5295	5077
q2	2093	295	183	183
q3	10377	1249	742	742
q4	10234	1006	529	529
q5	7550	2327	2338	2327
q6	187	167	132	132
q7	901	726	639	639
q8	9303	1205	1034	1034
q9	6732	5124	5054	5054
q10	6812	2293	1873	1873
q11	480	284	259	259
q12	338	355	220	220
q13	17777	3679	3096	3096
q14	230	239	210	210
q15	542	494	495	494
q16	446	448	401	401
q17	582	853	364	364
q18	7636	7281	7205	7205
q19	1073	943	546	546
q20	338	365	225	225
q21	4108	2677	2400	2400
q22	1035	1032	943	943
Total cold run time: 115016 ms
Total hot run time: 33953 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5097	5024	5143	5024
q2	241	326	233	233
q3	2150	2640	2301	2301
q4	1414	1825	1382	1382
q5	4496	4457	4391	4391
q6	210	164	128	128
q7	1943	1901	1753	1753
q8	2620	2488	2454	2454
q9	7169	7081	7152	7081
q10	2979	3176	2794	2794
q11	582	503	486	486
q12	668	809	623	623
q13	3525	3949	3316	3316
q14	283	295	290	290
q15	515	469	464	464
q16	466	506	460	460
q17	1152	1537	1401	1401
q18	7696	7539	7388	7388
q19	810	801	872	801
q20	1994	2044	1853	1853
q21	5237	4657	4721	4657
q22	1049	1005	1009	1005
Total cold run time: 52296 ms
Total hot run time: 50285 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185511 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7d8bff83f56135c2a671508d9b56b764eed83f52, data reload: false

query1	1005	491	511	491
query2	6552	1784	1774	1774
query3	6745	229	219	219
query4	27065	23372	23058	23058
query5	4334	640	471	471
query6	317	209	208	208
query7	4631	487	284	284
query8	299	236	237	236
query9	8634	2567	2579	2567
query10	491	331	276	276
query11	15272	15074	14792	14792
query12	155	108	103	103
query13	1638	496	392	392
query14	9281	6124	6169	6124
query15	200	182	166	166
query16	7229	634	491	491
query17	1198	710	561	561
query18	1948	389	293	293
query19	183	181	156	156
query20	121	117	117	117
query21	207	125	101	101
query22	4120	4368	4130	4130
query23	33837	32853	32859	32853
query24	8458	2403	2391	2391
query25	567	490	419	419
query26	1234	267	159	159
query27	2725	506	329	329
query28	4383	2120	2113	2113
query29	807	584	454	454
query30	282	217	188	188
query31	948	851	775	775
query32	77	68	68	68
query33	582	371	321	321
query34	782	859	518	518
query35	795	830	748	748
query36	953	1006	901	901
query37	120	102	82	82
query38	4199	4182	4049	4049
query39	1510	1414	1411	1411
query40	205	117	103	103
query41	56	54	57	54
query42	125	102	104	102
query43	479	504	485	485
query44	1260	801	800	800
query45	175	173	168	168
query46	820	1075	604	604
query47	1804	1815	1713	1713
query48	368	418	296	296
query49	800	491	431	431
query50	645	681	394	394
query51	4197	4112	4091	4091
query52	108	115	103	103
query53	225	251	190	190
query54	583	577	496	496
query55	87	80	80	80
query56	308	299	286	286
query57	1129	1134	1070	1070
query58	261	248	260	248
query59	2548	2627	2531	2531
query60	327	311	301	301
query61	147	127	127	127
query62	791	726	678	678
query63	227	192	183	183
query64	4415	1033	746	746
query65	4349	4258	4254	4254
query66	1120	410	317	317
query67	15832	15418	15308	15308
query68	8508	890	516	516
query69	460	300	271	271
query70	1197	1156	1138	1138
query71	471	316	292	292
query72	5543	4752	4833	4752
query73	727	648	346	346
query74	9112	9084	8691	8691
query75	3999	3202	2689	2689
query76	3678	1194	778	778
query77	790	378	286	286
query78	9925	10039	9232	9232
query79	2245	816	577	577
query80	616	523	444	444
query81	468	334	225	225
query82	431	126	100	100
query83	283	251	237	237
query84	286	107	86	86
query85	854	362	318	318
query86	340	329	284	284
query87	4370	4438	4318	4318
query88	3416	2203	2219	2203
query89	387	317	290	290
query90	1940	227	219	219
query91	143	139	111	111
query92	73	61	55	55
query93	1488	960	583	583
query94	684	423	306	306
query95	385	296	309	296
query96	485	562	287	287
query97	3182	3257	3138	3138
query98	230	216	216	216
query99	1426	1406	1279	1279
Total cold run time: 275417 ms
Total hot run time: 185511 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.61 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7d8bff83f56135c2a671508d9b56b764eed83f52, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.10
query3	0.25	0.20	0.20
query4	1.59	0.20	0.11
query5	0.56	0.56	0.56
query6	1.19	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.60	0.53	0.51
query10	0.58	0.57	0.57
query11	0.16	0.11	0.12
query12	0.15	0.11	0.11
query13	0.61	0.60	0.60
query14	1.16	1.16	1.21
query15	0.88	0.85	0.87
query16	0.39	0.38	0.39
query17	1.03	1.04	1.03
query18	0.20	0.19	0.19
query19	1.87	1.79	1.76
query20	0.02	0.00	0.01
query21	15.41	0.97	0.55
query22	0.76	1.29	0.68
query23	14.80	1.37	0.64
query24	6.74	1.72	0.84
query25	0.52	0.20	0.14
query26	0.67	0.16	0.14
query27	0.06	0.05	0.05
query28	10.08	0.89	0.44
query29	12.58	4.04	3.36
query30	0.25	0.09	0.06
query31	2.82	0.61	0.40
query32	3.22	0.54	0.47
query33	3.04	3.01	3.01
query34	15.84	5.10	4.52
query35	4.55	4.49	4.50
query36	0.67	0.49	0.48
query37	0.08	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.92 s
Total hot run time: 29.61 s

@zclllyybb
Copy link
Contributor Author

it's useful now

@zclllyybb zclllyybb closed this May 6, 2025
@zclllyybb zclllyybb deleted the add_check_dynamic branch May 6, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants