Skip to content

[chore](cloud) Remove set -eo pipefail when start ms#50679

Merged
gavinchou merged 1 commit intoapache:masterfrom
gavinchou:gavin-fix-start-ms-script
May 8, 2025
Merged

[chore](cloud) Remove set -eo pipefail when start ms#50679
gavinchou merged 1 commit intoapache:masterfrom
gavinchou:gavin-fix-start-ms-script

Conversation

@gavinchou
Copy link
Contributor

@gavinchou gavinchou commented May 7, 2025

It may introduce extra error handling if we set -eo globally

@gavinchou
[chore](cloud) Remove set -eo pipefail when start ms
140c084 
It may introduce extra error handling if we set -eo globally
@hello-stephen
Copy link
Contributor

hello-stephen commented May 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@gavinchou
Copy link
Contributor Author

gavinchou commented May 7, 2025

run buildall

@doris-robot
Copy link

doris-robot commented May 7, 2025

TeamCity cloud ut coverage result:
Function Coverage: 83.17% (1102/1325)
Line Coverage: 66.04% (18496/28008)
Region Coverage: 65.63% (9211/14034)
Branch Coverage: 55.50% (4956/8930)
Coverage Report: http://coverage.selectdb-in.cc/coverage/140c084a3876ed961e58b2749824445920133ada_140c084a3876ed961e58b2749824445920133ada_cloud/report/index.html

dataroaring
dataroaring approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

PR approved by anyone and no changes requested.

@gavinchou gavinchou merged commit 5794f32 into apache:master May 8, 2025
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request May 8, 2025
@gavinchou
[chore](cloud) Remove set -eo pipefail when start ms (#50679)
78db81a 
It may introduce extra error handling if we set -eo globally
@github-actions github-actions bot mentioned this pull request May 8, 2025
Merged
dataroaring pushed a commit that referenced this pull request May 13, 2025
@github-actions @gavinchou
branch-3.0: [chore](cloud) Remove set -eo pipefail when start ms #50679…
03c1235 
… (#50693)

Cherry-picked from #50679

Co-authored-by: Gavin Chou <gavin@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@gavinchou
[chore](cloud) Remove set -eo pipefail when start ms (apache#50679)
999d8a6 
It may introduce extra error handling if we set -eo globally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

@w41ter w41ter Awaiting requested review from w41ter w41ter is a code owner

+1 more reviewer

@yagagagaga yagagagaga yagagagaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gavinchou @hello-stephen @doris-robot @yagagagaga @dataroaring