Skip to content

[bugfix](becore) pipeline core when workload group shutdown#50743

Merged
dataroaring merged 1 commit intoapache:branch-3.0from
yiguolei:branch-3.0
May 9, 2025
Merged

[bugfix](becore) pipeline core when workload group shutdown#50743
dataroaring merged 1 commit intoapache:branch-3.0from
yiguolei:branch-3.0

Conversation

@yiguolei
Copy link
Copy Markdown
Contributor

@yiguolei yiguolei commented May 9, 2025

What problem does this PR solve?

  1. When workload group shutdown, it will shutdown pipeline task scheduler.
  2. In pipelinetask scheduler, it will first call task queue.close, in this method it will deconstruct priority task queue.
  3. But at this time, the pipeline task thread is not stopped.
    So that it will core.
    Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@yiguolei yiguolei requested a review from dataroaring as a code owner May 9, 2025 03:53
@Thearas
Copy link
Copy Markdown
Contributor

Thearas commented May 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei
Copy link
Copy Markdown
Contributor Author

yiguolei commented May 9, 2025

run buildall

@doris-robot
Copy link
Copy Markdown

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.95% (10796/26362)
Line Coverage 31.81% (92172/289762)
Region Coverage 30.88% (47561/154030)
Branch Coverage 27.38% (24375/89014)

Copy link
Copy Markdown
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 7dbec0d into apache:branch-3.0 May 9, 2025
21 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants