[refactor](fe) make timeout unit more clear #50808

yiguolei · 2025-05-12T09:19:12Z

What problem does this PR solve?

timeout unit in FE have different values, sometimes it is Second, sometimes it is milliseconds. We should add the unit info in API and print it in log.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-05-12T09:19:17Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

yiguolei · 2025-05-12T09:19:25Z

run buildall

doris-robot · 2025-05-12T10:11:50Z

TPC-H: Total hot run time: 34726 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit deca6ec1a88b72e7ab02199ac6be0b3a65de14b9, data reload: false

------ Round 1 ----------------------------------
q1	26261	5063	5188	5063
q2	2058	289	198	198
q3	10400	1214	702	702
q4	10850	970	551	551
q5	7554	2404	2251	2251
q6	179	159	134	134
q7	895	739	603	603
q8	9308	1251	1046	1046
q9	6884	5065	5057	5057
q10	6856	2323	1965	1965
q11	496	291	283	283
q12	333	348	210	210
q13	17776	3693	3057	3057
q14	235	230	217	217
q15	540	482	488	482
q16	415	432	377	377
q17	609	838	376	376
q18	7487	7271	7235	7235
q19	1653	937	547	547
q20	327	340	233	233
q21	3860	3379	3176	3176
q22	1038	1039	963	963
Total cold run time: 116014 ms
Total hot run time: 34726 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5098	5069	5005	5005
q2	236	319	228	228
q3	2177	2627	2300	2300
q4	1341	1782	1461	1461
q5	4415	4377	4345	4345
q6	258	170	130	130
q7	1953	1927	1781	1781
q8	2563	2552	2543	2543
q9	7192	7152	6984	6984
q10	2985	3206	2747	2747
q11	574	515	499	499
q12	683	766	624	624
q13	3445	3924	3309	3309
q14	299	302	269	269
q15	530	485	472	472
q16	427	503	447	447
q17	1136	1488	1419	1419
q18	7737	7538	7430	7430
q19	807	793	825	793
q20	1945	1950	1823	1823
q21	5141	4635	4656	4635
q22	1101	1063	1040	1040
Total cold run time: 52043 ms
Total hot run time: 50284 ms

doris-robot · 2025-05-12T10:23:58Z

TPC-DS: Total hot run time: 193447 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit deca6ec1a88b72e7ab02199ac6be0b3a65de14b9, data reload: false

query1	1399	1105	1074	1074
query2	6361	1753	1789	1753
query3	10958	4494	4360	4360
query4	52223	24174	23990	23990
query5	4922	504	451	451
query6	339	212	209	209
query7	4871	498	279	279
query8	299	256	224	224
query9	5158	2669	2654	2654
query10	455	323	263	263
query11	14917	15049	14875	14875
query12	156	111	102	102
query13	1020	504	392	392
query14	10057	6323	6295	6295
query15	217	223	181	181
query16	7058	655	464	464
query17	1097	775	613	613
query18	1562	414	313	313
query19	205	199	173	173
query20	136	141	126	126
query21	248	127	114	114
query22	4363	4417	4257	4257
query23	34249	33610	33598	33598
query24	6498	2409	2408	2408
query25	469	469	407	407
query26	684	281	156	156
query27	2321	521	353	353
query28	2876	2144	2140	2140
query29	581	577	449	449
query30	284	228	190	190
query31	901	885	830	830
query32	71	64	63	63
query33	459	362	323	323
query34	764	856	540	540
query35	804	818	746	746
query36	946	1018	902	902
query37	132	102	78	78
query38	4149	4232	4188	4188
query39	1574	1462	1469	1462
query40	205	120	108	108
query41	55	55	49	49
query42	134	112	112	112
query43	510	512	474	474
query44	1324	830	843	830
query45	185	181	172	172
query46	850	1046	689	689
query47	1863	1890	1783	1783
query48	393	443	320	320
query49	659	519	447	447
query50	668	714	424	424
query51	4244	4224	4260	4224
query52	109	111	98	98
query53	230	261	187	187
query54	592	582	525	525
query55	90	86	87	86
query56	317	318	295	295
query57	1198	1165	1131	1131
query58	274	270	270	270
query59	2691	2781	2599	2599
query60	341	352	334	334
query61	152	152	145	145
query62	738	770	681	681
query63	234	188	184	184
query64	1495	1053	697	697
query65	4391	4243	4225	4225
query66	743	405	301	301
query67	15745	15460	15403	15403
query68	7535	835	508	508
query69	542	307	275	275
query70	1193	1132	1095	1095
query71	491	315	295	295
query72	5575	4733	4611	4611
query73	1486	571	351	351
query74	9044	8854	8746	8746
query75	3878	3247	2726	2726
query76	4236	1192	740	740
query77	641	446	293	293
query78	10129	10308	9271	9271
query79	2028	826	587	587
query80	596	510	452	452
query81	489	250	226	226
query82	468	125	97	97
query83	247	251	237	237
query84	298	95	90	90
query85	842	358	317	317
query86	389	323	333	323
query87	4449	4364	4393	4364
query88	3635	2293	2286	2286
query89	407	319	284	284
query90	1875	209	219	209
query91	167	147	110	110
query92	72	60	56	56
query93	1642	949	580	580
query94	639	373	313	313
query95	378	292	296	292
query96	493	571	281	281
query97	3150	3228	3142	3142
query98	232	207	216	207
query99	1353	1421	1295	1295
Total cold run time: 294812 ms
Total hot run time: 193447 ms

doris-robot · 2025-05-12T10:29:09Z

ClickBench: Total hot run time: 29.82 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit deca6ec1a88b72e7ab02199ac6be0b3a65de14b9, data reload: false

query1	0.04	0.03	0.04
query2	0.12	0.11	0.12
query3	0.26	0.20	0.20
query4	1.59	0.20	0.19
query5	0.60	0.59	0.58
query6	1.18	0.74	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.50
query10	0.56	0.58	0.56
query11	0.16	0.10	0.11
query12	0.14	0.12	0.12
query13	0.61	0.60	0.59
query14	0.78	0.81	0.82
query15	0.88	0.86	0.84
query16	0.39	0.38	0.38
query17	1.05	1.04	1.01
query18	0.23	0.21	0.21
query19	1.92	1.84	1.82
query20	0.02	0.01	0.01
query21	15.40	0.93	0.54
query22	0.76	1.14	0.81
query23	14.85	1.37	0.65
query24	7.00	1.23	1.21
query25	0.46	0.16	0.20
query26	0.65	0.17	0.14
query27	0.05	0.05	0.06
query28	9.90	0.89	0.45
query29	12.52	3.96	3.29
query30	0.27	0.09	0.06
query31	2.82	0.60	0.37
query32	3.23	0.56	0.48
query33	3.10	3.05	3.14
query34	15.77	5.10	4.46
query35	4.52	4.48	4.47
query36	0.68	0.49	0.49
query37	0.08	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.13	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 103.64 s
Total hot run time: 29.82 s

yiguolei · 2025-05-13T00:59:32Z

run buildall

doris-robot · 2025-05-13T07:13:56Z

TPC-H: Total hot run time: 33692 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2e59c929a057a188c1125b5cbe8f6787947123f9, data reload: false

------ Round 1 ----------------------------------
q1	25856	5018	5020	5018
q2	2074	271	175	175
q3	10407	1236	673	673
q4	10203	1003	511	511
q5	7868	2388	2345	2345
q6	177	163	132	132
q7	897	732	610	610
q8	9313	1285	1062	1062
q9	6787	5095	5002	5002
q10	6854	2299	1886	1886
q11	477	281	271	271
q12	332	344	208	208
q13	17784	3703	3142	3142
q14	219	231	210	210
q15	517	479	481	479
q16	430	427	360	360
q17	575	847	360	360
q18	7497	7180	7138	7138
q19	1694	944	555	555
q20	331	330	215	215
q21	4009	2641	2367	2367
q22	1052	1029	973	973
Total cold run time: 115353 ms
Total hot run time: 33692 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5123	5073	5056	5056
q2	230	317	229	229
q3	2143	2646	2273	2273
q4	1339	1779	1376	1376
q5	4356	4351	4451	4351
q6	219	165	127	127
q7	2007	1953	1773	1773
q8	2585	2487	2481	2481
q9	7298	7255	7019	7019
q10	3033	3184	2757	2757
q11	594	512	509	509
q12	677	792	632	632
q13	3509	3878	3284	3284
q14	287	313	289	289
q15	527	488	481	481
q16	436	470	438	438
q17	1148	1546	1367	1367
q18	7652	7493	7528	7493
q19	805	797	853	797
q20	2013	2017	1882	1882
q21	5017	4709	4691	4691
q22	1078	1108	1021	1021
Total cold run time: 52076 ms
Total hot run time: 50326 ms

doris-robot · 2025-05-13T07:26:17Z

TPC-DS: Total hot run time: 193436 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2e59c929a057a188c1125b5cbe8f6787947123f9, data reload: false

query1	1405	1051	1037	1037
query2	6259	1854	1865	1854
query3	11010	4533	4373	4373
query4	53810	25245	22906	22906
query5	5130	605	455	455
query6	336	194	193	193
query7	4888	517	300	300
query8	310	253	241	241
query9	5727	2640	2661	2640
query10	446	328	273	273
query11	15106	15390	14777	14777
query12	158	115	113	113
query13	1054	545	415	415
query14	10152	6352	6338	6338
query15	198	193	172	172
query16	6968	632	474	474
query17	1092	733	634	634
query18	1576	410	312	312
query19	216	214	178	178
query20	133	125	133	125
query21	209	128	113	113
query22	4311	4326	4289	4289
query23	34380	33764	33631	33631
query24	6561	2423	2467	2423
query25	459	467	411	411
query26	675	280	162	162
query27	2202	515	348	348
query28	3045	2178	2176	2176
query29	608	572	455	455
query30	279	218	188	188
query31	869	848	805	805
query32	75	66	60	60
query33	467	362	327	327
query34	769	874	536	536
query35	792	829	768	768
query36	955	1023	907	907
query37	113	96	71	71
query38	4161	4212	4216	4212
query39	1662	1460	1442	1442
query40	208	125	118	118
query41	59	53	51	51
query42	121	113	113	113
query43	505	514	497	497
query44	1315	835	832	832
query45	180	176	165	165
query46	859	1043	679	679
query47	1882	1857	1804	1804
query48	394	429	323	323
query49	686	524	468	468
query50	664	691	414	414
query51	4242	4230	4233	4230
query52	116	106	99	99
query53	224	256	197	197
query54	613	591	534	534
query55	86	85	96	85
query56	334	312	272	272
query57	1171	1210	1142	1142
query58	285	252	257	252
query59	2773	2838	2659	2659
query60	329	333	302	302
query61	127	123	165	123
query62	727	764	663	663
query63	225	190	195	190
query64	1422	1017	725	725
query65	4457	4222	4216	4216
query66	712	407	300	300
query67	16180	15717	15563	15563
query68	6946	832	532	532
query69	528	306	264	264
query70	1202	1119	1105	1105
query71	501	321	293	293
query72	5898	4836	5047	4836
query73	1387	698	355	355
query74	8925	9139	8998	8998
query75	4281	3230	2728	2728
query76	4374	1185	760	760
query77	796	381	270	270
query78	10148	10008	9485	9485
query79	6636	783	573	573
query80	640	517	439	439
query81	492	261	221	221
query82	704	130	95	95
query83	283	252	245	245
query84	351	103	87	87
query85	804	346	309	309
query86	366	290	311	290
query87	4468	4384	4398	4384
query88	3441	2293	2303	2293
query89	470	312	298	298
query90	1975	209	206	206
query91	152	143	114	114
query92	77	60	57	57
query93	3662	917	579	579
query94	670	411	302	302
query95	371	293	284	284
query96	497	573	284	284
query97	3230	3259	3136	3136
query98	246	200	210	200
query99	1442	1433	1264	1264
Total cold run time: 305425 ms
Total hot run time: 193436 ms

doris-robot · 2025-05-13T07:31:28Z

ClickBench: Total hot run time: 28.96 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2e59c929a057a188c1125b5cbe8f6787947123f9, data reload: false

query1	0.03	0.04	0.03
query2	0.12	0.10	0.10
query3	0.25	0.19	0.19
query4	1.60	0.20	0.10
query5	0.55	0.56	0.61
query6	1.18	0.72	0.72
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.58	0.52	0.51
query10	0.57	0.59	0.56
query11	0.16	0.11	0.11
query12	0.14	0.12	0.11
query13	0.61	0.60	0.59
query14	0.78	0.81	0.82
query15	0.87	0.85	0.87
query16	0.38	0.38	0.39
query17	1.07	1.06	1.02
query18	0.22	0.21	0.22
query19	1.94	1.83	1.82
query20	0.02	0.01	0.01
query21	15.43	0.89	0.54
query22	0.76	1.24	0.76
query23	14.79	1.34	0.60
query24	7.06	0.89	0.52
query25	0.45	0.18	0.10
query26	0.56	0.17	0.14
query27	0.05	0.05	0.06
query28	9.06	0.87	0.44
query29	12.55	3.86	3.33
query30	0.25	0.10	0.07
query31	2.81	0.60	0.38
query32	3.24	0.55	0.48
query33	3.07	3.11	3.04
query34	15.72	5.12	4.52
query35	4.48	4.47	4.47
query36	0.68	0.50	0.48
query37	0.08	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.18	0.12	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 102.6 s
Total hot run time: 28.96 s

github-actions · 2025-05-13T09:35:15Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-05-13T09:35:18Z

PR approved by anyone and no changes requested.

zhiqiang-hhhh

LGTM

zhiqiang-hhhh · 2025-05-13T12:58:31Z

...e/src/main/java/org/apache/doris/nereids/trees/plans/commands/insert/OlapInsertExecutor.java

@@ -306,7 +306,7 @@ protected void setReturnInfo() {
    }

    public long getTimeout() {


maybe getTimeOutS()

### What problem does this PR solve? timeout unit in FE have different values, sometimes it is Second, sometimes it is milliseconds. We should add the unit info in API and print it in log.

yiguolei requested review from dataroaring, gavinchou and w41ter as code owners May 12, 2025 09:19

yiguolei added 3 commits May 13, 2025 08:58

f

e2617e3

f

593a81a

f

2e59c92

yiguolei force-pushed the rf_timeout branch from deca6ec to 2e59c92 Compare May 13, 2025 00:58

gavinchou approved these changes May 13, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label May 13, 2025

github-actions bot added the reviewed label May 13, 2025

zhiqiang-hhhh approved these changes May 13, 2025

View reviewed changes

yiguolei merged commit 246634c into apache:master May 13, 2025
26 of 27 checks passed

		@@ -306,7 +306,7 @@ protected void setReturnInfo() {
		}

		public long getTimeout() {

[refactor](fe) make timeout unit more clear #50808

[refactor](fe) make timeout unit more clear #50808

Uh oh!

Conversation

yiguolei commented May 12, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented May 12, 2025

Uh oh!

yiguolei commented May 12, 2025

Uh oh!

doris-robot commented May 12, 2025

Uh oh!

doris-robot commented May 12, 2025

Uh oh!

doris-robot commented May 12, 2025

Uh oh!

yiguolei commented May 13, 2025

Uh oh!

doris-robot commented May 13, 2025

Uh oh!

doris-robot commented May 13, 2025

Uh oh!

doris-robot commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

github-actions bot commented May 13, 2025

Uh oh!

zhiqiang-hhhh left a comment

Choose a reason for hiding this comment

Uh oh!

zhiqiang-hhhh May 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants