Skip to content

[fix](nereids) fix bugs in PushDownAggThroughJoin#50846

Closed
englefly wants to merge 1 commit intoapache:masterfrom
englefly:agg-push-bug-fix
Closed

[fix](nereids) fix bugs in PushDownAggThroughJoin#50846
englefly wants to merge 1 commit intoapache:masterfrom
englefly:agg-push-bug-fix

Conversation

@englefly
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx
bug1. type conversion bug. the Multiply instance created by this rule should do type conversion,
bug2. plan pattern check bug. for pattern: Agg->project->join, join's children should not be logical agg.

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented May 13, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly englefly marked this pull request as draft May 13, 2025 08:07
@englefly englefly closed this May 13, 2025
@englefly englefly deleted the agg-push-bug-fix branch June 24, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants