Skip to content

[fix](docker case) Fix some docker case due to defined global variables in script are not allowed #50976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gavinchou merged 2 commits into from
May 22, 2025
Merged

[fix](docker case) Fix some docker case due to defined global variables in script are not allowed #50976

gavinchou merged 2 commits into from
May 22, 2025

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented May 16, 2025

…les in script are not allowed`

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented May 16, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

dataroaring
dataroaring previously approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 16, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 16, 2025
@deardeng
Copy link
Contributor Author

deardeng commented May 16, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2025

PR approved by at least one committer and no changes requested.

@gavinchou gavinchou changed the title [fix](docker case) Fix some docker case due to `defined global variab… [fix](docker case) Fix some docker case due to defined global variables in script are not allowed May 22, 2025
@gavinchou gavinchou merged commit 29cb291 into apache:master May 22, 2025
25 of 27 checks passed
github-actions bot pushed a commit that referenced this pull request May 22, 2025
@deardeng
[fix](docker case) Fix some docker case due to `defined global variab…
2b39f23 
…les in script are not allowed` (#50976)
@github-actions github-actions bot mentioned this pull request May 22, 2025
Merged
dataroaring pushed a commit that referenced this pull request May 24, 2025
@github-actions @deardeng
branch-3.0: [fix](docker case) Fix some docker case due to `defined g…
93b11c7 
…lobal variables in script are not allowed` #50976 (#51167)

Cherry-picked from #50976

Co-authored-by: deardeng <dengxin@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@deardeng
[fix](docker case) Fix some docker case due to `defined global variab…
0d9d5fc 
…les in script are not allowed` (apache#50976)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@hello-stephen hello-stephen hello-stephen approved these changes

@dataroaring dataroaring dataroaring left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.6-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@deardeng @hello-stephen @gavinchou @dataroaring