[feat](params-refactor) restructure parameters for FS V2 integration #51177
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
| // This file is copied from | ||
| // https://github.com/trinodb/trino/blob/438/plugin/trino-hive/src/main/java/io/trino/plugin/hive/fs/DirectoryLister.java | ||
| // and modified by Doris | ||
|
|
||
| package org.apache.doris.fsv2; | ||
|
|
||
| import org.apache.doris.catalog.TableIf; | ||
| import org.apache.doris.fsv2.remote.RemoteFile; | ||
|
|
||
| public interface DirectoryLister { | ||
| RemoteIterator<RemoteFile> listFiles(FileSystem fs, boolean recursive, TableIf table, String location) | ||
| throws FileSystemIOException; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,117 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.fsv2; | ||
|
|
||
| import org.apache.doris.common.CacheFactory; | ||
| import org.apache.doris.common.Config; | ||
| import org.apache.doris.common.Pair; | ||
| import org.apache.doris.common.UserException; | ||
| import org.apache.doris.fsv2.remote.RemoteFileSystem; | ||
|
|
||
| import com.github.benmanes.caffeine.cache.LoadingCache; | ||
| import org.apache.hadoop.conf.Configuration; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.Objects; | ||
| import java.util.OptionalLong; | ||
|
|
||
| public class FileSystemCache { | ||
|
|
||
| private final LoadingCache<FileSystemCacheKey, RemoteFileSystem> fileSystemCache; | ||
|
|
||
| public FileSystemCache() { | ||
| // no need to set refreshAfterWrite, because the FileSystem is created once and never changed | ||
| CacheFactory fsCacheFactory = new CacheFactory( | ||
| OptionalLong.of(86400L), | ||
| OptionalLong.empty(), | ||
| Config.max_remote_file_system_cache_num, | ||
| false, | ||
| null); | ||
| fileSystemCache = fsCacheFactory.buildCache(this::loadFileSystem); | ||
| } | ||
|
|
||
| private RemoteFileSystem loadFileSystem(FileSystemCacheKey key) throws UserException { | ||
| return FileSystemFactory.get(key.type, key.getFsProperties(), key.bindBrokerName); | ||
| } | ||
|
|
||
| public RemoteFileSystem getRemoteFileSystem(FileSystemCacheKey key) { | ||
| return fileSystemCache.get(key); | ||
| } | ||
|
|
||
| public static class FileSystemCacheKey { | ||
| private final FileSystemType type; | ||
| // eg: hdfs://nameservices1 | ||
| private final String fsIdent; | ||
| private final Map<String, String> properties; | ||
| private final String bindBrokerName; | ||
| // only for creating new file system | ||
| private final Configuration conf; | ||
|
|
||
| public FileSystemCacheKey(Pair<FileSystemType, String> fs, | ||
| Map<String, String> properties, | ||
| String bindBrokerName, | ||
| Configuration conf) { | ||
| this.type = fs.first; | ||
| this.fsIdent = fs.second; | ||
| this.properties = properties; | ||
| this.bindBrokerName = bindBrokerName; | ||
| this.conf = conf; | ||
| } | ||
|
|
||
| public FileSystemCacheKey(Pair<FileSystemType, String> fs, | ||
| Map<String, String> properties, String bindBrokerName) { | ||
| this(fs, properties, bindBrokerName, null); | ||
| } | ||
|
|
||
| public Map<String, String> getFsProperties() { | ||
| if (conf == null) { | ||
| return properties; | ||
| } | ||
| Map<String, String> result = new HashMap<>(); | ||
| conf.iterator().forEachRemaining(e -> result.put(e.getKey(), e.getValue())); | ||
| return result; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object obj) { | ||
| if (this == obj) { | ||
| return true; | ||
| } | ||
| if (!(obj instanceof FileSystemCacheKey)) { | ||
| return false; | ||
| } | ||
| FileSystemCacheKey o = (FileSystemCacheKey) obj; | ||
| boolean equalsWithoutBroker = type.equals(o.type) | ||
| && fsIdent.equals(o.fsIdent) | ||
| && properties.equals(o.properties); | ||
| if (bindBrokerName == null) { | ||
| return equalsWithoutBroker && o.bindBrokerName == null; | ||
| } | ||
| return equalsWithoutBroker && bindBrokerName.equals(o.bindBrokerName); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| if (bindBrokerName == null) { | ||
| return Objects.hash(properties, fsIdent, type); | ||
| } | ||
| return Objects.hash(properties, fsIdent, type, bindBrokerName); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.fsv2; | ||
|
|
||
| import org.apache.doris.backup.Status; | ||
| import org.apache.doris.catalog.TableIf; | ||
| import org.apache.doris.fsv2.remote.RemoteFile; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| public class FileSystemDirectoryLister implements DirectoryLister { | ||
| public RemoteIterator<RemoteFile> listFiles(FileSystem fs, boolean recursive, TableIf table, String location) | ||
| throws FileSystemIOException { | ||
| List<RemoteFile> result = new ArrayList<>(); | ||
| Status status = fs.listFiles(location, recursive, result); | ||
| if (!status.ok()) { | ||
| throw new FileSystemIOException(status.getErrCode(), status.getErrMsg()); | ||
| } | ||
| return new RemoteFileRemoteIterator(result); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still using a raw map?