Skip to content

Conversation

@ChenMiaoi
Copy link
Contributor

What problem does this PR solve?

Related PR: #44400

Problem Summary:

  • changed approx_top_sum, corr, percentile and rpc
  • add safe_arithmetic functions to coper with it

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…e functions.

    - changed approx_top_sum, corr, percentile and rpc
    - add safe_arithmetic functions to coper with it
@Thearas
Copy link
Contributor

Thearas commented Jun 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@ChenMiaoi
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 60.98% (25/41) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.03% (15368/26948)
Line Coverage 46.12% (139435/302358)
Region Coverage 45.44% (70627/155446)
Branch Coverage 40.19% (37300/92810)

@github-actions
Copy link
Contributor

We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Dec 25, 2025
@github-actions github-actions bot closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants