-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[bugfix](socket) Fix "Broken pipe" error due to returning disconnected clients to connection pool #51944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34652 ms |
TPC-DS: Total hot run time: 185114 ms |
ClickBench: Total hot run time: 29.51 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
xy720
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
We're closing this PR because it hasn't been updated in a while. |
What problem does this PR solve?
Issue Number: close #51941
Related PR: #xxx
Problem Summary:
Every time an FE node restarts, the following exception keeps appearing.
The root cause is that the client fails to catch IO exceptions, leading to closed connections being returned to the pool. Additionally, the isOpen() validation method in the code relies on isConnected(), which cannot detect closed or broken connections.
This pull request examines and resolves all related issues.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)