Skip to content

Conversation

@englefly
Copy link
Contributor

pick #46401

What problem does this PR solve?

logicalProperties.datatrait is not only used by LogicalPlan, it is also used in postprocessor, especially used in RuntimeFilterGeneration. T1 join T2 on T1.a=T2.a where T1.a=1 and T2.a=1
Because both T1.a and T2.a are unique value "1", the RF: T1.a->T2.a is useless

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

…pache#46401)

### What problem does this PR solve?
logicalProperties.datatrait is not only used by LogicalPlan, it is also
used in postprocessor, especially used in RuntimeFilterGeneration.
T1 join T2 on T1.a=T2.a where T1.a=1 and T2.a=1
Because both T1.a and T2.a are unique value "1", the RF: T1.a->T2.a is
useless
@englefly englefly requested a review from morrySnow as a code owner June 20, 2025 07:29
@englefly
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow
Copy link
Contributor

dup with #51973

@morrySnow morrySnow closed this Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants