-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids) fix calc repeat property stack overflow #52159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
morrySnow
merged 3 commits into
apache:master
from
yujun777:fix-calc-repeat-property-stack-overflow
Jun 24, 2025
Merged
[fix](nereids) fix calc repeat property stack overflow #52159
morrySnow
merged 3 commits into
apache:master
from
yujun777:fix-calc-repeat-property-stack-overflow
Jun 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33874 ms |
TPC-DS: Total hot run time: 185625 ms |
ClickBench: Total hot run time: 29.91 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33571 ms |
TPC-DS: Total hot run time: 185912 ms |
ClickBench: Total hot run time: 29.4 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
morrySnow
approved these changes
Jun 24, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
924060929
approved these changes
Jun 24, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
### What problem does this PR solve?
Guava Sets.intersection will return a SetView, then for chain call
Sets.intersection like below code:
List<Set<>> B;
Set<> A = B.get(0);
for (int i = 1; i < B.size(); i++) {
A = Sets.intersection(A, B.get(i));
}
Then A is a recursive SetViews, A = SetView(SetView(SetView(B0 interset
B1) interset B2) ... interset Bn).
Then when access A, it will call recursive deeply the multiple SetView's
relate functions.
For example, when call A.isEmpty(), its call stack will be like
java.lang.StackOverflowError: null
at com.google.common.collect.Sets$2$1.computeNext(Sets.java:838) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:140) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.Sets$2$1.computeNext(Sets.java:838) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:140) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.Sets$2$1.computeNext(Sets.java:838) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:140) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.Sets$2$1.computeNext(Sets.java:838) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145) ~[guava-33.2.1-jre.jar:?]
...
if the stack is deep, it then throw StackOverflowError.
So for the long chain set intersection, need to eliminate the SetView,
and convert it to a Set.
github-actions bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
### What problem does this PR solve?
Guava Sets.intersection will return a SetView, then for chain call
Sets.intersection like below code:
List<Set<>> B;
Set<> A = B.get(0);
for (int i = 1; i < B.size(); i++) {
A = Sets.intersection(A, B.get(i));
}
Then A is a recursive SetViews, A = SetView(SetView(SetView(B0 interset
B1) interset B2) ... interset Bn).
Then when access A, it will call recursive deeply the multiple SetView's
relate functions.
For example, when call A.isEmpty(), its call stack will be like
java.lang.StackOverflowError: null
at com.google.common.collect.Sets$2$1.computeNext(Sets.java:838) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:140) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.Sets$2$1.computeNext(Sets.java:838) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:140) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.Sets$2$1.computeNext(Sets.java:838) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:140) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.Sets$2$1.computeNext(Sets.java:838) ~[guava-33.2.1-jre.jar:?]
at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:145) ~[guava-33.2.1-jre.jar:?]
...
if the stack is deep, it then throw StackOverflowError.
So for the long chain set intersection, need to eliminate the SetView,
and convert it to a Set.
morrySnow
pushed a commit
that referenced
this pull request
Jun 24, 2025
dataroaring
pushed a commit
that referenced
this pull request
Jun 25, 2025
yiguolei
pushed a commit
that referenced
this pull request
Jun 28, 2025
Hastyshell
pushed a commit
to Hastyshell/doris
that referenced
this pull request
Jul 30, 2025
…verflow apache#52159 (apache#4190) cherry pick from apache#52159
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Sep 1, 2025
…verflow apache#52159 (apache#4190) cherry pick from apache#52159
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.11-merged
dev/3.0.7-merged
dev/3.1.0-merged
reviewed
usercase
Important user case type label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Guava Sets.intersection will return a SetView, then for chain call Sets.intersection like below code:
Then A is a recursive SetViews, A = SetView(SetView(SetView(B0 interset B1) interset B2) ... interset Bn).
Then when access A, it will call recursive deeply the multiple SetView's relate functions.
For example, when call A.isEmpty(), its call stack will be like
if the stack is deep, it then throw StackOverflowError.
So for the long chain set intersection, need to eliminate the SetView, and convert it to a Set.
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)