Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #51274

### What problem does this PR solve?

The pr fix following two problems:
1. if no broker is set in FE, BE will crashed because of
`broker_addresses[0]`;
2. now one Query only use one Broker, it will make Broker OOM while
query large data;
@github-actions github-actions bot requested a review from morrySnow as a code owner June 24, 2025 03:32
@morrySnow morrySnow closed this Jun 24, 2025
@morrySnow morrySnow reopened this Jun 24, 2025
@morrySnow
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39811 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c6c92174185ad7904028705f0b634c53f883a01f, data reload: false

------ Round 1 ----------------------------------
q1	17601	6670	6605	6605
q2	2056	181	203	181
q3	10637	1059	1206	1059
q4	10540	747	773	747
q5	7795	2854	2875	2854
q6	216	132	132	132
q7	977	629	590	590
q8	9355	1965	2030	1965
q9	6590	6405	6456	6405
q10	7022	2225	2338	2225
q11	462	255	254	254
q12	399	213	204	204
q13	17788	3001	2969	2969
q14	231	204	215	204
q15	517	464	475	464
q16	475	380	368	368
q17	972	559	614	559
q18	7174	6723	6678	6678
q19	1313	1055	1078	1055
q20	462	200	191	191
q21	3894	3181	3127	3127
q22	1088	996	975	975
Total cold run time: 107564 ms
Total hot run time: 39811 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6597	6586	6558	6558
q2	327	230	234	230
q3	2907	2780	2814	2780
q4	2048	1786	1801	1786
q5	5734	5691	5694	5691
q6	205	126	130	126
q7	2165	1782	1799	1782
q8	3384	3527	3539	3527
q9	8884	8799	8925	8799
q10	3579	3491	3466	3466
q11	588	491	471	471
q12	811	597	601	597
q13	9462	3110	3115	3110
q14	302	271	282	271
q15	511	469	460	460
q16	477	428	427	427
q17	1863	1633	1603	1603
q18	8429	8042	7781	7781
q19	1697	1680	1605	1605
q20	2153	1855	1823	1823
q21	5035	5032	4921	4921
q22	1137	1018	1002	1002
Total cold run time: 68295 ms
Total hot run time: 58816 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197509 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c6c92174185ad7904028705f0b634c53f883a01f, data reload: false

query1	1281	920	912	912
query2	6472	1965	1845	1845
query3	10841	4309	4392	4309
query4	60729	28572	23514	23514
query5	5259	460	447	447
query6	421	183	184	183
query7	5523	323	314	314
query8	312	226	235	226
query9	8697	2595	2571	2571
query10	483	259	268	259
query11	18446	15213	15758	15213
query12	169	109	107	107
query13	1539	451	432	432
query14	11070	6751	7488	6751
query15	200	180	175	175
query16	7163	466	463	463
query17	1228	565	570	565
query18	1814	349	301	301
query19	218	152	155	152
query20	119	110	108	108
query21	199	102	112	102
query22	4694	4800	4703	4703
query23	34259	34478	34512	34478
query24	6167	2898	2939	2898
query25	524	392	384	384
query26	640	157	170	157
query27	2225	352	347	347
query28	4352	2167	2169	2167
query29	679	440	442	440
query30	236	154	150	150
query31	974	827	825	825
query32	65	54	57	54
query33	450	304	291	291
query34	924	537	531	531
query35	836	728	731	728
query36	1094	951	975	951
query37	111	65	65	65
query38	4049	3936	4026	3936
query39	1532	1450	1643	1450
query40	195	96	104	96
query41	48	46	51	46
query42	118	105	102	102
query43	539	474	469	469
query44	1196	831	828	828
query45	191	165	167	165
query46	1154	723	725	723
query47	2006	1910	1916	1910
query48	437	352	352	352
query49	726	390	398	390
query50	835	416	435	416
query51	7313	7307	7330	7307
query52	103	101	91	91
query53	258	188	185	185
query54	609	474	472	472
query55	85	77	80	77
query56	278	264	268	264
query57	1344	1208	1202	1202
query58	251	220	220	220
query59	3143	3103	3043	3043
query60	304	267	258	258
query61	134	140	149	140
query62	784	691	698	691
query63	221	192	189	189
query64	1499	750	730	730
query65	3317	3177	3206	3177
query66	727	309	305	305
query67	15990	15815	15623	15623
query68	4324	577	561	561
query69	454	271	303	271
query70	1148	1111	1129	1111
query71	338	256	250	250
query72	6372	4175	4026	4026
query73	747	348	347	347
query74	10519	9258	9252	9252
query75	3338	2618	2641	2618
query76	2001	1112	1044	1044
query77	496	265	286	265
query78	10524	9756	9591	9591
query79	1214	610	593	593
query80	846	419	432	419
query81	490	223	217	217
query82	1259	89	88	88
query83	277	146	139	139
query84	285	83	83	83
query85	876	298	289	289
query86	313	293	274	274
query87	4350	4196	4248	4196
query88	3708	2367	2344	2344
query89	422	292	287	287
query90	2038	184	183	183
query91	136	107	106	106
query92	61	50	52	50
query93	1603	547	553	547
query94	740	286	278	278
query95	350	255	245	245
query96	606	277	277	277
query97	3299	3173	3135	3135
query98	213	199	190	190
query99	1552	1258	1286	1258
Total cold run time: 314698 ms
Total hot run time: 197509 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/35) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.34% (10963/26522)
Line Coverage 32.19% (94213/292635)
Region Coverage 31.27% (48578/155363)
Branch Coverage 27.95% (25077/89730)

@doris-robot
Copy link

ClickBench: Total hot run time: 30.63 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c6c92174185ad7904028705f0b634c53f883a01f, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.04
query3	0.24	0.06	0.06
query4	1.61	0.10	0.10
query5	0.52	0.51	0.53
query6	1.12	0.72	0.73
query7	0.03	0.02	0.01
query8	0.04	0.05	0.04
query9	0.56	0.50	0.49
query10	0.55	0.57	0.54
query11	0.14	0.11	0.10
query12	0.14	0.11	0.10
query13	0.61	0.58	0.59
query14	0.78	0.77	0.82
query15	0.83	0.83	0.82
query16	0.38	0.37	0.38
query17	1.06	1.03	1.05
query18	0.22	0.22	0.21
query19	1.86	1.87	1.88
query20	0.01	0.01	0.01
query21	15.40	0.61	0.58
query22	2.15	2.18	2.56
query23	17.05	0.93	0.82
query24	3.18	1.19	1.39
query25	0.16	0.15	0.11
query26	0.49	0.14	0.14
query27	0.06	0.04	0.04
query28	9.90	0.49	0.46
query29	12.61	3.23	3.27
query30	0.24	0.05	0.06
query31	2.86	0.40	0.38
query32	3.24	0.46	0.45
query33	3.00	2.98	2.96
query34	16.85	4.44	4.45
query35	4.50	4.53	4.45
query36	0.68	0.46	0.49
query37	0.08	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.62 s
Total hot run time: 30.63 s

@morrySnow morrySnow merged commit a01669d into branch-3.1 Jun 24, 2025
21 of 22 checks passed
@github-actions github-actions bot deleted the auto-pick-51274-branch-3.1 branch June 24, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants