Skip to content

branch-3.0: [fix](be) Fix be aws-sdk-cpp memory leak #52185 #52210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jun 24, 2025
Merged

branch-3.0: [fix](be) Fix be aws-sdk-cpp memory leak #52185 #52210

dataroaring merged 1 commit into from
Jun 24, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 24, 2025

Cherry-picked from #52185

@swjtu-zhanglei
[fix](be) Fix be aws-sdk-cpp memory leak (#52185)
a085b84 
* aws/aws-sdk-cpp#2314
* In the aws-sdk-cpp code, there is a suggestion: "Please call
ShutdownAPI from the same thread from which InitAPI() has been called"
otherwise it will cause memory leak.

```
=================================================================
==3271527==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 216 byte(s) in 1 object(s) allocated from:
    #0 0x555f9ecf55ee in malloc (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x370815ee) (BuildId: 22b637395dd039b0)
    #1 0x555fd8e19bd7 in CRYPTO_zalloc (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x711a5bd7) (BuildId: 22b637395dd039b0)
    #2 0x555fda7c9d14 in aws_mqtt_library_init (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x72b55d14) (BuildId: 22b637395dd039b0)
    #3 0x555fda74ed1f in Aws::Crt::ApiHandle::ApiHandle(aws_allocator*) (/mnt/ssd01/pipline/OpenSourceDoris/clusterEnv/P0/Cluster0/be/lib/doris_be+0x72adad1f) (BuildId: 22b637395dd039b0)
    #4 0x555fa365f0c9 in doris::S3ClientFactory::instance() /root/doris/be/src/util/s3_util.cpp:188:28
    #5 0x555f9f13b87b in doris::io::ObjClientHolder::init() /root/doris/be/src/io/fs/s3_file_system.cpp:78:15
    #6 0x555f9f140eee in doris::io::S3FileSystem::init() /root/doris/be/src/io/fs/s3_file_system.cpp:182:21
    ......
```
@github-actions github-actions bot requested a review from dataroaring as a code owner June 24, 2025 08:39
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 24, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 24, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 24, 2025

TPC-H: Total hot run time: 39756 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a085b84631264b69a8db58fc46213a5d08a65f78, data reload: false

------ Round 1 ----------------------------------
q1	17668	6927	6583	6583
q2	2087	174	159	159
q3	10762	1099	1136	1099
q4	10541	762	760	760
q5	7759	2868	2820	2820
q6	212	138	132	132
q7	979	616	605	605
q8	9359	1939	2003	1939
q9	6565	6390	6364	6364
q10	7018	2304	2344	2304
q11	463	271	261	261
q12	402	213	213	213
q13	17781	2984	2966	2966
q14	254	208	214	208
q15	506	456	479	456
q16	463	393	374	374
q17	980	619	564	564
q18	7357	6701	6708	6701
q19	1394	1116	1023	1023
q20	476	211	209	209
q21	3947	3237	3038	3038
q22	1100	978	1004	978
Total cold run time: 108073 ms
Total hot run time: 39756 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6571	6569	6541	6541
q2	332	237	223	223
q3	2940	2756	2879	2756
q4	2053	1798	1745	1745
q5	5778	5741	5711	5711
q6	213	126	123	123
q7	2242	1802	1869	1802
q8	3350	3533	3509	3509
q9	9028	8731	8901	8731
q10	3558	3533	3517	3517
q11	594	485	500	485
q12	789	608	588	588
q13	8947	3284	3139	3139
q14	302	286	272	272
q15	519	470	459	459
q16	485	436	441	436
q17	1824	1612	1618	1612
q18	8289	7745	7630	7630
q19	1680	1498	1645	1498
q20	2070	1841	1844	1841
q21	5181	4998	4999	4998
q22	1133	1108	1011	1011
Total cold run time: 67878 ms
Total hot run time: 58627 ms

@doris-robot
Copy link

doris-robot commented Jun 24, 2025

TPC-DS: Total hot run time: 196623 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a085b84631264b69a8db58fc46213a5d08a65f78, data reload: false

query1	1341	913	895	895
query2	6349	1866	1830	1830
query3	10838	4368	4285	4285
query4	61029	28932	23792	23792
query5	5255	473	436	436
query6	407	190	176	176
query7	5440	318	308	308
query8	320	232	223	223
query9	8666	2597	2562	2562
query10	453	289	275	275
query11	17383	15263	15791	15263
query12	165	102	112	102
query13	1481	427	428	427
query14	10378	7574	6684	6684
query15	200	190	176	176
query16	7129	502	498	498
query17	1119	598	586	586
query18	1801	331	323	323
query19	207	170	159	159
query20	119	112	108	108
query21	207	107	105	105
query22	4715	4459	4878	4459
query23	34576	34115	34165	34115
query24	6135	2900	2936	2900
query25	585	437	419	419
query26	715	167	175	167
query27	2099	355	371	355
query28	4219	2137	2144	2137
query29	707	459	440	440
query30	230	162	156	156
query31	992	816	812	812
query32	67	58	56	56
query33	443	307	299	299
query34	919	504	509	504
query35	815	728	721	721
query36	1092	952	979	952
query37	109	62	72	62
query38	4031	4110	3976	3976
query39	1509	1466	1466	1466
query40	214	96	96	96
query41	49	47	47	47
query42	114	108	98	98
query43	529	480	465	465
query44	1193	844	799	799
query45	182	171	166	166
query46	1174	721	712	712
query47	2077	1917	1978	1917
query48	511	391	379	379
query49	733	396	394	394
query50	835	432	429	429
query51	7374	7308	7356	7308
query52	116	93	91	91
query53	264	194	190	190
query54	571	486	462	462
query55	78	75	84	75
query56	258	232	242	232
query57	1294	1254	1218	1218
query58	218	211	218	211
query59	3153	3104	3097	3097
query60	293	267	248	248
query61	111	117	128	117
query62	791	678	697	678
query63	225	196	185	185
query64	2569	676	656	656
query65	3248	3187	3152	3152
query66	759	305	295	295
query67	16031	15860	15501	15501
query68	4287	575	563	563
query69	427	261	256	256
query70	1169	1119	1074	1074
query71	337	251	271	251
query72	6346	3948	4007	3948
query73	756	346	363	346
query74	10204	9029	8880	8880
query75	3359	2638	2645	2638
query76	2030	1098	1069	1069
query77	500	266	274	266
query78	10619	9537	9641	9537
query79	2045	588	579	579
query80	1398	416	414	414
query81	524	226	223	223
query82	1247	92	88	88
query83	272	142	141	141
query84	282	81	84	81
query85	1037	309	286	286
query86	385	269	282	269
query87	4439	4273	4273	4273
query88	3904	2375	2351	2351
query89	409	290	289	289
query90	2028	181	178	178
query91	186	149	152	149
query92	63	49	48	48
query93	2827	558	553	553
query94	799	307	294	294
query95	354	256	257	256
query96	617	274	281	274
query97	3299	3159	3132	3132
query98	212	203	194	194
query99	1556	1296	1345	1296
Total cold run time: 317126 ms
Total hot run time: 196623 ms

@doris-robot
Copy link

doris-robot commented Jun 24, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.17% (10910/26503)
Line Coverage 31.97% (93382/292115)
Region Coverage 31.03% (48124/155085)
Branch Coverage 27.49% (24651/89670)

@doris-robot
Copy link

doris-robot commented Jun 24, 2025

ClickBench: Total hot run time: 31.13 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a085b84631264b69a8db58fc46213a5d08a65f78, data reload: false

query1	0.04	0.03	0.02
query2	0.08	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.11
query5	0.53	0.53	0.51
query6	1.14	0.73	0.73
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.57	0.50	0.50
query10	0.55	0.56	0.55
query11	0.14	0.11	0.10
query12	0.14	0.12	0.11
query13	0.61	0.59	0.59
query14	0.76	0.78	0.79
query15	0.85	0.83	0.82
query16	0.37	0.38	0.38
query17	1.03	1.01	1.00
query18	0.24	0.23	0.22
query19	1.95	1.82	1.80
query20	0.02	0.01	0.01
query21	15.42	0.59	0.56
query22	2.34	2.27	2.00
query23	16.93	0.88	0.80
query24	3.14	1.82	1.87
query25	0.31	0.13	0.09
query26	0.49	0.14	0.14
query27	0.04	0.04	0.04
query28	8.91	0.48	0.52
query29	12.57	3.23	3.19
query30	0.24	0.06	0.06
query31	2.87	0.41	0.39
query32	3.22	0.46	0.46
query33	3.00	3.01	3.05
query34	17.17	4.46	4.55
query35	4.53	4.50	4.50
query36	0.65	0.48	0.49
query37	0.10	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 103.24 s
Total hot run time: 31.13 s

dataroaring
dataroaring approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit cb511c9 into branch-3.0 Jun 24, 2025
21 of 25 checks passed
@github-actions github-actions bot deleted the auto-pick-52185-branch-3.0 branch June 24, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hello-stephen @doris-robot @dataroaring @swjtu-zhanglei