-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feat](cluster-snapshot) add cluster snapshot protobuf definition #52405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 34188 ms |
TPC-DS: Total hot run time: 185645 ms |
ClickBench: Total hot run time: 29.65 s |
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33956 ms |
TPC-DS: Total hot run time: 185045 ms |
ClickBench: Total hot run time: 30.37 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
| optional string instance_id = 1; | ||
| optional Operation op = 2; | ||
| optional string name = 3; | ||
| optional string value = 4; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this value for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SET_SNAPSHOT_PROPERTY needs a value.
For example: ALTER CLUSTER SNAPSHOT SET ("snapshot_interval" = "100")
=>
AlterInstanceRequest { op: SET_SNAPSHOT_PROPERTY, name: "snapshot_interval", value: "100" }
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)