Skip to content

Conversation

@w41ter
Copy link
Contributor

@w41ter w41ter commented Jun 27, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 27, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@w41ter
Copy link
Contributor Author

w41ter commented Jun 27, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 34188 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f17c0ebfeac8187febfe05071be23b5b71b3f619, data reload: false

------ Round 1 ----------------------------------
q1	17700	5223	5133	5133
q2	1968	283	194	194
q3	10526	1320	735	735
q4	10250	1044	541	541
q5	7686	2424	2409	2409
q6	180	163	128	128
q7	899	757	617	617
q8	9326	1354	1150	1150
q9	6803	5072	5096	5072
q10	6890	2401	1949	1949
q11	480	288	274	274
q12	355	384	218	218
q13	17756	3784	3087	3087
q14	230	224	221	221
q15	537	475	485	475
q16	431	416	373	373
q17	622	879	381	381
q18	7656	7178	7034	7034
q19	2573	962	560	560
q20	328	354	222	222
q21	4031	3268	2471	2471
q22	1027	1021	944	944
Total cold run time: 108254 ms
Total hot run time: 34188 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5414	5180	5166	5166
q2	240	312	218	218
q3	2196	2674	2307	2307
q4	1432	1815	1393	1393
q5	4380	4511	4498	4498
q6	215	164	124	124
q7	1970	1965	1785	1785
q8	2566	2563	2496	2496
q9	7205	7164	7183	7164
q10	3056	3258	2846	2846
q11	568	521	492	492
q12	690	762	609	609
q13	3550	3948	3308	3308
q14	292	289	261	261
q15	518	473	471	471
q16	457	477	438	438
q17	1175	1568	1352	1352
q18	7786	7586	7445	7445
q19	877	906	990	906
q20	1973	2057	1854	1854
q21	4993	4277	4202	4202
q22	1069	1042	993	993
Total cold run time: 52622 ms
Total hot run time: 50328 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185645 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f17c0ebfeac8187febfe05071be23b5b71b3f619, data reload: false

query1	992	394	381	381
query2	6535	1709	1735	1709
query3	6737	214	213	213
query4	27031	23871	23634	23634
query5	4301	604	475	475
query6	305	216	199	199
query7	4623	499	292	292
query8	285	214	212	212
query9	8591	2673	2666	2666
query10	464	332	280	280
query11	15392	15012	14724	14724
query12	155	107	100	100
query13	1655	530	438	438
query14	8608	5850	5832	5832
query15	204	182	173	173
query16	7404	637	493	493
query17	1240	715	589	589
query18	1997	421	314	314
query19	198	183	165	165
query20	121	115	115	115
query21	211	129	110	110
query22	4094	4318	4072	4072
query23	34077	32994	32959	32959
query24	8482	2384	2366	2366
query25	546	458	408	408
query26	1221	271	146	146
query27	2741	515	359	359
query28	4308	2142	2114	2114
query29	755	570	435	435
query30	282	217	178	178
query31	914	833	722	722
query32	74	61	58	58
query33	552	370	336	336
query34	797	837	528	528
query35	756	777	766	766
query36	969	979	885	885
query37	110	101	70	70
query38	4169	4055	4156	4055
query39	1444	1409	1415	1409
query40	207	116	100	100
query41	55	52	50	50
query42	125	105	104	104
query43	506	525	489	489
query44	1334	822	812	812
query45	174	164	161	161
query46	840	1007	630	630
query47	1763	1797	1712	1712
query48	370	413	305	305
query49	732	455	382	382
query50	626	688	409	409
query51	4128	4233	4125	4125
query52	109	109	97	97
query53	234	254	185	185
query54	577	573	499	499
query55	82	78	83	78
query56	310	306	292	292
query57	1185	1207	1125	1125
query58	259	263	258	258
query59	2548	2802	2555	2555
query60	348	326	305	305
query61	124	122	117	117
query62	783	726	667	667
query63	215	184	196	184
query64	4317	1012	632	632
query65	4261	4188	4168	4168
query66	1116	398	307	307
query67	15741	15764	15433	15433
query68	9023	880	524	524
query69	479	296	274	274
query70	1249	1120	1115	1115
query71	461	309	306	306
query72	5556	4787	4859	4787
query73	723	639	345	345
query74	9153	9092	8995	8995
query75	4178	3176	2692	2692
query76	3617	1226	797	797
query77	789	389	282	282
query78	10043	10235	9353	9353
query79	3405	837	555	555
query80	628	506	448	448
query81	472	254	226	226
query82	483	120	92	92
query83	277	245	224	224
query84	293	111	84	84
query85	783	355	333	333
query86	335	310	285	285
query87	4471	4463	4282	4282
query88	2882	2245	2228	2228
query89	441	312	288	288
query90	1944	200	200	200
query91	152	147	110	110
query92	72	57	56	56
query93	2119	947	587	587
query94	672	408	302	302
query95	368	280	276	276
query96	489	565	280	280
query97	2731	2760	2660	2660
query98	217	211	201	201
query99	1440	1360	1297	1297
Total cold run time: 276354 ms
Total hot run time: 185645 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.65 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f17c0ebfeac8187febfe05071be23b5b71b3f619, data reload: false

query1	0.05	0.03	0.03
query2	0.08	0.04	0.04
query3	0.25	0.07	0.07
query4	1.62	0.11	0.11
query5	0.42	0.42	0.40
query6	1.16	0.65	0.65
query7	0.02	0.02	0.02
query8	0.05	0.04	0.03
query9	0.60	0.53	0.52
query10	0.57	0.57	0.57
query11	0.16	0.10	0.11
query12	0.15	0.12	0.12
query13	0.63	0.61	0.60
query14	0.82	0.81	0.82
query15	0.91	0.88	0.86
query16	0.39	0.40	0.39
query17	1.08	1.04	1.08
query18	0.23	0.20	0.20
query19	2.11	1.91	1.91
query20	0.02	0.01	0.01
query21	15.38	0.92	0.56
query22	0.75	1.22	0.91
query23	14.72	1.38	0.60
query24	7.51	0.70	0.99
query25	0.52	0.24	0.08
query26	0.65	0.16	0.14
query27	0.06	0.06	0.05
query28	9.33	0.94	0.45
query29	12.60	3.97	3.32
query30	0.24	0.09	0.07
query31	2.84	0.60	0.38
query32	3.24	0.57	0.47
query33	3.16	3.06	3.04
query34	16.10	5.39	4.81
query35	4.84	4.82	4.79
query36	0.69	0.50	0.49
query37	0.09	0.07	0.06
query38	0.04	0.04	0.03
query39	0.04	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.44 s
Total hot run time: 29.65 s

@w41ter
Copy link
Contributor Author

w41ter commented Jun 27, 2025

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 0.00% (0/35) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.93% (1171/1412)
Line Coverage 67.49% (20673/30633)
Region Coverage 67.07% (10263/15301)
Branch Coverage 56.37% (5369/9524)

@doris-robot
Copy link

TPC-H: Total hot run time: 33956 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 19d248a8b2f25259b991725c51ed461687e02740, data reload: false

------ Round 1 ----------------------------------
q1	17712	5183	5061	5061
q2	1913	295	186	186
q3	10618	1268	722	722
q4	10328	1027	507	507
q5	9191	2342	2353	2342
q6	204	156	125	125
q7	902	744	600	600
q8	9307	1259	1091	1091
q9	6903	5111	5155	5111
q10	6888	2384	1952	1952
q11	470	288	285	285
q12	352	353	214	214
q13	17790	3612	3092	3092
q14	228	234	218	218
q15	538	490	466	466
q16	414	458	391	391
q17	617	845	378	378
q18	7404	7194	7144	7144
q19	1624	948	533	533
q20	333	359	223	223
q21	3862	2563	2362	2362
q22	1059	1003	953	953
Total cold run time: 108657 ms
Total hot run time: 33956 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5200	5081	5108	5081
q2	239	320	223	223
q3	2199	2654	2305	2305
q4	1401	1800	1369	1369
q5	4361	4399	4329	4329
q6	211	168	121	121
q7	2007	1895	1775	1775
q8	2586	2509	2498	2498
q9	7263	7105	7122	7105
q10	3081	3251	2822	2822
q11	577	520	488	488
q12	703	779	595	595
q13	3460	3809	3267	3267
q14	268	285	273	273
q15	526	468	493	468
q16	447	485	446	446
q17	1117	1514	1310	1310
q18	7364	7291	6963	6963
q19	777	760	853	760
q20	1915	1988	1891	1891
q21	4748	4357	4239	4239
q22	1062	1023	998	998
Total cold run time: 51512 ms
Total hot run time: 49326 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185045 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 19d248a8b2f25259b991725c51ed461687e02740, data reload: false

query1	1022	399	397	397
query2	6539	1695	1748	1695
query3	6755	213	212	212
query4	26400	23800	22952	22952
query5	4360	582	424	424
query6	304	218	203	203
query7	4622	503	284	284
query8	275	223	224	223
query9	8625	2649	2658	2649
query10	464	374	269	269
query11	15275	15143	14843	14843
query12	161	118	104	104
query13	1658	528	415	415
query14	8919	5659	5717	5659
query15	196	190	181	181
query16	7565	620	455	455
query17	1200	753	561	561
query18	1998	395	300	300
query19	191	224	156	156
query20	121	118	112	112
query21	210	121	112	112
query22	4253	4181	4122	4122
query23	33958	33116	33053	33053
query24	8437	2354	2375	2354
query25	542	482	382	382
query26	1232	282	145	145
query27	2746	515	333	333
query28	4274	2138	2113	2113
query29	754	575	428	428
query30	284	220	188	188
query31	931	857	746	746
query32	70	63	62	62
query33	574	354	311	311
query34	784	849	511	511
query35	771	836	746	746
query36	968	984	898	898
query37	111	98	70	70
query38	4089	4155	4104	4104
query39	1485	1430	1441	1430
query40	209	117	106	106
query41	58	55	52	52
query42	123	112	109	109
query43	510	525	463	463
query44	1282	817	801	801
query45	170	173	161	161
query46	844	1016	611	611
query47	1764	1795	1767	1767
query48	383	409	304	304
query49	745	490	383	383
query50	629	710	404	404
query51	4139	4124	4113	4113
query52	111	109	95	95
query53	218	254	176	176
query54	574	568	509	509
query55	84	80	78	78
query56	318	288	269	269
query57	1196	1180	1138	1138
query58	264	255	267	255
query59	2667	2733	2561	2561
query60	353	318	305	305
query61	124	121	119	119
query62	798	730	653	653
query63	217	185	183	183
query64	4285	1000	653	653
query65	4273	4172	4169	4169
query66	1098	422	338	338
query67	15895	15520	15617	15520
query68	7838	896	530	530
query69	465	301	261	261
query70	1176	1138	1122	1122
query71	423	322	302	302
query72	5620	4974	5194	4974
query73	677	659	350	350
query74	9245	8880	9029	8880
query75	3407	3208	2722	2722
query76	3310	1137	708	708
query77	517	366	302	302
query78	10183	10208	9288	9288
query79	2842	832	560	560
query80	730	495	448	448
query81	599	257	218	218
query82	727	129	93	93
query83	255	248	229	229
query84	243	106	87	87
query85	807	359	318	318
query86	414	269	303	269
query87	4480	4511	4299	4299
query88	4127	2290	2289	2289
query89	380	316	287	287
query90	1875	204	200	200
query91	144	145	110	110
query92	82	63	53	53
query93	2613	935	581	581
query94	734	391	303	303
query95	377	300	319	300
query96	490	576	287	287
query97	2688	2804	2682	2682
query98	235	208	208	208
query99	1353	1429	1288	1288
Total cold run time: 275510 ms
Total hot run time: 185045 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.37 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 19d248a8b2f25259b991725c51ed461687e02740, data reload: false

query1	0.04	0.04	0.04
query2	0.11	0.05	0.06
query3	0.28	0.06	0.06
query4	1.61	0.08	0.09
query5	0.42	0.41	0.40
query6	1.17	0.68	0.67
query7	0.03	0.01	0.01
query8	0.06	0.05	0.06
query9	0.64	0.53	0.52
query10	0.59	0.57	0.57
query11	0.26	0.14	0.13
query12	0.25	0.14	0.13
query13	0.65	0.63	0.63
query14	0.81	0.84	0.83
query15	0.98	0.90	0.90
query16	0.38	0.39	0.38
query17	1.12	1.09	1.11
query18	0.24	0.23	0.23
query19	2.00	1.88	1.91
query20	0.02	0.01	0.01
query21	15.38	1.00	0.69
query22	0.93	1.03	0.79
query23	14.68	1.55	0.76
query24	5.05	0.61	0.32
query25	0.18	0.09	0.09
query26	0.56	0.23	0.18
query27	0.08	0.08	0.10
query28	11.02	1.20	0.59
query29	12.57	4.11	3.40
query30	0.28	0.09	0.06
query31	2.82	0.63	0.42
query32	3.26	0.61	0.51
query33	3.13	3.12	3.10
query34	17.00	5.44	4.74
query35	4.81	4.80	4.86
query36	0.65	0.51	0.51
query37	0.21	0.18	0.17
query38	0.18	0.18	0.15
query39	0.06	0.04	0.04
query40	0.20	0.17	0.16
query41	0.11	0.05	0.05
query42	0.06	0.06	0.05
query43	0.06	0.05	0.05
Total cold run time: 104.94 s
Total hot run time: 30.37 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.02% (15364/26945)
Line Coverage 46.11% (139409/302336)
Region Coverage 45.43% (70621/155443)
Branch Coverage 40.19% (37303/92810)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

PR approved by anyone and no changes requested.

optional string instance_id = 1;
optional Operation op = 2;
optional string name = 3;
optional string value = 4;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this value for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SET_SNAPSHOT_PROPERTY needs a value.

For example: ALTER CLUSTER SNAPSHOT SET ("snapshot_interval" = "100")
=>
AlterInstanceRequest { op: SET_SNAPSHOT_PROPERTY, name: "snapshot_interval", value: "100" }

@w41ter w41ter closed this Jul 2, 2025
@w41ter w41ter reopened this Jul 2, 2025
@gavinchou gavinchou self-requested a review July 2, 2025 02:49
@gavinchou gavinchou merged commit 6d8df5a into apache:master Jul 2, 2025
41 of 47 checks passed
@w41ter w41ter deleted the add_snapshot_protobufs branch July 2, 2025 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. cloud reviewed snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants