Skip to content

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Jun 29, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #51889

Problem Summary:

Fixes macOS compilation errors by replacing legacy endian macros (__BYTE_ORDER, __LITTLE_ENDIAN) with modern standard macros (__BYTE_ORDER__, __ORDER_LITTLE_ENDIAN__).

The issue was introduced in commit 2d513df which removed gutil/port.h. This file previously provided legacy macro definitions for macOS, but after removal, only Linux retained these macros through system <endian.h>.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zy-kkk
Copy link
Member Author

zy-kkk commented Jun 29, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33828 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dfb087d98aa122a8c330c64cd932f2dc687f18bd, data reload: false

------ Round 1 ----------------------------------
q1	17612	5159	5077	5077
q2	1951	280	189	189
q3	10309	1276	716	716
q4	10220	1028	520	520
q5	7461	2370	2341	2341
q6	190	159	127	127
q7	899	735	591	591
q8	9304	1288	1044	1044
q9	7515	5125	5200	5125
q10	6884	2383	1983	1983
q11	495	291	282	282
q12	347	346	207	207
q13	17758	3614	3098	3098
q14	229	226	209	209
q15	550	481	492	481
q16	415	419	391	391
q17	596	852	358	358
q18	7627	7302	7042	7042
q19	1260	969	538	538
q20	326	337	216	216
q21	3795	3146	2347	2347
q22	1106	1012	946	946
Total cold run time: 106849 ms
Total hot run time: 33828 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5124	5126	5069	5069
q2	240	324	219	219
q3	2151	2634	2269	2269
q4	1368	1750	1339	1339
q5	4228	4403	4398	4398
q6	213	168	122	122
q7	1971	1902	1765	1765
q8	2594	2566	2503	2503
q9	7216	7135	7066	7066
q10	3076	3256	2830	2830
q11	579	504	498	498
q12	679	802	635	635
q13	3531	3873	3262	3262
q14	286	309	272	272
q15	526	476	485	476
q16	458	496	432	432
q17	1144	1533	1350	1350
q18	7451	7244	7165	7165
q19	758	770	790	770
q20	1907	1997	1817	1817
q21	4720	4309	4338	4309
q22	1086	1028	1004	1004
Total cold run time: 51306 ms
Total hot run time: 49570 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 185462 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dfb087d98aa122a8c330c64cd932f2dc687f18bd, data reload: false

query1	1013	388	402	388
query2	6557	1836	1780	1780
query3	6735	216	218	216
query4	26445	23653	23309	23309
query5	4364	583	481	481
query6	303	213	197	197
query7	4619	492	288	288
query8	277	226	209	209
query9	8629	2618	2634	2618
query10	483	320	266	266
query11	15754	15131	14942	14942
query12	164	105	107	105
query13	1646	536	405	405
query14	9545	5709	5882	5709
query15	215	184	180	180
query16	7594	650	453	453
query17	1204	709	601	601
query18	2060	422	308	308
query19	194	196	166	166
query20	125	123	112	112
query21	214	124	109	109
query22	4027	4084	3962	3962
query23	33784	32932	33197	32932
query24	8459	2371	2408	2371
query25	523	463	385	385
query26	1221	264	146	146
query27	2750	511	338	338
query28	4330	2117	2093	2093
query29	727	603	437	437
query30	294	220	186	186
query31	942	827	759	759
query32	69	64	80	64
query33	575	355	310	310
query34	799	832	517	517
query35	805	819	756	756
query36	940	975	881	881
query37	105	100	81	81
query38	4184	4099	4044	4044
query39	1473	1432	1431	1431
query40	206	113	108	108
query41	55	52	59	52
query42	121	107	111	107
query43	513	527	506	506
query44	1298	848	832	832
query45	180	175	162	162
query46	821	1000	627	627
query47	1764	1831	1757	1757
query48	388	419	310	310
query49	735	476	397	397
query50	640	695	416	416
query51	4156	4194	4115	4115
query52	115	99	102	99
query53	223	250	186	186
query54	569	591	505	505
query55	84	82	81	81
query56	284	299	276	276
query57	1175	1206	1145	1145
query58	267	248	252	248
query59	2623	2832	2596	2596
query60	326	323	315	315
query61	124	120	126	120
query62	806	708	650	650
query63	223	180	181	180
query64	4213	1048	706	706
query65	4280	4186	4202	4186
query66	1072	422	312	312
query67	15858	15480	15435	15435
query68	8512	891	521	521
query69	461	298	266	266
query70	1220	1110	1085	1085
query71	460	313	291	291
query72	5510	4672	4706	4672
query73	708	584	346	346
query74	9216	9053	9047	9047
query75	3899	3180	2686	2686
query76	3606	1139	718	718
query77	790	371	288	288
query78	10115	10109	9314	9314
query79	3746	869	584	584
query80	662	541	545	541
query81	504	251	224	224
query82	538	128	102	102
query83	288	250	239	239
query84	298	113	86	86
query85	780	367	409	367
query86	387	300	307	300
query87	4509	4500	4333	4333
query88	3425	2253	2281	2253
query89	445	318	295	295
query90	1928	224	218	218
query91	137	143	114	114
query92	73	59	58	58
query93	3096	954	589	589
query94	656	417	301	301
query95	387	299	287	287
query96	498	593	290	290
query97	2765	2744	2646	2646
query98	234	197	210	197
query99	1469	1392	1240	1240
Total cold run time: 278588 ms
Total hot run time: 185462 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/1) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.02% (15364/26945)
Line Coverage 46.11% (139425/302357)
Region Coverage 45.44% (70638/155463)
Branch Coverage 40.20% (37312/92812)

@zy-kkk
Copy link
Member Author

zy-kkk commented Jun 30, 2025

fixed by #52425

@zy-kkk zy-kkk closed this Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants