Skip to content

Conversation

@shuke987
Copy link
Collaborator

What problem does this PR solve?

[15:13:10 ] /root/doris/be/src/olap/rowset/segment_v2/variant/variant_column_reader.cpp:235:19: error: operation on '* iterator' may be undefined [-Werror=sequence-point]
15:13:10 235 | *iterator = *iterator =
15:13:10 | ~~~~~~~~~~^~~~~~~~~~~~~
15:13:10 236 | new VariantRootColumnIterator(new FileColumnIterator(node->data.reader.get()));

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@shuke987 shuke987 requested a review from morrySnow as a code owner June 30, 2025 07:36
@shuke987
Copy link
Collaborator Author

run performance

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

morrySnow
morrySnow previously approved these changes Jun 30, 2025
@shuke987
Copy link
Collaborator Author

run buildall

@shuke987
Copy link
Collaborator Author

run buildall

@shuke987
Copy link
Collaborator Author

run buildall

@shuke987
Copy link
Collaborator Author

run buildall

@shuke987
Copy link
Collaborator Author

run buildall

@shuke987
Copy link
Collaborator Author

run buildall

@shuke987
Copy link
Collaborator Author

run buildall

@shuke987
Copy link
Collaborator Author

run buildall

@shuke987
Copy link
Collaborator Author

run buildall

@shuke987 shuke987 closed this Jun 30, 2025
@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 100.00% (7/7) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 44.98% (12352/27459)
Line Coverage 36.00% (109376/303828)
Region Coverage 35.07% (56691/161672)
Branch Coverage 32.20% (30759/95532)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants