Skip to content

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Jul 2, 2025

What problem does this PR solve?

Add hot values to column statistics to string, so that the hot values could be printed in memo plan.
related pr: #52048

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review July 2, 2025 07:30
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33693 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6ea84bb09c025d1f8937c39a7047c06a28fb46cd, data reload: false

------ Round 1 ----------------------------------
q1	17623	5201	5032	5032
q2	1931	278	188	188
q3	10371	1270	713	713
q4	10269	1013	528	528
q5	8038	2318	2298	2298
q6	175	161	128	128
q7	875	765	610	610
q8	9294	1290	1057	1057
q9	6762	5062	5216	5062
q10	6860	2347	1975	1975
q11	468	300	271	271
q12	336	342	217	217
q13	17780	3649	3047	3047
q14	223	224	209	209
q15	546	479	475	475
q16	420	432	402	402
q17	601	852	367	367
q18	7569	7015	7139	7015
q19	1418	943	534	534
q20	334	350	229	229
q21	3881	2565	2377	2377
q22	1010	1003	959	959
Total cold run time: 106784 ms
Total hot run time: 33693 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5139	5074	5109	5074
q2	251	320	220	220
q3	2124	2646	2244	2244
q4	1359	1740	1331	1331
q5	4175	4401	4432	4401
q6	210	178	126	126
q7	2054	1966	1850	1850
q8	2594	2543	2497	2497
q9	7273	7245	7343	7245
q10	3072	3338	2847	2847
q11	617	556	497	497
q12	677	770	625	625
q13	3668	3975	3319	3319
q14	282	302	272	272
q15	526	467	481	467
q16	462	485	435	435
q17	1187	1537	1410	1410
q18	7933	7613	7691	7613
q19	812	765	860	765
q20	1907	1939	1799	1799
q21	4729	4390	4143	4143
q22	1051	1025	988	988
Total cold run time: 52102 ms
Total hot run time: 50168 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 184583 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6ea84bb09c025d1f8937c39a7047c06a28fb46cd, data reload: false

query1	1009	387	385	385
query2	6534	1788	1807	1788
query3	6740	212	214	212
query4	26199	23678	23158	23158
query5	4391	579	423	423
query6	290	217	197	197
query7	4612	489	288	288
query8	261	217	219	217
query9	8596	2627	2642	2627
query10	478	320	265	265
query11	15391	15233	15077	15077
query12	162	110	103	103
query13	1656	548	412	412
query14	8989	5621	5669	5621
query15	198	187	174	174
query16	7747	600	447	447
query17	1177	729	561	561
query18	2015	393	284	284
query19	186	185	170	170
query20	134	117	117	117
query21	210	119	104	104
query22	3963	4091	3980	3980
query23	33725	32880	32947	32880
query24	8438	2352	2377	2352
query25	494	476	378	378
query26	1228	279	146	146
query27	2713	498	337	337
query28	4291	2134	2111	2111
query29	769	541	448	448
query30	276	213	186	186
query31	902	830	737	737
query32	68	64	60	60
query33	551	366	312	312
query34	780	838	509	509
query35	796	808	740	740
query36	939	987	890	890
query37	122	100	79	79
query38	4083	4181	4037	4037
query39	1474	1416	1416	1416
query40	217	114	104	104
query41	56	53	50	50
query42	129	105	104	104
query43	513	526	458	458
query44	1308	817	807	807
query45	173	166	164	164
query46	826	1030	609	609
query47	1761	1808	1746	1746
query48	397	410	303	303
query49	748	453	381	381
query50	641	690	419	419
query51	4117	4152	4046	4046
query52	112	115	103	103
query53	235	250	187	187
query54	581	572	516	516
query55	85	79	81	79
query56	307	310	301	301
query57	1176	1210	1132	1132
query58	267	251	255	251
query59	2611	2646	2613	2613
query60	315	302	291	291
query61	122	117	117	117
query62	797	696	668	668
query63	226	195	194	194
query64	4230	1030	652	652
query65	4277	4161	4232	4161
query66	1074	416	292	292
query67	15650	15575	15241	15241
query68	7809	900	518	518
query69	471	314	264	264
query70	1193	1099	1172	1099
query71	457	328	300	300
query72	5603	4762	4844	4762
query73	707	647	356	356
query74	8861	9255	8867	8867
query75	3725	3216	2661	2661
query76	3536	1144	699	699
query77	770	392	290	290
query78	10063	10038	9313	9313
query79	2280	820	585	585
query80	554	506	445	445
query81	481	259	221	221
query82	448	134	101	101
query83	240	249	247	247
query84	263	113	89	89
query85	868	440	429	429
query86	384	313	288	288
query87	4462	4443	4335	4335
query88	3808	2297	2265	2265
query89	385	311	297	297
query90	1832	211	206	206
query91	128	141	109	109
query92	76	58	56	56
query93	1851	921	577	577
query94	673	413	294	294
query95	372	291	285	285
query96	485	572	285	285
query97	2700	2760	2645	2645
query98	226	212	201	201
query99	1648	1395	1277	1277
Total cold run time: 272897 ms
Total hot run time: 184583 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6ea84bb09c025d1f8937c39a7047c06a28fb46cd, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.24	0.07	0.07
query4	1.61	0.10	0.10
query5	0.43	0.43	0.40
query6	1.18	0.66	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.60	0.51	0.52
query10	0.57	0.57	0.58
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.61	0.61
query14	0.81	0.81	0.82
query15	0.91	0.88	0.86
query16	0.40	0.38	0.41
query17	1.08	1.07	1.04
query18	0.23	0.22	0.22
query19	2.00	1.85	1.83
query20	0.02	0.01	0.01
query21	15.41	0.85	0.54
query22	0.74	1.28	0.60
query23	14.93	1.38	0.60
query24	7.76	1.37	0.85
query25	0.48	0.32	0.09
query26	0.46	0.16	0.13
query27	0.05	0.05	0.05
query28	9.52	0.80	0.42
query29	12.63	3.94	3.28
query30	0.25	0.09	0.08
query31	2.82	0.60	0.38
query32	3.24	0.56	0.46
query33	3.01	3.20	3.05
query34	15.95	5.47	4.77
query35	4.87	4.85	4.82
query36	0.71	0.50	0.49
query37	0.11	0.07	0.07
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.18	0.14	0.14
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.54 s
Total hot run time: 29.39 s

@Jibing-Li
Copy link
Contributor Author

run p0

3 similar comments
@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li
Copy link
Contributor Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2025

PR approved by anyone and no changes requested.

@Jibing-Li Jibing-Li merged commit 3f50417 into apache:master Jul 4, 2025
26 of 28 checks passed
@Jibing-Li Jibing-Li deleted the tostring branch July 4, 2025 03:08
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
…pache#52651)

### What problem does this PR solve?

Add hot values to column statistics to string, so that the hot values
could be printed in memo plan.
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
…pache#52651)

### What problem does this PR solve?

Add hot values to column statistics to string, so that the hot values
could be printed in memo plan.
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 4, 2025
…pache#52651)

### What problem does this PR solve?

Add hot values to column statistics to string, so that the hot values
could be printed in memo plan.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants