[fix](nereids) Fix the int type coercion to big int wrongly when handle user set var #52689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
2 similar comments
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34183 ms |
TPC-DS: Total hot run time: 185261 ms |
ClickBench: Total hot run time: 30.32 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
starocean999
approved these changes
Aug 29, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
approved these changes
Sep 10, 2025
seawinde
force-pushed
the
fix_set_user_var_wrong_int_type
branch
from
e4dff17 to
412a14f
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34557 ms |
TPC-DS: Total hot run time: 189149 ms |
ClickBench: Total hot run time: 29.77 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
2 similar comments
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
FE Regression Coverage ReportIncrement line coverage |
starocean999
approved these changes
Nov 12, 2025
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Nov 13, 2025
…le user set var (apache#52689) the value in the IntLiteral should be int, but now is long in old planner literalExpr so need to type coercion to generate right new planner int Literal such as the example as following: ```sql CREATE TABLE IF NOT EXISTS orders ( o_orderkey INTEGER NOT NULL, o_custkey INTEGER NOT NULL, o_orderstatus CHAR(1) NOT NULL, o_totalprice DECIMALV3(15,2) NOT NULL, o_orderdate DATE NOT NULL, o_orderpriority CHAR(15) NOT NULL, o_clerk CHAR(15) NOT NULL, o_shippriority INTEGER NOT NULL, O_COMMENT VARCHAR(79) NOT NULL ) DUPLICATE KEY(o_orderkey, o_custkey) DISTRIBUTED BY HASH(o_orderkey) BUCKETS 3 PROPERTIES ( "replication_num" = "1" ); insert into orders values (1, 1, 'o', 9.5, '2023-12-08', 'a', 'b', 1, 'yy'), (1, 1, 'o', 10.5, '2023-12-08', 'a', 'b', 1, 'yy'), (5, 2, 'o', 1.2, '2023-12-12', 'c','d',2, 'mi'); ``` if ` set @ship_no = 1;` and run query as following, should not add cast(o_shippriority as bigint) but now add cast(o_shippriority as bigint) worngly, this would cause tablet prune fail ,the pr fix this ```sql explain select * from orders where o_shippriority = @ship_no; ```
wyxxxcat
pushed a commit
to wyxxxcat/doris
that referenced
this pull request
Nov 18, 2025
…le user set var (apache#52689) the value in the IntLiteral should be int, but now is long in old planner literalExpr so need to type coercion to generate right new planner int Literal such as the example as following: ```sql CREATE TABLE IF NOT EXISTS orders ( o_orderkey INTEGER NOT NULL, o_custkey INTEGER NOT NULL, o_orderstatus CHAR(1) NOT NULL, o_totalprice DECIMALV3(15,2) NOT NULL, o_orderdate DATE NOT NULL, o_orderpriority CHAR(15) NOT NULL, o_clerk CHAR(15) NOT NULL, o_shippriority INTEGER NOT NULL, O_COMMENT VARCHAR(79) NOT NULL ) DUPLICATE KEY(o_orderkey, o_custkey) DISTRIBUTED BY HASH(o_orderkey) BUCKETS 3 PROPERTIES ( "replication_num" = "1" ); insert into orders values (1, 1, 'o', 9.5, '2023-12-08', 'a', 'b', 1, 'yy'), (1, 1, 'o', 10.5, '2023-12-08', 'a', 'b', 1, 'yy'), (5, 2, 'o', 1.2, '2023-12-12', 'c','d',2, 'mi'); ``` if ` set @ship_no = 1;` and run query as following, should not add cast(o_shippriority as bigint) but now add cast(o_shippriority as bigint) worngly, this would cause tablet prune fail ,the pr fix this ```sql explain select * from orders where o_shippriority = @ship_no; ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the value in the IntLiteral should be int, but now is long in old planner literalExpr
so need to type coercion to generate right new planner int Literal
such as the example as following:
if
set @ship_no = 1;and run query as following, should not add cast(o_shippriority as bigint) but now add cast(o_shippriority as bigint) worngly, this would cause tablet prune fail ,the pr fix thisWhat problem does this PR solve?
Issue Number: close #xxx
Related PR: #26655
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)