Skip to content

[Fix](dictionary) Fix show dictionaries get wrong status result in follower #52972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zclllyybb merged 5 commits into from
Jul 14, 2025
Merged

[Fix](dictionary) Fix show dictionaries get wrong status result in follower #52972

zclllyybb merged 5 commits into from
Jul 14, 2025

Conversation

@zclllyybb
Copy link
Contributor

@zclllyybb zclllyybb commented Jul 8, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

  1. Fix show dictionaries get wrong status result in follower
  2. Fix wrong version when partial load failed to avoid dead dictionary

all these changes tested sucessfully in multi-agent env.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jul 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 8, 2025

run buildall

@zclllyybb zclllyybb force-pushed the dict_partial_load branch from 8dc1887 to dd3bb47 Compare July 8, 2025 17:23
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 8, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

TPC-H: Total hot run time: 33009 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dd3bb47a745596996dd51cf500a56d01bb880728, data reload: false

------ Round 1 ----------------------------------
q1	17566	5243	5064	5064
q2	1928	277	181	181
q3	10320	1290	685	685
q4	10264	1015	527	527
q5	8136	2374	2293	2293
q6	179	155	128	128
q7	868	742	591	591
q8	9312	1289	1088	1088
q9	6768	5064	5055	5055
q10	6864	2375	1953	1953
q11	486	303	276	276
q12	334	340	205	205
q13	17761	3649	3077	3077
q14	221	231	215	215
q15	549	495	481	481
q16	428	422	371	371
q17	588	866	370	370
q18	7531	7088	7086	7086
q19	1872	934	552	552
q20	325	331	217	217
q21	3586	2526	2299	2299
q22	347	309	295	295
Total cold run time: 106233 ms
Total hot run time: 33009 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5212	5115	5137	5115
q2	241	324	219	219
q3	2178	2658	2295	2295
q4	1356	1745	1349	1349
q5	4199	4177	4579	4177
q6	213	169	129	129
q7	2075	2037	1804	1804
q8	2622	2667	2522	2522
q9	7221	7201	7237	7201
q10	3068	3352	2866	2866
q11	597	520	500	500
q12	666	816	661	661
q13	3614	3969	3318	3318
q14	292	318	297	297
q15	558	490	491	490
q16	470	544	451	451
q17	1225	1606	1439	1439
q18	8238	7893	7456	7456
q19	770	796	873	796
q20	1954	1961	1822	1822
q21	4703	4405	4246	4246
q22	601	578	536	536
Total cold run time: 52073 ms
Total hot run time: 49689 ms

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

TPC-DS: Total hot run time: 185997 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dd3bb47a745596996dd51cf500a56d01bb880728, data reload: false

query1	995	410	392	392
query2	6520	1738	1821	1738
query3	6739	212	212	212
query4	26279	23715	23724	23715
query5	4296	560	441	441
query6	299	219	211	211
query7	4624	484	281	281
query8	284	219	205	205
query9	8606	2579	2596	2579
query10	468	330	260	260
query11	16038	15125	15032	15032
query12	158	106	100	100
query13	1655	509	418	418
query14	9013	5907	5959	5907
query15	201	195	172	172
query16	7366	421	269	269
query17	1325	695	553	553
query18	1976	394	309	309
query19	184	181	151	151
query20	120	117	120	117
query21	215	122	101	101
query22	4060	4030	3855	3855
query23	33828	33092	32907	32907
query24	8457	2331	2379	2331
query25	549	508	384	384
query26	1222	263	144	144
query27	2789	512	343	343
query28	4328	2111	2097	2097
query29	735	554	437	437
query30	290	220	190	190
query31	904	819	764	764
query32	70	61	60	60
query33	550	341	290	290
query34	795	841	513	513
query35	605	643	563	563
query36	919	970	887	887
query37	112	103	74	74
query38	4244	4008	4025	4008
query39	1468	1420	1411	1411
query40	211	118	108	108
query41	62	71	73	71
query42	117	114	112	112
query43	527	512	475	475
query44	1325	840	846	840
query45	181	183	178	178
query46	825	1012	638	638
query47	1745	1773	1716	1716
query48	394	408	350	350
query49	740	474	385	385
query50	638	686	420	420
query51	4217	4267	4136	4136
query52	108	109	97	97
query53	228	259	180	180
query54	577	570	511	511
query55	82	79	83	79
query56	308	294	288	288
query57	1192	1185	1108	1108
query58	258	252	253	252
query59	2663	2824	2674	2674
query60	355	322	303	303
query61	122	118	116	116
query62	802	703	650	650
query63	221	178	197	178
query64	4367	1161	810	810
query65	4240	4142	4188	4142
query66	1097	397	316	316
query67	15779	15378	15152	15152
query68	7857	887	533	533
query69	485	297	263	263
query70	1179	1129	1126	1126
query71	434	323	293	293
query72	5628	4767	4842	4767
query73	694	631	355	355
query74	8851	9007	8862	8862
query75	3374	3179	2672	2672
query76	3338	1132	716	716
query77	540	372	300	300
query78	11064	11105	10393	10393
query79	1948	864	590	590
query80	622	509	428	428
query81	479	253	221	221
query82	408	125	103	103
query83	248	263	232	232
query84	253	104	82	82
query85	772	348	311	311
query86	335	309	293	293
query87	4422	4391	4312	4312
query88	2967	2282	2309	2282
query89	386	320	283	283
query90	1813	220	213	213
query91	140	136	106	106
query92	67	56	57	56
query93	1229	963	592	592
query94	616	312	197	197
query95	373	296	283	283
query96	491	558	282	282
query97	2695	2781	2653	2653
query98	238	208	205	205
query99	1332	1443	1287	1287
Total cold run time: 271945 ms
Total hot run time: 185997 ms

@doris-robot
Copy link

doris-robot commented Jul 8, 2025

ClickBench: Total hot run time: 29.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit dd3bb47a745596996dd51cf500a56d01bb880728, data reload: false

query1	0.05	0.04	0.04
query2	0.07	0.04	0.04
query3	0.24	0.08	0.07
query4	1.62	0.11	0.10
query5	0.42	0.44	0.41
query6	1.16	0.67	0.66
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.59	0.51	0.51
query10	0.57	0.55	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.60	0.60
query14	0.79	0.81	0.82
query15	0.90	0.89	0.86
query16	0.38	0.39	0.38
query17	1.07	1.08	1.03
query18	0.22	0.22	0.21
query19	1.91	1.83	1.90
query20	0.01	0.01	0.01
query21	15.40	0.90	0.54
query22	0.76	1.03	0.64
query23	15.15	1.40	0.60
query24	6.46	1.03	1.23
query25	0.50	0.14	0.14
query26	0.57	0.17	0.14
query27	0.07	0.06	0.06
query28	10.42	0.94	0.44
query29	12.55	3.96	3.33
query30	0.25	0.10	0.07
query31	2.85	0.59	0.38
query32	3.23	0.56	0.47
query33	3.15	3.10	3.10
query34	16.10	5.36	4.76
query35	4.85	4.83	4.85
query36	0.71	0.50	0.50
query37	0.09	0.07	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.03
query40	0.18	0.15	0.13
query41	0.09	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.53 s
Total hot run time: 29.75 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 8, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/16) 🎉
Increment coverage report
Complete coverage report

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 9, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 9, 2025

TPC-H: Total hot run time: 33183 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 32baf163bd10a267c87ddf4533740039d9f08951, data reload: false

------ Round 1 ----------------------------------
q1	17556	5191	5035	5035
q2	1922	298	186	186
q3	10300	1277	717	717
q4	10219	990	520	520
q5	7543	2373	2318	2318
q6	187	162	128	128
q7	904	734	607	607
q8	9293	1283	1075	1075
q9	6860	5109	5116	5109
q10	6888	2401	1976	1976
q11	494	291	264	264
q12	335	357	211	211
q13	17764	3599	3059	3059
q14	218	242	210	210
q15	537	473	486	473
q16	433	429	373	373
q17	571	884	352	352
q18	7735	7224	7209	7209
q19	1204	952	538	538
q20	330	340	211	211
q21	3716	2519	2317	2317
q22	357	328	295	295
Total cold run time: 105366 ms
Total hot run time: 33183 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5096	5056	5075	5056
q2	239	319	217	217
q3	2185	2706	2246	2246
q4	1365	1762	1337	1337
q5	4251	4137	4658	4137
q6	211	177	130	130
q7	2089	1943	1799	1799
q8	2636	2568	2521	2521
q9	7632	7264	7315	7264
q10	3093	3306	2855	2855
q11	586	503	493	493
q12	723	764	690	690
q13	3553	3990	3413	3413
q14	296	315	282	282
q15	517	490	501	490
q16	441	493	460	460
q17	1174	1653	1416	1416
q18	8044	7817	7515	7515
q19	800	843	893	843
q20	2042	2027	1904	1904
q21	5032	4709	4612	4612
q22	636	579	662	579
Total cold run time: 52641 ms
Total hot run time: 50259 ms

@doris-robot
Copy link

doris-robot commented Jul 9, 2025

TPC-DS: Total hot run time: 185455 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 32baf163bd10a267c87ddf4533740039d9f08951, data reload: false

query1	994	373	383	373
query2	6521	1739	1761	1739
query3	6742	207	211	207
query4	26212	23188	22886	22886
query5	4368	584	438	438
query6	327	211	203	203
query7	4613	480	293	293
query8	271	222	215	215
query9	8598	2628	2652	2628
query10	464	323	273	273
query11	15730	14897	14882	14882
query12	168	103	104	103
query13	1654	534	395	395
query14	9480	5735	5857	5735
query15	209	193	174	174
query16	7670	438	267	267
query17	1406	745	605	605
query18	2020	407	311	311
query19	202	188	179	179
query20	120	117	115	115
query21	213	125	105	105
query22	4335	4270	4603	4270
query23	34986	33793	33684	33684
query24	8415	2373	2364	2364
query25	520	439	385	385
query26	1217	258	143	143
query27	2733	507	339	339
query28	4274	2125	2107	2107
query29	721	547	450	450
query30	278	213	192	192
query31	918	833	761	761
query32	75	61	59	59
query33	533	342	272	272
query34	791	878	500	500
query35	568	626	535	535
query36	960	956	866	866
query37	107	96	76	76
query38	4193	4057	4010	4010
query39	1454	1403	1415	1403
query40	205	113	98	98
query41	53	51	60	51
query42	129	107	109	107
query43	508	507	473	473
query44	1298	825	814	814
query45	171	162	166	162
query46	824	996	618	618
query47	1730	1794	1718	1718
query48	374	414	305	305
query49	737	472	385	385
query50	631	683	395	395
query51	4109	4211	4156	4156
query52	109	113	100	100
query53	225	245	179	179
query54	577	553	496	496
query55	80	77	84	77
query56	288	294	275	275
query57	1173	1192	1105	1105
query58	282	245	248	245
query59	2595	2728	2547	2547
query60	330	311	300	300
query61	123	120	119	119
query62	792	738	661	661
query63	215	182	184	182
query64	4343	1170	846	846
query65	4260	4116	4193	4116
query66	1044	461	309	309
query67	15773	15507	15412	15412
query68	8972	892	544	544
query69	491	300	264	264
query70	1183	1097	1079	1079
query71	478	308	311	308
query72	5802	4639	4577	4577
query73	688	565	350	350
query74	9140	9173	8741	8741
query75	4221	3177	2687	2687
query76	3733	1135	721	721
query77	795	423	291	291
query78	10839	10932	10363	10363
query79	4037	806	571	571
query80	637	503	417	417
query81	464	253	223	223
query82	532	119	94	94
query83	275	240	233	233
query84	290	101	84	84
query85	782	346	310	310
query86	331	302	285	285
query87	4479	4445	4262	4262
query88	2838	2260	2252	2252
query89	436	313	279	279
query90	1956	207	199	199
query91	145	130	106	106
query92	68	61	54	54
query93	2372	936	579	579
query94	676	316	191	191
query95	369	289	306	289
query96	485	568	276	276
query97	2765	2781	2584	2584
query98	221	206	206	206
query99	1468	1403	1243	1243
Total cold run time: 280006 ms
Total hot run time: 185455 ms

@doris-robot
Copy link

doris-robot commented Jul 9, 2025

ClickBench: Total hot run time: 29.36 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 32baf163bd10a267c87ddf4533740039d9f08951, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.05	0.05
query3	0.25	0.07	0.07
query4	1.65	0.11	0.10
query5	0.43	0.42	0.41
query6	1.16	0.67	0.65
query7	0.02	0.01	0.02
query8	0.04	0.04	0.03
query9	0.59	0.50	0.53
query10	0.58	0.57	0.55
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.61	0.61
query14	0.80	0.80	0.81
query15	0.91	0.87	0.88
query16	0.38	0.39	0.40
query17	1.02	1.07	1.03
query18	0.22	0.21	0.21
query19	2.00	1.82	1.79
query20	0.01	0.01	0.02
query21	15.40	0.89	0.54
query22	0.75	1.30	0.87
query23	14.73	1.39	0.65
query24	6.99	1.45	0.49
query25	0.54	0.19	0.21
query26	0.64	0.15	0.13
query27	0.05	0.05	0.05
query28	9.85	0.94	0.45
query29	12.61	4.03	3.31
query30	0.25	0.09	0.06
query31	2.84	0.60	0.38
query32	3.24	0.55	0.46
query33	3.14	3.03	3.05
query34	16.05	5.45	4.81
query35	4.83	4.79	4.82
query36	0.68	0.50	0.49
query37	0.09	0.07	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.03
query40	0.17	0.14	0.14
query41	0.07	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 104.18 s
Total hot run time: 29.36 s

@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 10, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 10, 2025

TPC-H: Total hot run time: 33195 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0bec766ea12fb6d6409433edee97e7d8a0519000, data reload: false

------ Round 1 ----------------------------------
q1	17563	5221	5047	5047
q2	1928	282	183	183
q3	10312	1292	736	736
q4	10226	1000	514	514
q5	7653	2429	2271	2271
q6	177	159	129	129
q7	915	744	588	588
q8	9316	1293	1095	1095
q9	7385	5146	4994	4994
q10	6956	2399	1949	1949
q11	477	285	284	284
q12	333	354	220	220
q13	17756	3723	3093	3093
q14	231	230	225	225
q15	566	476	478	476
q16	429	430	375	375
q17	591	876	364	364
q18	7768	7255	7135	7135
q19	1245	936	558	558
q20	344	368	224	224
q21	3944	3216	2435	2435
q22	361	327	300	300
Total cold run time: 106476 ms
Total hot run time: 33195 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5123	5141	5100	5100
q2	255	327	222	222
q3	2232	2672	2341	2341
q4	1333	1789	1356	1356
q5	4270	4464	4627	4464
q6	218	175	126	126
q7	2024	1986	1857	1857
q8	2659	2586	2622	2586
q9	7327	7473	7221	7221
q10	3101	3361	2843	2843
q11	576	554	489	489
q12	735	816	726	726
q13	3608	3985	3363	3363
q14	313	317	328	317
q15	551	489	488	488
q16	446	503	482	482
q17	1201	1541	1421	1421
q18	8018	7844	7610	7610
q19	842	880	1075	880
q20	2015	2073	1992	1992
q21	5050	4608	4535	4535
q22	645	621	540	540
Total cold run time: 52542 ms
Total hot run time: 50959 ms

@doris-robot
Copy link

doris-robot commented Jul 10, 2025

TPC-DS: Total hot run time: 186743 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0bec766ea12fb6d6409433edee97e7d8a0519000, data reload: false

query1	1007	376	378	376
query2	6509	1763	1813	1763
query3	6751	209	215	209
query4	26408	23231	22966	22966
query5	4298	562	426	426
query6	302	215	202	202
query7	4640	503	305	305
query8	265	228	205	205
query9	8578	2616	2624	2616
query10	466	317	254	254
query11	15289	15270	14806	14806
query12	152	109	104	104
query13	1634	528	450	450
query14	8609	5957	5988	5957
query15	206	197	178	178
query16	7149	440	287	287
query17	1296	733	595	595
query18	1983	426	326	326
query19	198	191	175	175
query20	122	131	115	115
query21	216	128	115	115
query22	4034	4143	4418	4143
query23	34990	33823	34218	33823
query24	8464	2387	2320	2320
query25	584	496	389	389
query26	1236	263	141	141
query27	2778	521	345	345
query28	4276	2142	2115	2115
query29	753	541	411	411
query30	280	216	190	190
query31	879	823	740	740
query32	70	60	58	58
query33	551	321	283	283
query34	788	857	499	499
query35	628	650	574	574
query36	956	979	895	895
query37	110	95	72	72
query38	4077	4183	4084	4084
query39	1482	1414	1431	1414
query40	205	115	99	99
query41	58	51	49	49
query42	124	106	107	106
query43	522	533	500	500
query44	1308	818	818	818
query45	173	175	167	167
query46	870	1024	620	620
query47	1764	1778	1744	1744
query48	380	415	300	300
query49	744	488	386	386
query50	626	695	416	416
query51	4064	4294	4064	4064
query52	112	102	95	95
query53	226	249	182	182
query54	594	565	505	505
query55	82	78	78	78
query56	306	291	280	280
query57	1170	1209	1098	1098
query58	266	251	259	251
query59	2697	2836	2711	2711
query60	335	327	323	323
query61	131	127	130	127
query62	766	734	688	688
query63	230	183	209	183
query64	4422	1153	798	798
query65	4258	4190	4207	4190
query66	1140	405	301	301
query67	15626	15471	15312	15312
query68	8379	894	530	530
query69	507	327	268	268
query70	1299	1117	1079	1079
query71	489	317	302	302
query72	5689	4855	4947	4855
query73	723	660	360	360
query74	8890	9225	8990	8990
query75	3949	3184	2681	2681
query76	3763	1148	767	767
query77	784	396	314	314
query78	11038	11035	10235	10235
query79	2385	823	584	584
query80	571	501	436	436
query81	493	249	219	219
query82	471	124	94	94
query83	249	251	250	250
query84	241	110	81	81
query85	842	350	376	350
query86	389	304	292	292
query87	4427	4341	4372	4341
query88	3630	2300	2284	2284
query89	382	319	278	278
query90	1874	202	206	202
query91	141	142	107	107
query92	73	57	63	57
query93	1660	964	580	580
query94	668	313	198	198
query95	374	284	284	284
query96	482	571	279	279
query97	2773	2779	2663	2663
query98	230	215	197	197
query99	1338	1363	1269	1269
Total cold run time: 275416 ms
Total hot run time: 186743 ms

@doris-robot
Copy link

doris-robot commented Jul 10, 2025

ClickBench: Total hot run time: 29.22 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0bec766ea12fb6d6409433edee97e7d8a0519000, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.04	0.04
query3	0.24	0.07	0.07
query4	1.64	0.11	0.11
query5	0.45	0.41	0.41
query6	1.16	0.65	0.65
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.62	0.51	0.52
query10	0.57	0.57	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	0.80	0.82	0.83
query15	0.93	0.89	0.85
query16	0.40	0.40	0.38
query17	1.06	1.04	1.08
query18	0.22	0.20	0.21
query19	1.91	1.91	1.82
query20	0.01	0.02	0.02
query21	15.38	0.87	0.54
query22	0.74	1.17	0.66
query23	15.03	1.40	0.61
query24	6.92	1.99	0.44
query25	0.39	0.28	0.09
query26	0.63	0.16	0.14
query27	0.06	0.06	0.05
query28	8.94	0.95	0.46
query29	12.53	4.01	3.40
query30	0.25	0.10	0.06
query31	2.86	0.61	0.38
query32	3.23	0.56	0.48
query33	3.18	3.15	3.18
query34	16.11	5.34	4.77
query35	4.83	4.79	4.83
query36	0.68	0.51	0.50
query37	0.10	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.18	0.14	0.14
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.03	0.02	0.02
Total cold run time: 103.38 s
Total hot run time: 29.22 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 10, 2025

FE UT Coverage Report

Increment line coverage 4.17% (1/24) 🎉
Increment coverage report
Complete coverage report

@zclllyybb zclllyybb marked this pull request as ready for review July 10, 2025 10:28
@zclllyybb
Copy link
Contributor Author

zclllyybb commented Jul 10, 2025

run buildall

@zclllyybb zclllyybb changed the title [Fix](dictionary) fix wrong partial load in extreme case [Fix](dictionary) Fix show dictionaries get wrong status result in follower Jul 10, 2025
@doris-robot
Copy link

doris-robot commented Jul 10, 2025

TPC-H: Total hot run time: 33173 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 470d91590a0b2075f8d0f7b0253e6d62d2681bec, data reload: false

------ Round 1 ----------------------------------
q1	17576	5174	5028	5028
q2	1960	295	189	189
q3	10257	1280	722	722
q4	10225	1002	536	536
q5	7582	2388	2345	2345
q6	181	163	127	127
q7	898	743	599	599
q8	9291	1299	1076	1076
q9	6813	5068	5140	5068
q10	6900	2380	1955	1955
q11	490	293	286	286
q12	339	349	207	207
q13	17753	3670	3057	3057
q14	240	218	209	209
q15	551	493	487	487
q16	415	417	377	377
q17	604	864	356	356
q18	7685	7251	7173	7173
q19	1428	952	542	542
q20	336	336	214	214
q21	3671	2539	2320	2320
q22	348	313	300	300
Total cold run time: 105543 ms
Total hot run time: 33173 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5091	5076	5057	5057
q2	243	329	228	228
q3	2169	2652	2321	2321
q4	1367	1780	1362	1362
q5	4230	4076	4556	4076
q6	212	170	124	124
q7	2043	1960	1828	1828
q8	2604	2626	2637	2626
q9	7424	7216	7328	7216
q10	3185	3290	2809	2809
q11	589	565	532	532
q12	695	745	642	642
q13	3645	3934	3376	3376
q14	300	300	295	295
q15	543	489	501	489
q16	448	502	474	474
q17	1186	1533	1454	1454
q18	7801	7576	7700	7576
q19	886	867	959	867
q20	2030	1940	1803	1803
q21	5204	4331	4289	4289
q22	617	573	538	538
Total cold run time: 52512 ms
Total hot run time: 49982 ms

@doris-robot
Copy link

doris-robot commented Jul 10, 2025

TPC-DS: Total hot run time: 186569 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 470d91590a0b2075f8d0f7b0253e6d62d2681bec, data reload: false

query1	1001	390	393	390
query2	6526	1822	1792	1792
query3	6739	207	212	207
query4	26689	23182	23302	23182
query5	4329	579	423	423
query6	285	216	197	197
query7	4631	491	289	289
query8	281	230	211	211
query9	8632	2659	2623	2623
query10	468	334	269	269
query11	15811	15426	14777	14777
query12	169	103	104	103
query13	1645	543	396	396
query14	9605	5945	5914	5914
query15	208	197	164	164
query16	7556	613	484	484
query17	1199	735	612	612
query18	2017	406	310	310
query19	202	196	161	161
query20	121	120	109	109
query21	218	134	110	110
query22	3960	4159	3987	3987
query23	33702	33043	33101	33043
query24	8448	2358	2377	2358
query25	518	464	397	397
query26	717	270	147	147
query27	2704	500	344	344
query28	4357	2136	2098	2098
query29	647	568	439	439
query30	282	214	178	178
query31	887	838	745	745
query32	68	64	62	62
query33	571	387	314	314
query34	808	840	526	526
query35	776	812	739	739
query36	932	969	872	872
query37	114	101	76	76
query38	4254	4126	3992	3992
query39	1497	1459	1411	1411
query40	210	116	109	109
query41	56	55	54	54
query42	125	108	109	108
query43	523	512	505	505
query44	1346	829	820	820
query45	172	169	162	162
query46	836	1030	620	620
query47	1759	1750	1724	1724
query48	384	415	308	308
query49	714	479	388	388
query50	649	702	422	422
query51	5442	5657	5493	5493
query52	109	118	98	98
query53	222	262	177	177
query54	574	588	499	499
query55	82	81	83	81
query56	304	313	279	279
query57	1167	1190	1136	1136
query58	263	249	273	249
query59	2656	2744	2641	2641
query60	328	322	318	318
query61	138	125	128	125
query62	789	727	654	654
query63	230	184	191	184
query64	3102	1063	683	683
query65	4288	4205	4162	4162
query66	909	403	330	330
query67	15615	15458	15337	15337
query68	8207	917	526	526
query69	487	302	268	268
query70	1211	1112	1082	1082
query71	465	322	295	295
query72	5696	4705	4770	4705
query73	731	617	355	355
query74	8999	9061	8837	8837
query75	3882	3169	2701	2701
query76	3598	1155	770	770
query77	792	384	293	293
query78	10150	10266	9321	9321
query79	2167	841	617	617
query80	610	541	440	440
query81	490	262	223	223
query82	451	128	99	99
query83	260	266	237	237
query84	252	103	99	99
query85	819	367	361	361
query86	390	299	285	285
query87	4477	4456	4341	4341
query88	3506	2300	2310	2300
query89	379	332	294	294
query90	1844	216	214	214
query91	147	150	113	113
query92	70	64	57	57
query93	1676	962	587	587
query94	677	412	294	294
query95	380	295	284	284
query96	497	581	291	291
query97	2714	2740	2674	2674
query98	249	207	211	207
query99	1694	1430	1282	1282
Total cold run time: 274533 ms
Total hot run time: 186569 ms

@doris-robot
Copy link

doris-robot commented Jul 10, 2025

ClickBench: Total hot run time: 29.99 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 470d91590a0b2075f8d0f7b0253e6d62d2681bec, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.25	0.08	0.07
query4	1.62	0.11	0.11
query5	0.45	0.42	0.41
query6	1.16	0.68	0.66
query7	0.02	0.02	0.02
query8	0.05	0.03	0.03
query9	0.60	0.51	0.52
query10	0.57	0.57	0.57
query11	0.16	0.11	0.11
query12	0.16	0.12	0.11
query13	0.63	0.61	0.61
query14	0.79	0.80	0.86
query15	0.90	0.86	0.87
query16	0.39	0.39	0.39
query17	1.07	1.06	1.07
query18	0.22	0.21	0.21
query19	2.02	1.85	1.86
query20	0.01	0.01	0.02
query21	15.40	0.86	0.53
query22	0.75	1.24	0.69
query23	14.82	1.37	0.63
query24	6.93	1.11	1.30
query25	0.50	0.29	0.09
query26	0.56	0.17	0.14
query27	0.06	0.05	0.06
query28	10.30	0.92	0.45
query29	12.59	4.08	3.35
query30	0.25	0.10	0.07
query31	2.83	0.61	0.39
query32	3.22	0.56	0.47
query33	3.05	3.14	3.14
query34	15.94	5.43	4.76
query35	4.86	4.83	4.86
query36	0.71	0.51	0.50
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.15	0.14
query41	0.09	0.02	0.03
query42	0.04	0.03	0.02
query43	0.03	0.02	0.02
Total cold run time: 104.47 s
Total hot run time: 29.99 s

HappenLee
HappenLee approved these changes Jul 14, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2025

PR approved by anyone and no changes requested.

@zclllyybb zclllyybb merged commit 126549f into apache:master Jul 14, 2025
27 of 29 checks passed
@zclllyybb zclllyybb deleted the dict_partial_load branch July 14, 2025 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zclllyybb @Thearas @doris-robot @hello-stephen @BiteTheDDDDt @HappenLee