-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[refactor](cloud) Use unified function to refresh instance info #53121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor](cloud) Use unified function to refresh instance info #53121
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
| } | ||
|
|
||
| add_cluster_to_index(instance_id, cluster.cluster); | ||
| refresh_instance(instance_id, instance); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there (the original impl. also) may be a bug that before L499 is called there could be another MS update the instancePB in KV, however the possibility is very low and seems will never happen:
- call to L449 is very fast, in microsecs
- the remote MS update will trigger a
refresh_signalto all other instance, which make all MS eventually consistent
CC @deardeng
gavinchou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)