Skip to content

Conversation

@luwei16
Copy link
Contributor

@luwei16 luwei16 commented Jul 18, 2025

pick master #53244

@luwei16 luwei16 requested a review from dataroaring as a code owner July 18, 2025 10:05
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@luwei16
Copy link
Contributor Author

luwei16 commented Jul 18, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39433 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d0b00f4615c40f53bd235cbf6d83c6b83a12e753, data reload: false

------ Round 1 ----------------------------------
q1	17588	6775	6569	6569
q2	2068	181	186	181
q3	10578	1099	1157	1099
q4	10235	756	647	647
q5	7754	2823	2822	2822
q6	213	131	129	129
q7	974	609	607	607
q8	9354	1901	2001	1901
q9	6588	6351	6419	6351
q10	7058	2220	2301	2220
q11	471	269	270	269
q12	410	210	211	210
q13	17791	2956	2973	2956
q14	248	205	219	205
q15	509	474	482	474
q16	502	391	395	391
q17	984	600	585	585
q18	7125	6562	6773	6562
q19	1508	1030	1027	1027
q20	489	203	203	203
q21	4081	3203	3071	3071
q22	1082	954	996	954
Total cold run time: 107610 ms
Total hot run time: 39433 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6709	6552	6543	6543
q2	333	231	232	231
q3	2883	2924	2957	2924
q4	2012	1823	1776	1776
q5	5748	5696	5687	5687
q6	204	129	131	129
q7	2209	1774	1789	1774
q8	3320	3510	3498	3498
q9	8703	8814	8856	8814
q10	3547	3482	3474	3474
q11	576	487	494	487
q12	811	588	606	588
q13	8362	3177	3131	3131
q14	301	278	286	278
q15	505	470	475	470
q16	504	444	436	436
q17	1825	1608	1598	1598
q18	8216	7770	7937	7770
q19	1680	1460	1602	1460
q20	2051	1808	1812	1808
q21	5145	5118	4994	4994
q22	1099	1075	1015	1015
Total cold run time: 66743 ms
Total hot run time: 58885 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196742 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d0b00f4615c40f53bd235cbf6d83c6b83a12e753, data reload: false

query1	1273	926	891	891
query2	6375	1914	1808	1808
query3	10823	4280	4070	4070
query4	33310	23461	23893	23461
query5	4955	450	434	434
query6	286	180	186	180
query7	3998	326	329	326
query8	295	234	225	225
query9	9552	2577	2572	2572
query10	506	279	287	279
query11	18239	15068	15132	15068
query12	155	107	105	105
query13	1577	421	424	421
query14	9857	7161	7359	7161
query15	276	187	187	187
query16	8072	473	478	473
query17	1588	621	588	588
query18	2165	328	333	328
query19	325	180	179	179
query20	125	119	116	116
query21	207	113	113	113
query22	4762	4515	4444	4444
query23	34986	34008	34076	34008
query24	11555	3014	3068	3014
query25	672	457	434	434
query26	1222	176	174	174
query27	2427	354	365	354
query28	7298	2126	2186	2126
query29	867	523	469	469
query30	257	161	160	160
query31	1050	840	829	829
query32	97	56	61	56
query33	758	301	295	295
query34	1133	529	523	523
query35	907	737	719	719
query36	1134	918	976	918
query37	126	72	65	65
query38	4127	3983	4029	3983
query39	1500	1459	1442	1442
query40	208	103	104	103
query41	51	49	47	47
query42	123	103	98	98
query43	536	462	481	462
query44	1295	823	827	823
query45	187	170	172	170
query46	1171	756	721	721
query47	1964	1882	1881	1881
query48	520	411	395	395
query49	981	407	382	382
query50	816	427	442	427
query51	7459	7230	7259	7230
query52	102	92	87	87
query53	258	188	186	186
query54	1268	481	476	476
query55	78	80	83	80
query56	280	271	253	253
query57	1305	1223	1186	1186
query58	234	228	215	215
query59	3151	3068	2913	2913
query60	286	259	256	256
query61	125	108	108	108
query62	868	688	698	688
query63	233	196	196	196
query64	4108	691	662	662
query65	3350	3262	3234	3234
query66	762	295	310	295
query67	15909	15636	15409	15409
query68	4569	570	565	565
query69	444	264	266	264
query70	1165	1092	1100	1092
query71	334	278	254	254
query72	6359	4041	4077	4041
query73	775	351	346	346
query74	10445	9006	9007	9006
query75	3363	2638	2615	2615
query76	2718	1125	1094	1094
query77	372	269	279	269
query78	10568	9523	9501	9501
query79	1691	606	597	597
query80	1149	439	427	427
query81	564	229	233	229
query82	943	94	91	91
query83	232	146	142	142
query84	243	75	80	75
query85	1330	304	289	289
query86	392	294	300	294
query87	4469	4439	4460	4439
query88	3897	2506	2459	2459
query89	418	299	294	294
query90	1928	192	190	190
query91	185	152	146	146
query92	59	52	51	51
query93	1789	550	554	550
query94	832	292	293	292
query95	368	265	259	259
query96	616	287	283	283
query97	3281	3107	3107	3107
query98	221	196	204	196
query99	1536	1340	1304	1304
Total cold run time: 303720 ms
Total hot run time: 196742 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.84% (11119/26574)
Line Coverage 32.40% (95224/293903)
Region Coverage 31.57% (49139/155666)
Branch Coverage 27.96% (25174/90034)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 18, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

ClickBench: Total hot run time: 31.18 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d0b00f4615c40f53bd235cbf6d83c6b83a12e753, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.11	0.10
query5	0.52	0.51	0.53
query6	1.13	0.72	0.72
query7	0.02	0.02	0.02
query8	0.03	0.03	0.03
query9	0.57	0.50	0.51
query10	0.55	0.57	0.54
query11	0.17	0.10	0.10
query12	0.14	0.12	0.11
query13	0.61	0.59	0.61
query14	0.77	0.78	0.84
query15	0.85	0.83	0.84
query16	0.38	0.36	0.39
query17	0.99	1.01	0.98
query18	0.25	0.23	0.21
query19	1.96	1.86	1.84
query20	0.01	0.01	0.01
query21	15.40	0.58	0.58
query22	2.28	2.08	2.11
query23	17.04	1.04	0.87
query24	3.34	1.98	1.64
query25	0.23	0.15	0.23
query26	0.54	0.13	0.14
query27	0.04	0.04	0.04
query28	8.60	0.54	0.54
query29	12.61	3.22	3.21
query30	0.25	0.06	0.06
query31	2.85	0.39	0.38
query32	3.24	0.46	0.46
query33	2.97	2.97	3.01
query34	17.21	4.46	4.43
query35	4.55	4.51	4.55
query36	0.66	0.49	0.48
query37	0.09	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.16	0.12	0.12
query41	0.09	0.03	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.21 s
Total hot run time: 31.18 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.95% (19657/26228)
Line Coverage 68.21% (200205/293507)
Region Coverage 66.36% (119623/180270)
Branch Coverage 59.75% (60807/101772)

@dataroaring dataroaring merged commit 3f04357 into apache:branch-3.0 Jul 18, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants