Skip to content

branch-3.1: [fix](mow) fix agg delete bitmap for stale rowsets #53611 #53662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 1 commit into from
Jul 22, 2025
Merged

branch-3.1: [fix](mow) fix agg delete bitmap for stale rowsets #53611 #53662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/cloud/cloud_tablet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,8 +500,8 @@ uint64_t CloudTablet::delete_expired_stale_rowsets() {
}

add_unused_rowsets(expired_rowsets);
if (keys_type() == UNIQUE_KEYS && enable_unique_key_merge_on_write() &&
!deleted_stale_rowsets.empty()) {
if (config::enable_agg_and_remove_pre_rowsets_delete_bitmap && keys_type() == UNIQUE_KEYS &&
enable_unique_key_merge_on_write() && !deleted_stale_rowsets.empty()) {
// agg delete bitmap for pre rowsets; record unused delete bitmap key ranges
OlapStopWatch watch;
for (const auto& [version, unused_rowsets] : deleted_stale_rowsets) {
Expand Down
3 changes: 3 additions & 0 deletions be/src/olap/base_tablet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1750,6 +1750,9 @@ void BaseTablet::agg_delete_bitmap_for_stale_rowsets(
}
int64_t start_version = version.first;
int64_t end_version = version.second;
if (start_version == end_version) {
return;
}
DCHECK(start_version < end_version)
<< ". start_version: " << start_version << ", end_version: " << end_version;
// get pre rowsets
Expand Down
2 changes: 1 addition & 1 deletion be/src/olap/tablet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ void Tablet::delete_expired_stale_rowset() {
<< " old_meta_size=" << old_meta_size << " sweep endtime " << std::fixed
<< expired_stale_sweep_endtime << ", reconstructed=" << reconstructed;
}
if (!deleted_stale_rowsets.empty()) {
if (config::enable_agg_and_remove_pre_rowsets_delete_bitmap && !deleted_stale_rowsets.empty()) {
// agg delete bitmap for pre rowsets; record unused delete bitmap key ranges
OlapStopWatch watch;
for (const auto& [version, remove_rowset_ids] : deleted_stale_rowsets) {
Expand Down
Loading