branch-3.0: [fix](nereids) fix rewrite avg to sum / count change nullable #53787#53862
Closed
github-actions[bot] wants to merge 1 commit intobranch-3.0from
Closed
branch-3.0: [fix](nereids) fix rewrite avg to sum / count change nullable #53787#53862github-actions[bot] wants to merge 1 commit intobranch-3.0from
github-actions[bot] wants to merge 1 commit intobranch-3.0from
Conversation
### What problem does this PR solve? for sql select avg(distinct a), sum(distinct b) from t group by c if "a" is not nullable, then "avg" is not nullable, AvgDistinctToSumDivCount will rewrite "avg" to "sum(distinct a) / count(distinct a)", but the divide "/" is nullable, then AdjustNullable will throw exception for this changed nullable (introduced by #52748): "AdjustNullable convert slot avg(..)#10 from not-nullable to nullable. You can disable check by set fe_debug = false." need add a nonNullable function to make the rewritten expression not-nullable.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #53787