[feat](map) remove duplicated keys in ColumnMap #54068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Member
Author
|
run buildall |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
github-actions
bot
added
the
lfs-detected!
TPC-H: Total hot run time: 33786 ms |
TPC-DS: Total hot run time: 173861 ms |
ClickBench: Total hot run time: 32.59 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Member
Author
|
run buildall |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
Contributor
FE UT Coverage ReportIncrement line coverage |
TPC-H: Total hot run time: 34171 ms |
TPC-DS: Total hot run time: 162234 ms |
ClickBench: Total hot run time: 32.76 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
Member
Author
|
run buildall |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 34142 ms |
TPC-DS: Total hot run time: 172407 ms |
ClickBench: Total hot run time: 33.65 s |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
csun5285
reviewed
Aug 1, 2025
| assert_cast<const ColumnArray&>(*k_arr).get_offsets_ptr()); | ||
| } | ||
|
|
||
| Status ColumnMap::deduplicate_keys(bool recursive) { |
mrhhsg
force-pushed
the
deduplicate_keys
branch
from
b08eae0 to
24cea7b
Compare
Member
Author
|
run buildall |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
TPC-H: Total hot run time: 34630 ms |
csun5285
reviewed
Sep 10, 2025
| result_col_map_offsets[row] = offset; | ||
| } | ||
|
|
||
| RETURN_IF_ERROR(map_column->deduplicate_keys()); |
Contributor
There was a problem hiding this comment.
map_column->deduplicate_keys(true)? 比如是：map(2, map(2, 3, 2, 3))
| const auto inner_rows = keys_column->size(); | ||
| const auto rows = offsets_column->size(); | ||
|
|
||
| if (recursive) { |
Contributor
There was a problem hiding this comment.
这里是不是总是检查嵌套的map ，如果是就去去重一遍，这样调用 deduplicate_keys 不用考虑是否嵌套了。
Member
Author
There was a problem hiding this comment.
理论上咱们生成一个 map column 时会就会去重，那么大部分场景下可能不需要递归式的去重。
TPC-DS: Total hot run time: 188693 ms |
ClickBench: Total hot run time: 29.68 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
mrhhsg
force-pushed
the
deduplicate_keys
branch
from
24cea7b to
23d61a4
Compare
Member
Author
|
run buildall |
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
TPC-H: Total hot run time: 34873 ms |
TPC-DS: Total hot run time: 189719 ms |
ClickBench: Total hot run time: 30.01 s |
Contributor
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
FE Regression Coverage ReportIncrement line coverage |
yiguolei
approved these changes
Sep 11, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Sep 11, 2025
Contributor
Possible file(s) that should be tracked in LFS detected: 🚨The following file(s) exceeds the file size limit:
Consider using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Doc: apache/doris-website#2676
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)